From: Gene Chen <gene.chen.richtek@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>,
Matthias Brugger <matthias.bgg@gmail.com>,
Dan Murphy <dmurphy@ti.com>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Gene Chen <gene_chen@richtek.com>,
Wilma.Wu@mediatek.com, shufan_lee@richtek.com,
cy_huang@richtek.com, benjamin.chao@mediatek.com
Subject: Re: [PATCH v4 1/2] dt-bindings: leds: Add bindings for MT6360 LED
Date: Wed, 30 Sep 2020 23:17:51 +0800 [thread overview]
Message-ID: <CAE+NS35qEzfixkBJn17Ookqf8NZDwr+2RmDGGZTThMUHy=Yttg@mail.gmail.com> (raw)
In-Reply-To: <20200928184423.GA3041988@bogus>
Rob Herring <robh@kernel.org> 於 2020年9月29日 週二 上午2:44寫道:
>
> On Wed, Sep 23, 2020 at 08:50:51PM +0800, Gene Chen wrote:
> > From: Gene Chen <gene_chen@richtek.com>
> >
> > Add bindings document for LED support on MT6360 PMIC
> >
> > Signed-off-by: Gene Chen <gene_chen@richtek.com>
> > ---
> > .../devicetree/bindings/leds/leds-mt6360.yaml | 107 +++++++++++++++++++++
> > 1 file changed, 107 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/leds/leds-mt6360.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/leds/leds-mt6360.yaml b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
> > new file mode 100644
> > index 0000000..a356a1f
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/leds/leds-mt6360.yaml
> > @@ -0,0 +1,107 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/leds/leds-mt6360.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: LED driver for MT6360 PMIC from MediaTek Integrated.
>
> Where's the PMIC schema? This file needs to be referenced from it and
> that means it all needs to be one series.
>
Do you means as regulator/max77650-regulator.yaml?
description: |
This module is part of the MAX77650 MFD device. For more details
"see Documentation/devicetree/bindings/mfd/max77650.yaml"
> > +
> > +maintainers:
> > + - Gene Chen <gene_chen@richtek.com>
> > +
> > +description: |
> > + This module is part of the MT6360 MFD device.
> > + Add MT6360 LED driver include 2-channel Flash LED with torch/strobe mode,
> > + and 4-channel RGB LED support Register/Flash/Breath Mode
> > +
> > +properties:
> > + compatible:
> > + const: mediatek,mt6360-led
> > +
> > + "#address-cells":
> > + const: 1
> > +
> > + "#size-cells":
> > + const: 0
> > +
> > +patternProperties:
> > + "^led@[0-5]$":
> > + type: object
> > + $ref: common.yaml#
> > + description:
> > + Properties for a single LED.
> > +
> > + properties:
> > + reg:
> > + description: Index of the LED.
> > + enum:
> > + - 0 # LED output INDICATOR1
> > + - 1 # LED output INDICATOR2
> > + - 2 # LED output INDICATOR3
> > + - 3 # LED output INDICATOR4
> > + - 4 # LED output FLED1
> > + - 5 # LED output FLED2
> > +
> > +unevaluatedProperties: false
> > +
> > +required:
> > + - compatible
> > + - "#address-cells"
> > + - "#size-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/leds/common.h>
> > + led-controller {
> > + compatible = "mediatek,mt6360-led";
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + led@0 {
> > + reg = <0>;
> > + function = LED_FUNCTION_INDICATOR;
> > + color = <LED_COLOR_ID_RED>;
> > + default-state = "off";
> > + };
> > + led@1 {
> > + reg = <1>;
> > + function = LED_FUNCTION_INDICATOR;
> > + color = <LED_COLOR_ID_GREEN>;
> > + default-state = "off";
> > + };
> > + led@2 {
> > + reg = <2>;
> > + function = LED_FUNCTION_INDICATOR;
> > + color = <LED_COLOR_ID_BLUE>;
> > + default-state = "off";
> > + };
> > + led@3 {
> > + reg = <3>;
> > + function = LED_FUNCTION_INDICATOR;
> > + color = <LED_COLOR_ID_AMBER>;
> > + default-state = "off";
> > + };
> > + led@4 {
> > + reg = <4>;
> > + function = LED_FUNCTION_FLASH;
> > + color = <LED_COLOR_ID_WHITE>;
> > + function-enumerator = <1>;
> > + default-state = "off";
> > + led-max-microamp = <200000>;
> > + flash-max-microamp = <500000>;
> > + flash-max-timeout-us = <1024000>;
> > + };
> > + led@5 {
> > + reg = <5>;
> > + function = LED_FUNCTION_FLASH;
> > + color = <LED_COLOR_ID_WHITE>;
> > + function-enumerator = <2>;
> > + default-state = "off";
> > + led-max-microamp = <200000>;
> > + flash-max-microamp = <500000>;
> > + flash-max-timeout-us = <1024000>;
> > + };
> > + };
> > +...
> > --
> > 2.7.4
> >
next prev parent reply other threads:[~2020-09-30 7:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-23 12:50 [PATCH v4 0/2] leds: mt6360: Add LED driver for MT6360 Gene Chen
2020-09-23 12:50 ` [PATCH v4 1/2] dt-bindings: leds: Add bindings for MT6360 LED Gene Chen
2020-09-28 18:44 ` Rob Herring
2020-09-30 15:17 ` Gene Chen [this message]
2020-10-01 10:12 ` Gene Chen
2020-09-23 12:50 ` [PATCH v4 2/2] leds: mt6360: Add LED driver for MT6360 Gene Chen
2020-09-23 21:49 ` Jacek Anaszewski
2020-09-24 6:21 ` Gene Chen
2020-09-24 21:49 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE+NS35qEzfixkBJn17Ookqf8NZDwr+2RmDGGZTThMUHy=Yttg@mail.gmail.com' \
--to=gene.chen.richtek@gmail.com \
--cc=Wilma.Wu@mediatek.com \
--cc=benjamin.chao@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=gene_chen@richtek.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=robh@kernel.org \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).