From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A211C6379D for ; Tue, 17 Nov 2020 09:55:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB54B2168B for ; Tue, 17 Nov 2020 09:55:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CzawzkGY" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727727AbgKQJzL (ORCPT ); Tue, 17 Nov 2020 04:55:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727724AbgKQJzK (ORCPT ); Tue, 17 Nov 2020 04:55:10 -0500 Received: from mail-oi1-x241.google.com (mail-oi1-x241.google.com [IPv6:2607:f8b0:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B29DCC0613CF; Tue, 17 Nov 2020 01:55:10 -0800 (PST) Received: by mail-oi1-x241.google.com with SMTP id t16so21923434oie.11; Tue, 17 Nov 2020 01:55:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=g6cFr1GWe/3eh4NUqXWAinlK5cgfPVLY2u3q3tSx53o=; b=CzawzkGYSM3k6pL0T1hbwyHjk6lf4OIJYruDp2QL9npIt9xSBOSoriYK+lZN9iL+1X Rcg9c8kQYukPpCN7TI/x193Dnvx9ojNTqpQD9pRj/8HF9pLMqS+OHXMcCkLl9uqVDXOg +dpwSRi5RPt+5kwajoY5fEgEg6mIUXRavCobmMSmukmp+kmUagl1I+8xeqZCMAm2dOKj 5GapsgPY+wOutrJEWvwAD9zyseIihpDzWEpMAAonb1aiZ8MVdJRJOZdKhxs/Q7I5VokN eAVT1dU8mjcSJsiklHSwc26Qpa+BWC/Hdg3gS1B8COd1jgrAbqvhKWTj+NzoaSwfKFSJ /C8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=g6cFr1GWe/3eh4NUqXWAinlK5cgfPVLY2u3q3tSx53o=; b=AbUlJZPlCQqjuwh8j+YjzFrFuivBjD5/uGpOQI4OPWbflbQ9ZGAMxkreyys97ulHqM KDhWOaBPNv15HeIzJmqqS8Ikk44TBB3c9O62m6FzG7NqnrGam+rwNlJvQSD3fIJtoheK 1d+eIOsJmN+sNjLZv86mhWbt7Lg2cfjhvgSeBd8ZHVzdLAyacrugIQ1w1wsF/4MTworJ bLQxw8lYZy+2HDdrWVrZ+tsgT9NPgkzTlvw9LieRorJqOpE57PrFeg+rXTfxSdKGO8A8 d0gQpGMxoM0EtdqPRrpN3P7YA4mHoUJNpDA6JyhwuAtXDuOgWLfGEg2UzvsAe/+/9EuT zmtw== X-Gm-Message-State: AOAM5325/E6iPrcgvN/cRJnmaDYApXHuUIKR71Ie25A0ubtq+i37xRN/ z5sb+tmD1SggmlEIN+rfZINsvMSS0rJ4GCLnOOs= X-Google-Smtp-Source: ABdhPJya8F6HqaXOxv32vLbvDlmGZZUV8Q00KUBZXfRPq3qbh5S+PA3y0CdQ8g7uWdODqTVA4V0Epe3FABZHNroWpjk= X-Received: by 2002:aca:4783:: with SMTP id u125mr1917664oia.23.1605606909920; Tue, 17 Nov 2020 01:55:09 -0800 (PST) MIME-Version: 1.0 References: <1602034966-3524-1-git-send-email-gene.chen.richtek@gmail.com> <1602034966-3524-3-git-send-email-gene.chen.richtek@gmail.com> <5a9b31c4-739c-06fc-2015-ed474993ad22@gmail.com> <8925db23-5cc4-3c5f-932a-461fe6450dad@gmail.com> <1bb76c54-14af-6c78-4623-77c6678b262e@gmail.com> In-Reply-To: From: Gene Chen Date: Tue, 17 Nov 2020 17:54:58 +0800 Message-ID: Subject: Re: [PATCH v5 2/2] leds: mt6360: Add LED driver for MT6360 To: Jacek Anaszewski Cc: Pavel Machek , Rob Herring , Matthias Brugger , Dan Murphy , Linux LED Subsystem , devicetree , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Linux Kernel Mailing List , Gene Chen , Wilma.Wu@mediatek.com, shufan_lee@richtek.com, cy_huang@richtek.com, benjamin.chao@mediatek.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Jacek Anaszewski =E6=96=BC 2020=E5=B9=B411=E6= =9C=8817=E6=97=A5 =E9=80=B1=E4=BA=8C =E4=B8=8A=E5=8D=882:25=E5=AF=AB=E9=81= =93=EF=BC=9A > > On 11/16/20 11:01 AM, Gene Chen wrote: > > Jacek Anaszewski =E6=96=BC 2020=E5=B9=B410= =E6=9C=8831=E6=97=A5 =E9=80=B1=E5=85=AD =E4=B8=8A=E5=8D=886:34=E5=AF=AB=E9= =81=93=EF=BC=9A > >> > >> On 10/30/20 9:51 AM, Gene Chen wrote: > >>> Jacek Anaszewski =E6=96=BC 2020=E5=B9=B4= 10=E6=9C=8828=E6=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8A=E5=8D=881:28=E5=AF=AB= =E9=81=93=EF=BC=9A > >>>> > >>>> On 10/27/20 10:28 AM, Gene Chen wrote: > >>>>> Jacek Anaszewski =E6=96=BC 2020=E5=B9= =B410=E6=9C=8821=E6=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8A=E5=8D=885:47=E5=AF= =AB=E9=81=93=EF=BC=9A > >>>>>> > >>>>>> On 10/20/20 8:44 AM, Gene Chen wrote: > >>>>>>> Jacek Anaszewski =E6=96=BC 2020=E5= =B9=B410=E6=9C=889=E6=97=A5 =E9=80=B1=E4=BA=94 =E4=B8=8A=E5=8D=885:51=E5=AF= =AB=E9=81=93=EF=BC=9A > >>>>>>>> > >>>>>>>> Hi Gene, > >>>>>>>> > >>>>>>>> On 10/7/20 3:42 AM, Gene Chen wrote: > >>>>>>>>> From: Gene Chen > >>>>>>>>> > >>>>>>>>> Add MT6360 LED driver include 2-channel Flash LED with torch/st= robe mode, > >>>>>>>>> 3-channel RGB LED support Register/Flash/Breath Mode, and 1-cha= nnel for > >>>>>>>>> moonlight LED. > >>>>>>>>> > >>>>>>>>> Signed-off-by: Gene Chen > >>>>>>>>> --- > >>>>>>>>> drivers/leds/Kconfig | 12 + > >>>>>>>>> drivers/leds/Makefile | 1 + > >>>>>>>>> drivers/leds/leds-mt6360.c | 783 ++++++++++++++++++++++++= +++++++++++++++++++++ > >>>>>>>>> 3 files changed, 796 insertions(+) > >>>>>>>>> create mode 100644 drivers/leds/leds-mt6360.c > >>>>>>>>> > >>>>>>>>> diff --git a/drivers/leds/Kconfig b/drivers/leds/Kconfig > >>>>>>>>> index 1c181df..c7192dd 100644 > >>>>>>>>> --- a/drivers/leds/Kconfig > >>>>>>>>> +++ b/drivers/leds/Kconfig > >>>>>>>>> @@ -271,6 +271,18 @@ config LEDS_MT6323 > >>>>>>>>> This option enables support for on-chip LED drivers= found on > >>>>>>>>> Mediatek MT6323 PMIC. > >>>>>>>>> > >>>>>>>>> +config LEDS_MT6360 > >>>>>>>>> + tristate "LED Support for Mediatek MT6360 PMIC" > >>>>>>>>> + depends on LEDS_CLASS_FLASH && OF > >>>>>>>>> + depends on LEDS_CLASS_MULTICOLOR > >>>>>>>> > >>>>>>>> Since CONFIG_LED_CLASS_MULTICOLOR can be turned off you need to = have > >>>>>>>> below instead: > >>>>>>>> > >>>>>>>> depends on LEDS_CLASS_MULTICOLOR || !!LEDS_CLASS_MULTICOLOR > >>>> > >>>> My typo here, should be one "!": > >>>> > >>>> depends on LEDS_CLASS_MULTICOLOR || !LEDS_CLASS_MULTICOLOR > >>>> > >>>> And you should also have > >>>> > >>>> depends on LEDS_CLASS_FLASH || !LEDS_CLASS_FLASH > >>>> > >>>> But to make it work correctly you would have to add registration > >>>> stubs to include/linux/led-class-flash.h similarly to LED mc stubs > >>>> in include/linux/led-class-multicolor.h. > >>>> > >>>>>>>> > >>>>>>>> Unless you want to prevent enabling the driver without RGB LED, > >>>>>>>> but that does not seem to be reasonable at first glance. > >>>>>>>> > >>>>>>> > >>>>>>> May I change to "select LEDS_CLASS_MULTICOLOR"? > >>>>>>> I suppose RGB always use multicolor mode. > >>>>>> > >>>>>> You will also have moonlight LED that will not need multicolor > >>>>>> framework. Is it somehow troublesome to keep "depends on"? > >>>>>> > >>>>> > >>>>> If only use ML LED and FLED, DTSI will only define ML LED and FLED= . > >>>>> Therefore, the drivers probe will not register rgb multicolor devic= e. > >>>> > >>>> Please test your use case again with my fixed "depends on". > >>>> > >>>> In case when there is only ML LED and FLED in the DT it should > >>>> register both devices if LEDS_CLASS_FLASH is turned on. > >>>> Multicolor framework has nothing to do in this case. > >>>> > >>>> But if you additionally had MC LED node, then it should > >>>> be registered only if LEDS_CLASS_MULTICOLOR is enabled. > >>>> > >>>> Similarly, when FLED node is present, but LEDS_CLASS_FLASH > >>>> is off, and LEDS_CLASS_MULTICOLOR is on, the driver should still > >>>> compile, but register only LED MC device (if its node is present). > >>>> > >>> > >>> I think this case only register LED device, not LED "MC" device. > >>> Because our FLASH is not a multicolor device. > >> > >> No, here I was describing following setup: > >> > >> - DT FLED node is present, CONFIG_LEDS_CLASS_FLASH is off > >> - DT MC node is present, CONFIG_LEDS_CLASS_MULTICOLOR is on > >> > >> ML LED presence in DT is irrelevant in this case. > >> It should be always registered if there is corresponding DT node > >> and LEDS_CLASS is on. > >> > > > > As a long time discussion, we conclude some rules about MT6360 LED driv= er. > > FLED is necessary, so Kconfig depends on LED_CLASS_FLASH > > Maybe it is necessary in your use case, but probably it is possible to > use the device without FLED. If so, then you should allow users > disabling it. Therefore you should have: > > depends on LEDS_CLASS_FLASH || !LEDS_CLASS_FLASH > ACK > > ML LED is optional, which is registered as led class device. > > RGB LED can be either simple led class device or multicolor device, > > which is decided in DT node > > If Multicolor LED DT node is exist, it should be register multicolor > > device success. > > But only if CONFIG_LEDS_CLASS_MULTICOLOR is enabled. > > > Maybe it is more specific to send a new patch? > > > > Sample DT as below > > LED "red" is simple led class device, LED "green&blue" is multicolor de= vices. > > led@0 { > > reg =3D <0>; > > function =3D LED_FUNCTION_INDICATOR; > > color =3D ; > > led-max-microamp =3D <24000>; > > }; > > led@6 { > > reg =3D <6>; > > function =3D LED_FUNCTION_INDICATOR; > > color =3D ; > > > > led@1 { > > reg =3D <1>; > > function =3D LED_FUNCTION_INDICATOR; > > color =3D ; > > led-max-microamp =3D <24000>; > > }; > > led@2 { > > reg =3D <2>; > > function =3D LED_FUNCTION_INDICATOR; > > color =3D ; > > led-max-microamp =3D <24000>; > > }; > > }; > > It looks OK. > > >>>> Possible should be also the case when both LEDS_CLASS_FLASH > >>>> and LEDS_CLASS_MULTICOLOR are off. Then only LED class device > >>>> for ML LED will be registered (provided there is ML DT node). > >>>> But to make it possible you should have also "depends on LEDS_CLASS" > >>>> in the Kconfig entry. > >>>> > >>> > >>> According to your suggestion, > >>> depends on LED_CLASS && LEDS_CLASS_FLASH && OF > >> > >> s/LED_CLASS/LEDS_CLASS/ > >> > >> And you have to remove LEDS_CLASS_FLASH from above line. > >> > >>> depends on LEDS_CLASS_MULTICOLOR || !!LEDS_CLASS_MULTICOLOR > >> > >> s/!!LEDS_CLASS_MULTICOLOR/!LEDS_CLASS_MULTICOLOR/ > >> > >>> depends on LEDS_CLASS_FLASH || !LEDS_CLASS_FLASH > >>> depends on MFD_MT6360 > >> > >> You will need V4L2_FLASH_LED_CLASS dependency as well, to avoid > >> build break, when it is set to 'm'. > >> > >> To recap, following block of dependencies is required: > >> > >> depends on LEDS_CLASS && OF > >> depends on LEDS_CLASS_MULTICOLOR || !LEDS_CLASS_MULTICOLOR > >> depends on LEDS_CLASS_FLASH || !LEDS_CLASS_FLASH > >> depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS > >> depends on MFD_MT6360 > >> > > > > LEDS_MT6360 depends on LEDS_CLASS_FLASH, and LEDS_CLASS_FLASH depends > > on LEDS_CLASS > > Is "depends on LEDS_CLASS" still needed? > > Yes, because you should allow disabling CONFIG_LEDS_CLASS_FLASH. > In such a case driver should still compile and register ML LED class > device when it has corresponding DT node. > ACK > >>> and source code add constraint > >>> > >>> #if IS_ENABLED(CONFIG_LEDS_CLASS_MULTICOLOR) > >>> ret =3D devm_led_classdev_multicolor_register_ext(parent, &led-= >rgb, > >>> init_data); > >>> #endif > >>> > >>> #if IS_ENABLED(CONFIG_LEDS_CLASS_FLASH) > >>> ret =3D devm_led_classdev_flash_register_ext(parent, &led->flas= h, init_data); > >>> #endif > >> > >> No, the guards should be in headers. That's why I recommended adding > >> no ops for LED flash class registration functions in previous email. > >> > >> Please compare include/linux/led-class-multicolor.h and do similar > >> changes in include/linux/led-class-flash.h. > >> > > > > ACK, I will submit a fixed patch about leds-class-flash.h. > > > > By the way, if CONFIG_LED_CLASS_MULTICOLOR is not enabled and we don't > > use #if IS_ENABLED, > > according to led-class-multicolor.h return -EINVAL, > > we will register multicolor device fail and cause probe fail. > > Good point. So led-class-multicolor.h no-ops need to be fixed to return > 0 instead of -EINVAL. > > And no-ops in include/linux/led-class-flash.h should also return 0. DT node is first priority to decide how leds work. If RGB LED use multicolor form in DT, CONFIG_LEDS_CLASS_FLASH should be def= ined. Otherwise It is right action to probe fail. > > -- > Best regards, > Jacek Anaszewski