From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7FBAC47095 for ; Fri, 2 Oct 2020 23:15:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A910921707 for ; Fri, 2 Oct 2020 23:15:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="FKIIGNm4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725774AbgJBXPF (ORCPT ); Fri, 2 Oct 2020 19:15:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725446AbgJBXPE (ORCPT ); Fri, 2 Oct 2020 19:15:04 -0400 Received: from mail-lf1-x141.google.com (mail-lf1-x141.google.com [IPv6:2a00:1450:4864:20::141]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C3AB3C0613E3 for ; Fri, 2 Oct 2020 16:15:03 -0700 (PDT) Received: by mail-lf1-x141.google.com with SMTP id q8so3807909lfb.6 for ; Fri, 02 Oct 2020 16:15:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=X7v0IguEkfr1cOBmK+SE8+7CIjedoZmEtVTfp5z8yVo=; b=FKIIGNm4cuXzs5quW9CEsjwrBj/6hqBDlLAbYlhfvbbn90YZfqbXxeZnjcqGYHc2+P DmWhmHUaOnPKYLk5zeuEaxW74SuTqmoumQLo54K2124c58ju5tkmCzv5A856Ncmtf2pu 89vVhrcPGWaAoE7eOd9ckQ+014uVKwEoEbb54= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=X7v0IguEkfr1cOBmK+SE8+7CIjedoZmEtVTfp5z8yVo=; b=F0ubbJaaOrhZl/bV5HSV3W9Wap+fofRlB7nGqtkygqDtwedTiiAMn5mdYEfH8z9B57 hrgywBPZJBd30+xrkBI82Z8TTlllJ80EJwr1SMmPdoWBnYkj9rQT5o712djAefBKBJni O3bYcqnPOW57RsFwFwBSrplyjenK6vMOILW3+F5ipA53d+o0SzhBI9VM0sSDlM8hkJlS XWSyO3MU/cXFt+VDlYJbTLEJ3W6VfyD6Ia1eocbvRMpdDmnhxoEf30OSK7OXq4seHeIX QizudLkp7btwbYXSuSjsk8eaOAhf6minhsmJlG56xwb7adWm5mPq+BneVveqGexvmlSP 36KQ== X-Gm-Message-State: AOAM533R3F4ECjwMI0oqZVN6bt/EBBkworrdqlNAqtfIfqJ4g8VUwmnE Iye46JV6oidwgrDXJuk00SsASYL+f+JXSw== X-Google-Smtp-Source: ABdhPJxPIZrbndMONQJ8CYJceNGmuOOgDhwkEboDsb3JBLPtrkAFt/RzP9I2yBx8DyvzoUh1FmA2Vg== X-Received: by 2002:ac2:4833:: with SMTP id 19mr1480922lft.404.1601680501506; Fri, 02 Oct 2020 16:15:01 -0700 (PDT) Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com. [209.85.208.172]) by smtp.gmail.com with ESMTPSA id z20sm639780ljm.41.2020.10.02.16.15.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Oct 2020 16:15:00 -0700 (PDT) Received: by mail-lj1-f172.google.com with SMTP id k25so2502776ljk.0 for ; Fri, 02 Oct 2020 16:15:00 -0700 (PDT) X-Received: by 2002:a2e:b4fc:: with SMTP id s28mr1247909ljm.305.1601680500013; Fri, 02 Oct 2020 16:15:00 -0700 (PDT) MIME-Version: 1.0 References: <20200929205807.2360405-1-evgreen@chromium.org> <20200929135741.1.I8b447ca96abfbef5f298d77350e6c9d1d18d00f6@changeid> In-Reply-To: From: Evan Green Date: Fri, 2 Oct 2020 16:14:23 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] dt-bindings: nvmem: Add qcom,sc7180-qfprom compatible string To: Doug Anderson Cc: Rob Herring , Bjorn Andersson , Srinivas Kandagatla , Stephen Boyd , Andy Gross , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-msm , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Oct 2, 2020 at 3:20 PM Doug Anderson wrote: > > Hi, > > On Tue, Sep 29, 2020 at 1:58 PM Evan Green wrote: > > > > Add an SoC-specific compatible string so that data can be attached > > to it in the driver. > > > > Signed-off-by: Evan Green > > --- > > > > Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > > index 59aca6d22ff9b..b16c8e6a8c23d 100644 > > --- a/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > > +++ b/Documentation/devicetree/bindings/nvmem/qcom,qfprom.yaml > > @@ -14,7 +14,9 @@ allOf: > > > > properties: > > compatible: > > - const: qcom,qfprom > > + enum: > > + - qcom,qfprom > > + - qcom,sc7180-qfprom > > You don't want either/or. You want both. At the time Srinivas didn't > see the point of having the SoC-specific compatible string here, but > now that we have a reason for it maybe he'll be convinced? IMO you > essentially want: > > items: > - enum: > - qcom,apq8064-qfprom > - qcom,apq8084-qfprom > - qcom,msm8974-qfprom > - qcom,msm8916-qfprom > - qcom,msm8996-qfprom > - qcom,msm8998-qfprom > - qcom,qcs404-qfprom > - qcom,sc7180-qfprom > - qcom,sdm845-qfprom > - const: qcom,qfprom > > For some context: > That makes sense, thanks Doug. Srini, do you want me to go fix up all the various device trees to add the soc-compatible string, or just sc7180? (Also, don't forget about my other question about whether you still want the keepout stuff in the core at the cost of added complexity). -Evan > > -Doug > > > > > > reg: > > # If the QFPROM is read-only OS image then only the corrected region > > -- > > 2.26.2 > >