From: Greentime Hu <green.hu@gmail.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>,
Greentime <greentime@andestech.com>
Cc: Rick Chen <rickchen36@gmail.com>, Rick Chen <rick@andestech.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Linus Walleij <linus.walleij@linaro.org>,
linux-arch <linux-arch@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <marc.zyngier@arm.com>,
Rob Herring <robh+dt@kernel.org>, netdev <netdev@vger.kernel.org>,
Vincent Chen <deanbo422@gmail.com>,
DTML <devicetree@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
David Howells <dhowells@redhat.com>,
Will Deacon <will.deacon@arm.com>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH v5 1/3] clocksource/drivers/atcpit100: Add andestech atcpit100 timer
Date: Wed, 13 Dec 2017 14:06:07 +0800 [thread overview]
Message-ID: <CAEbi=3cEEtLQRiv-cyUwEmcBNOC2Sz7AhzZkpznQWYb9VUojug@mail.gmail.com> (raw)
In-Reply-To: <bb7383ba-bb8e-3cbd-4ce0-faaefa8ed114@linaro.org>
Hi, Daniel:
2017-12-12 18:05 GMT+08:00 Daniel Lezcano <daniel.lezcano@linaro.org>:
> On 12/12/2017 06:46, Rick Chen wrote:
>> ATCPIT100 is often used on the Andes architecture,
>> This timer provide 4 PIT channels. Each PIT channel is a
>> multi-function timer, can be configured as 32,16,8 bit timers
>> or PWM as well.
>>
>> For system timer it will set channel 1 32-bit timer0 as clock
>> source and count downwards until underflow and restart again.
>
> [ ... ]
>
>> +config CLKSRC_ATCPIT100
>> + bool "Clocksource for AE3XX platform"
>> + depends on NDS32 || COMPILE_TEST
>> + depends on HAS_IOMEM
>> + help
>> + This option enables support for the Andestech AE3XX platform timers.
>
> Hi Rick,
>
> the general rule for the Kconfig is:
>
> bool "Clocksource for AE3XX platform" if COMPILE_TEST
>
> and no deps on the platform.
>
> It is up to the platform Kconfig to select the option.
>
> We want here a silent option but make it selectable in case of
> compilation test coverage.
The way we like to use it is because
1. This timer is a basic component to boot an nds32 CPU and it should
be able to select without COMPILE_TEST for nds32 architecture.
2. It seems conflict with debug info. I am not sure if there is
another way to debug kernel(with debug info) with COMPILE_TEST and
DEBUG_INFO because we need this driver for nds32 architecture.
Symbol: DEBUG_INFO [=n]
Type : boolean
Prompt: Compile the kernel with debug info
Location:
-> Kernel hacking
-> Compile-time checks and compiler options
Defined at lib/Kconfig.debug:140
Depends on: DEBUG_KERNEL [=y] && !COMPILE_TEST [=n]
> Also, this driver is not a CLKSRC but a TIMER. Rename CLKSRC_ATCPIT100
> to TIMER_ATCPIT100.
Thanks. We will rename it in the next version patch.
>> +
>> endmenu
>> diff --git a/drivers/clocksource/Makefile b/drivers/clocksource/Makefile
>> index 72711f1..7d072f5 100644
>> --- a/drivers/clocksource/Makefile
>> +++ b/drivers/clocksource/Makefile
>> @@ -75,3 +75,4 @@ obj-$(CONFIG_H8300_TMR16) += h8300_timer16.o
>> obj-$(CONFIG_H8300_TPU) += h8300_tpu.o
>> obj-$(CONFIG_CLKSRC_ST_LPC) += clksrc_st_lpc.o
>> obj-$(CONFIG_X86_NUMACHIP) += numachip.o
>> +obj-$(CONFIG_CLKSRC_ATCPIT100) += timer-atcpit100.o
>
> [ ... ]
>
>> +static struct timer_of to = {
>> + .flags = TIMER_OF_IRQ | TIMER_OF_CLOCK | TIMER_OF_BASE,
>> +
>> + .clkevt = {
>> + .name = "atcpit100_tick",
>> + .rating = 300,
>> + .features = CLOCK_EVT_FEAT_PERIODIC | CLOCK_EVT_FEAT_ONESHOT,
>> + .set_state_shutdown = atcpit100_clkevt_shutdown,
>> + .set_state_periodic = atcpit100_clkevt_set_periodic,
>> + .set_state_oneshot = atcpit100_clkevt_set_oneshot,
>> + .tick_resume = atcpit100_clkevt_shutdown,
>> + .set_next_event = atcpit100_clkevt_next_event,
>> + .cpumask = cpu_all_mask,
>
> You may consider CLOCK_EVT_DYN_IRQ
> https://lwn.net/Articles/540160/
Thanks.
We will consider to implement this feature once we support SMP or our
CPU has local timer.
>> + },
>> +
>> + .of_irq = {
>> + .handler = atcpit100_timer_interrupt,
>> + .flags = IRQF_TIMER | IRQF_IRQPOLL,
>> + },
>> +
>> + /*
>> + * FIXME: we currently only support clocking using PCLK
>> + * and using EXTCLK is not supported in the driver.
>> + */
>> + .of_clk = {
>> + .name = "PCLK",
>> + }
>
> What do you mean ? We can't specify several clock names with timer-of?
It means we currently support PCLK only.
https://lkml.org/lkml/2017/12/1/316
Thanks.
next prev parent reply other threads:[~2017-12-13 6:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-12 5:46 [PATCH v5 0/3] Add andestech atcpit100 timer Rick Chen
2017-12-12 5:46 ` [PATCH v5 1/3] clocksource/drivers/atcpit100: " Rick Chen
2017-12-12 10:05 ` Daniel Lezcano
2017-12-13 6:06 ` Greentime Hu [this message]
2018-01-04 13:50 ` Daniel Lezcano
2018-01-04 14:06 ` Greentime Hu
2018-01-04 19:48 ` Daniel Lezcano
2018-01-05 8:45 ` Greentime Hu
2018-01-05 9:31 ` Daniel Lezcano
2018-01-08 15:26 ` Arnd Bergmann
2018-01-08 16:08 ` Daniel Lezcano
2018-01-08 16:30 ` Arnd Bergmann
2017-12-12 5:47 ` [PATCH v5 2/3] clocksource/drivers/atcpit100: VDSO support Rick Chen
2017-12-12 5:47 ` [PATCH v5 3/3] dt-bindings: timer: Add andestech atcpit100 timer binding doc Rick Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEbi=3cEEtLQRiv-cyUwEmcBNOC2Sz7AhzZkpznQWYb9VUojug@mail.gmail.com' \
--to=green.hu@gmail.com \
--cc=arnd@arndb.de \
--cc=daniel.lezcano@linaro.org \
--cc=deanbo422@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dhowells@redhat.com \
--cc=greentime@andestech.com \
--cc=jason@lakedaemon.net \
--cc=linus.walleij@linaro.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=netdev@vger.kernel.org \
--cc=rick@andestech.com \
--cc=rickchen36@gmail.com \
--cc=robh+dt@kernel.org \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).