From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org,
linux-mmc@vger.kernel.org, ulf.hansson@linaro.org,
jianxin.pan@amlogic.com, mark.rutland@arm.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, lnykww@gmail.com,
yinxin_1989@aliyun.com
Subject: Re: [PATCH v4 1/3] dt-bindings: mmc: Document the Amlogic Meson SDHC MMC host controller
Date: Tue, 14 Jan 2020 21:12:09 +0100 [thread overview]
Message-ID: <CAFBinCAA1kGFqDbYXYVn9W9DRhOnk09WpjGqP5R9YTwu_5vSCw@mail.gmail.com> (raw)
In-Reply-To: <20200113211020.GA12476@bogus>
Hi Rob,
On Mon, Jan 13, 2020 at 10:10 PM Rob Herring <robh@kernel.org> wrote:
>
> On Sun, Jan 12, 2020 at 01:24:57AM +0100, Martin Blumenstingl wrote:
> > This documents the devicetree bindings for the SDHC MMC host controller
> > found in Meson6, Meson8, Meson8b and Meson8m2 SoCs. It can use a
> > bus-width of 1/4/8-bit and it supports eMMC spec 4.4x/4.5x including
> > HS200 mode (up to 100MHz clock). It embeds an internal clock controller
> > which outputs four clocks (mod_clk, sd_clk, tx_clk and rx_clk) and is
> > fed by four external input clocks (clkin[0-3]). "pclk" is the module
> > register clock, it has to be enabled to access the registers.
> >
> > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
> > ---
> > .../bindings/mmc/amlogic,meson-mx-sdhc.yaml | 83 +++++++++++++++++++
> > .../dt-bindings/clock/meson-mx-sdhc-clkc.h | 8 ++
> > 2 files changed, 91 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/mmc/amlogic,meson-mx-sdhc.yaml
> > create mode 100644 include/dt-bindings/clock/meson-mx-sdhc-clkc.h
>
> Fails 'make dt_binding_check':
>
> Documentation/devicetree/bindings/mmc/amlogic,meson-mx-sdhc.example.dts:17:53:
> warning: extra tokens at end of #include directive
> #include <dt-bindings/clock/meson-mx-sdhc-clkc.yaml>;
> ^
> Documentation/devicetree/bindings/mmc/amlogic,meson-mx-sdhc.example.dts:17:10:
> fatal error: dt-bindings/clock/meson-mx-sdhc-clkc.yaml: No such file or directory
> #include <dt-bindings/clock/meson-mx-sdhc-clkc.yaml>;
> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
sorry for that - I'll fix it in v5
[...]
> > + clock-names:
> > + items:
> > + - const: pclk
> > + - const: mod_clk
> > + - const: sd_clk
> > + - const: rx_clk
> > + - const: tx_clk
> > + - const: clkin0
> > + - const: clkin1
> > + - const: clkin2
> > + - const: clkin3
>
> Kind of odd to put the output clocks in the middle of the list.
I'll have to re-send this anyways so I'll put clkin[0-3] at the start
of the list
Martin
next prev parent reply other threads:[~2020-01-14 20:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-12 0:24 [PATCH v4 0/3] Amlogic 32-bit Meson SoC SDHC MMC controller driver Martin Blumenstingl
2020-01-12 0:24 ` [PATCH v4 1/3] dt-bindings: mmc: Document the Amlogic Meson SDHC MMC host controller Martin Blumenstingl
2020-01-13 21:10 ` Rob Herring
2020-01-14 20:12 ` Martin Blumenstingl [this message]
2020-01-12 0:24 ` [PATCH v4 2/3] clk: meson: add a driver for the Meson8/8b/8m2 SDHC clock controller Martin Blumenstingl
2020-01-12 0:24 ` [PATCH v4 3/3] mmc: host: meson-mx-sdhc: new driver for the Amlogic Meson SDHC host Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFBinCAA1kGFqDbYXYVn9W9DRhOnk09WpjGqP5R9YTwu_5vSCw@mail.gmail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=devicetree@vger.kernel.org \
--cc=jianxin.pan@amlogic.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=lnykww@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=yinxin_1989@aliyun.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).