From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Anand Moon <linux.amoon@gmail.com>
Cc: linux-phy@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Matt Corallo <oc2udbzfd@mattcorallo.com>,
Rob Herring <robh+dt@kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Vinod Koul <vkoul@kernel.org>,
Emiliano Ingrassia <ingrassia@epigenesys.com>,
Brian Kim <brian.kim@hardkernel.com>
Subject: Re: [PATCHv3 1/6] ARM: dts: meson8b: odroidc1: Add usb phy power node
Date: Sat, 28 Aug 2021 17:53:54 +0200 [thread overview]
Message-ID: <CAFBinCBnH1UqaiuHgTXZTH+RPOwCWiWLVheU=bydS4mfkxTP3g@mail.gmail.com> (raw)
In-Reply-To: <20210817041548.1276-2-linux.amoon@gmail.com>
Hi Anand,
sorry for the late reply
I have three very small comments below, apart from these, this is looking good!
On Tue, Aug 17, 2021 at 6:17 AM Anand Moon <linux.amoon@gmail.com> wrote:
>
> Add missing usb phy power node for usb node fix below warning.
> P5V0 regulator supply input voltage range to USB host controller.
> As described in the C1+ schematics, GPIO GPIOAO_5 is used to
> enable input power to USB ports, set it to Active Low.
I would phrase this last sentence as:
"enable USB VBUS on the Micro-USB port using an active high signal"
My idea here is to 1) clarify that it's about enabling USB VBUS only
on the Micro-USB port and 2) use "active high" like the changes inside
the patch itself
> [ 1.260772] dwc2 c90c0000.usb: Looking up vbus-supply from device tree
> [ 1.260784] dwc2 c90c0000.usb: Looking up vbus-supply property in
> mode /soc/usb@c90c0000 failed
>
> Fixes: 2eb79a4d15ff (ARM: dts: meson: enabling the USB Host
> controller on Odroid-C1/C1+ board)
>
please drop this empty line
[...]
> @@ -119,7 +136,6 @@ vcc_3v3: regulator-vcc-3v3 {
> regulator-name = "VCC3V3";
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
> -
I don't think that we should make any VCC3V3 regulator changes in this patch
so please keep this empty line as-is.
Best regards,
Martin
next prev parent reply other threads:[~2021-08-28 15:54 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-17 4:15 [PATCHv3 0/6] Meson-8b and Meson-gxbb Fix some missing code Anand Moon
2021-08-17 4:15 ` [PATCHv3 1/6] ARM: dts: meson8b: odroidc1: Add usb phy power node Anand Moon
2021-08-28 15:53 ` Martin Blumenstingl [this message]
2021-08-30 7:45 ` Neil Armstrong
2021-08-30 19:37 ` Martin Blumenstingl
2021-08-31 14:50 ` Neil Armstrong
2021-08-31 20:47 ` Anand Moon
2021-09-20 19:26 ` Martin Blumenstingl
2021-09-25 17:41 ` Anand Moon
2021-08-17 4:15 ` [PATCHv3 2/6] ARM: dts: meson8b: odroidc1: Set usb power source to always on Anand Moon
2021-08-28 15:56 ` Martin Blumenstingl
2021-08-17 4:15 ` [PATCHv3 3/6] arm64: dts: amlogic: odroidc2: Fix the chip enable signal for usb power Anand Moon
2021-08-28 16:00 ` Martin Blumenstingl
2021-08-17 4:15 ` [PATCHv3 4/6] arm64: dts: amlogic: odroidc2: use vbus-supply for power source for usb nodes Anand Moon
2021-08-28 16:06 ` Martin Blumenstingl
2021-08-17 4:15 ` [PATCHv3 5/6] phy: amlogic: meson8b-usb2: Power off the PHY by putting it into reset mode Anand Moon
2021-08-17 10:30 ` Vinod Koul
2021-08-17 4:15 ` [PATCHv3 6/6] phy: amlogic: meson8b-usb2: don't log an error on -EPROBE_DEFER Anand Moon
2021-08-17 10:31 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFBinCBnH1UqaiuHgTXZTH+RPOwCWiWLVheU=bydS4mfkxTP3g@mail.gmail.com' \
--to=martin.blumenstingl@googlemail.com \
--cc=brian.kim@hardkernel.com \
--cc=devicetree@vger.kernel.org \
--cc=ingrassia@epigenesys.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=kishon@ti.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux.amoon@gmail.com \
--cc=narmstrong@baylibre.com \
--cc=oc2udbzfd@mattcorallo.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).