From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Dodge Subject: Re: [PATCH 2/2] backlight: arcxcnn: add "arctic" vendor prefix Date: Mon, 8 Jul 2019 15:05:14 -0400 Message-ID: References: <1561940895-15837-1-git-send-email-bdodge09@gmail.com> <1561940895-15837-3-git-send-email-bdodge09@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0372464003==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Murphy Cc: devicetree@vger.kernel.org, Daniel Thompson , jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, robh+dt@kernel.org, jacek.anaszewski@gmail.com, Pavel Machek , pbacon@psemi.com, lee.jones@linaro.org, linux-leds@vger.kernel.org List-Id: devicetree@vger.kernel.org --===============0372464003== Content-Type: multipart/alternative; boundary="0000000000007e1664058d302010" --0000000000007e1664058d302010 Content-Type: text/plain; charset="UTF-8" Thanks. pSemi purchased ArcticSand a few years ago so they are the same legal entity. I will ask them if they want to retain the original copyright notice On Mon, Jul 8, 2019, 2:05 PM Dan Murphy wrote: > Brian > > On 6/30/19 7:28 PM, Brian Dodge wrote: > > The original patch adding this driver and DT bindings improperly > > used "arc" as the vendor-prefix. This adds "arctic" which is the > > proper prefix and retains "arc" to allow existing users of the > > "arc" prefix to update to new kernels. There is at least one > > (Samsung Chromebook Plus) > > > > Signed-off-by: Brian Dodge > > Acked-by: Daniel Thompson > > --- > > drivers/video/backlight/arcxcnn_bl.c | 41 > +++++++++++++++++++++++++++--------- > > 1 file changed, 31 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/video/backlight/arcxcnn_bl.c > b/drivers/video/backlight/arcxcnn_bl.c > > index 7b1c0a0..a419554 100644 > > --- a/drivers/video/backlight/arcxcnn_bl.c > > +++ b/drivers/video/backlight/arcxcnn_bl.c > > @@ -1,9 +1,9 @@ > > // SPDX-License-Identifier: GPL-2.0-only > > /* > > - * Backlight driver for ArcticSand ARC_X_C_0N_0N Devices > > + * Backlight driver for pSemi (formerly ArcticSand) ARC_X_C_0N_0N > Devices > > * > > - * Copyright 2016 ArcticSand, Inc. > > - * Author : Brian Dodge > > I know you are the original author from ArcticSand but did pSemi > actually own the copyright in 2016? > > I don't think this is a big issue just wondering if we should retain the > ArcticSand copyright as well. > > Probably a question for your legal department. > > Otherwise > > Reviewed-by: Dan Murphy > > > + * Copyright 2016-2019 pSemi, Inc. > > + * Author : Brian Dodge > > */ > > > > #include > > @@ -191,27 +191,46 @@ static void arcxcnn_parse_dt(struct arcxcnn *lp) > > if (ret == 0) > > lp->pdata->initial_brightness = prog_val; > > > > - ret = of_property_read_u32(node, "arc,led-config-0", &prog_val); > > + ret = of_property_read_u32(node, "arctic,led-config-0", &prog_val); > > + if (ret) > > + ret = of_property_read_u32(node, "arc,led-config-0", > &prog_val); > > + > > if (ret == 0) > > lp->pdata->led_config_0 = (u8)prog_val; > > > > - ret = of_property_read_u32(node, "arc,led-config-1", &prog_val); > > + ret = of_property_read_u32(node, "arctic,led-config-1", &prog_val); > > + if (ret) > > + ret = of_property_read_u32(node, "arc,led-config-1", > &prog_val); > > + > > if (ret == 0) > > lp->pdata->led_config_1 = (u8)prog_val; > > > > - ret = of_property_read_u32(node, "arc,dim-freq", &prog_val); > > + ret = of_property_read_u32(node, "arctic,dim-freq", &prog_val); > > + if (ret) > > + ret = of_property_read_u32(node, "arc,dim-freq", > &prog_val); > > + > > if (ret == 0) > > lp->pdata->dim_freq = (u8)prog_val; > > > > - ret = of_property_read_u32(node, "arc,comp-config", &prog_val); > > + ret = of_property_read_u32(node, "arctic,comp-config", &prog_val); > > + if (ret) > > + ret = of_property_read_u32(node, "arc,comp-config", > &prog_val); > > + > > if (ret == 0) > > lp->pdata->comp_config = (u8)prog_val; > > > > - ret = of_property_read_u32(node, "arc,filter-config", &prog_val); > > + ret = of_property_read_u32(node, "arctic,filter-config", > &prog_val); > > + if (ret) > > + ret = of_property_read_u32(node, > > + "arc,filter-config", &prog_val); > > + > > if (ret == 0) > > lp->pdata->filter_config = (u8)prog_val; > > > > - ret = of_property_read_u32(node, "arc,trim-config", &prog_val); > > + ret = of_property_read_u32(node, "arctic,trim-config", &prog_val); > > + if (ret) > > + ret = of_property_read_u32(node, "arc,trim-config", > &prog_val); > > + > > if (ret == 0) > > lp->pdata->trim_config = (u8)prog_val; > > > > @@ -381,6 +400,8 @@ static int arcxcnn_remove(struct i2c_client *cl) > > } > > > > static const struct of_device_id arcxcnn_dt_ids[] = { > > + { .compatible = "arctic,arc2c0608" }, > > + /* here to remain compatible with an older binding, do not use */ > > { .compatible = "arc,arc2c0608" }, > > { } > > }; > > @@ -404,5 +425,5 @@ static struct i2c_driver arcxcnn_driver = { > > module_i2c_driver(arcxcnn_driver); > > > > MODULE_LICENSE("GPL v2"); > > -MODULE_AUTHOR("Brian Dodge "); > > +MODULE_AUTHOR("Brian Dodge "); > > MODULE_DESCRIPTION("ARCXCNN Backlight driver"); > --0000000000007e1664058d302010 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thanks. pSemi purchased ArcticSand a few=C2=A0years ago s= o they are the same legal entity. I will ask them if they want to retain th= e original copyright notice

On Mon, Jul 8, 2019, 2:05 PM Dan Murphy <dmurphy@ti.com> wrote:
Brian

On 6/30/19 7:28 PM, Brian Dodge wrote:
> The original patch adding this driver and DT bindings improperly
> used "arc" as the vendor-prefix. This adds "arctic"= ; which is the
> proper prefix and retains "arc" to allow existing users of t= he
> "arc" prefix to update to new kernels. There is at least one=
> (Samsung Chromebook Plus)
>
> Signed-off-by: Brian Dodge <bdodge09@gmail.com>
> Acked-by: Daniel Thompson <daniel.thompson@linaro.org&g= t;
> ---
>=C2=A0 =C2=A0drivers/video/backlight/arcxcnn_bl.c | 41 ++++++++++++++++= +++++++++++---------
>=C2=A0 =C2=A01 file changed, 31 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/video/backlight/arcxcnn_bl.c b/drivers/video/back= light/arcxcnn_bl.c
> index 7b1c0a0..a419554 100644
> --- a/drivers/video/backlight/arcxcnn_bl.c
> +++ b/drivers/video/backlight/arcxcnn_bl.c
> @@ -1,9 +1,9 @@
>=C2=A0 =C2=A0// SPDX-License-Identifier: GPL-2.0-only
>=C2=A0 =C2=A0/*
> - * Backlight driver for ArcticSand ARC_X_C_0N_0N Devices
> + * Backlight driver for pSemi (formerly ArcticSand) ARC_X_C_0N_0N Dev= ices
>=C2=A0 =C2=A0 *
> - * Copyright 2016 ArcticSand, Inc.
> - * Author : Brian Dodge <bdodge@arcticsand.com>

I know you are the original author from ArcticSand but did pSemi
actually own the copyright in 2016?

I don't think this is a big issue just wondering if we should retain th= e
ArcticSand copyright as well.

Probably a question for your legal department.

Otherwise

Reviewed-by: Dan Murphy <dmurphy@ti.com>

> + * Copyright 2016-2019=C2=A0 pSemi, Inc.
> + * Author : Brian Dodge <bdodge@psemi.com>
>=C2=A0 =C2=A0 */
>=C2=A0 =C2=A0
>=C2=A0 =C2=A0#include <linux/backlight.h>
> @@ -191,27 +191,46 @@ static void arcxcnn_parse_dt(struct arcxcnn *lp)=
>=C2=A0 =C2=A0 =C2=A0 =C2=A0if (ret =3D=3D 0)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0lp->pdata->= ;initial_brightness =3D prog_val;
>=C2=A0 =C2=A0
> -=C2=A0 =C2=A0 =C2=A0ret =3D of_property_read_u32(node, "arc,led-= config-0", &prog_val);
> +=C2=A0 =C2=A0 =C2=A0ret =3D of_property_read_u32(node, "arctic,l= ed-config-0", &prog_val);
> +=C2=A0 =C2=A0 =C2=A0if (ret)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ret =3D of_property_r= ead_u32(node, "arc,led-config-0", &prog_val);
> +
>=C2=A0 =C2=A0 =C2=A0 =C2=A0if (ret =3D=3D 0)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0lp->pdata->= ;led_config_0 =3D (u8)prog_val;
>=C2=A0 =C2=A0
> -=C2=A0 =C2=A0 =C2=A0ret =3D of_property_read_u32(node, "arc,led-= config-1", &prog_val);
> +=C2=A0 =C2=A0 =C2=A0ret =3D of_property_read_u32(node, "arctic,l= ed-config-1", &prog_val);
> +=C2=A0 =C2=A0 =C2=A0if (ret)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ret =3D of_property_r= ead_u32(node, "arc,led-config-1", &prog_val);
> +
>=C2=A0 =C2=A0 =C2=A0 =C2=A0if (ret =3D=3D 0)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0lp->pdata->= ;led_config_1 =3D (u8)prog_val;
>=C2=A0 =C2=A0
> -=C2=A0 =C2=A0 =C2=A0ret =3D of_property_read_u32(node, "arc,dim-= freq", &prog_val);
> +=C2=A0 =C2=A0 =C2=A0ret =3D of_property_read_u32(node, "arctic,d= im-freq", &prog_val);
> +=C2=A0 =C2=A0 =C2=A0if (ret)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ret =3D of_property_r= ead_u32(node, "arc,dim-freq", &prog_val);
> +
>=C2=A0 =C2=A0 =C2=A0 =C2=A0if (ret =3D=3D 0)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0lp->pdata->= ;dim_freq =3D (u8)prog_val;
>=C2=A0 =C2=A0
> -=C2=A0 =C2=A0 =C2=A0ret =3D of_property_read_u32(node, "arc,comp= -config", &prog_val);
> +=C2=A0 =C2=A0 =C2=A0ret =3D of_property_read_u32(node, "arctic,c= omp-config", &prog_val);
> +=C2=A0 =C2=A0 =C2=A0if (ret)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ret =3D of_property_r= ead_u32(node, "arc,comp-config", &prog_val);
> +
>=C2=A0 =C2=A0 =C2=A0 =C2=A0if (ret =3D=3D 0)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0lp->pdata->= ;comp_config =3D (u8)prog_val;
>=C2=A0 =C2=A0
> -=C2=A0 =C2=A0 =C2=A0ret =3D of_property_read_u32(node, "arc,filt= er-config", &prog_val);
> +=C2=A0 =C2=A0 =C2=A0ret =3D of_property_read_u32(node, "arctic,f= ilter-config", &prog_val);
> +=C2=A0 =C2=A0 =C2=A0if (ret)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ret =3D of_property_r= ead_u32(node,
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0"arc,filter-config", &prog= _val);
> +
>=C2=A0 =C2=A0 =C2=A0 =C2=A0if (ret =3D=3D 0)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0lp->pdata->= ;filter_config =3D (u8)prog_val;
>=C2=A0 =C2=A0
> -=C2=A0 =C2=A0 =C2=A0ret =3D of_property_read_u32(node, "arc,trim= -config", &prog_val);
> +=C2=A0 =C2=A0 =C2=A0ret =3D of_property_read_u32(node, "arctic,t= rim-config", &prog_val);
> +=C2=A0 =C2=A0 =C2=A0if (ret)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ret =3D of_property_r= ead_u32(node, "arc,trim-config", &prog_val);
> +
>=C2=A0 =C2=A0 =C2=A0 =C2=A0if (ret =3D=3D 0)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0lp->pdata->= ;trim_config =3D (u8)prog_val;
>=C2=A0 =C2=A0
> @@ -381,6 +400,8 @@ static int arcxcnn_remove(struct i2c_client *cl) >=C2=A0 =C2=A0}
>=C2=A0 =C2=A0
>=C2=A0 =C2=A0static const struct of_device_id arcxcnn_dt_ids[] =3D { > +=C2=A0 =C2=A0 =C2=A0{ .compatible =3D "arctic,arc2c0608" },=
> +=C2=A0 =C2=A0 =C2=A0/* here to remain compatible with an older bindin= g, do not use */
>=C2=A0 =C2=A0 =C2=A0 =C2=A0{ .compatible =3D "arc,arc2c0608" = },
>=C2=A0 =C2=A0 =C2=A0 =C2=A0{ }
>=C2=A0 =C2=A0};
> @@ -404,5 +425,5 @@ static struct i2c_driver arcxcnn_driver =3D {
>=C2=A0 =C2=A0module_i2c_driver(arcxcnn_driver);
>=C2=A0 =C2=A0
>=C2=A0 =C2=A0MODULE_LICENSE("GPL v2");
> -MODULE_AUTHOR("Brian Dodge <bdodge@arcticsand.com>&= quot;);
> +MODULE_AUTHOR("Brian Dodge <bdodge@psemi.com>"); >=C2=A0 =C2=A0MODULE_DESCRIPTION("ARCXCNN Backlight driver");<= br>
--0000000000007e1664058d302010-- --===============0372464003== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============0372464003==--