From mboxrd@z Thu Jan 1 00:00:00 1970 From: Brian Dodge Subject: Re: [PATCH 1/2] dt-bindings: backlight: fix vendor prefix for ArcticSand arcxcnn driver bindings Date: Tue, 25 Jun 2019 07:44:06 -0400 Message-ID: References: <1561435529-7835-1-git-send-email-bdodge09@gmail.com> <1561435529-7835-2-git-send-email-bdodge09@gmail.com> <20190625085534.xf2ullyju3ewbgik@holly.lan> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1829269519==" Return-path: In-Reply-To: <20190625085534.xf2ullyju3ewbgik@holly.lan> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Thompson Cc: devicetree@vger.kernel.org, jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, robh+dt@kernel.org, jacek.anaszewski@gmail.com, Pavel Machek , pbacon@psemi.com, lee.jones@linaro.org, linux-leds@vger.kernel.org List-Id: devicetree@vger.kernel.org --===============1829269519== Content-Type: multipart/alternative; boundary="000000000000edd2ce058c2472a9" --000000000000edd2ce058c2472a9 Content-Type: text/plain; charset="UTF-8" I would like to deprecate the old prefix in the future after communicating with all chip customers, which is why the old prefix is not documented in the new bindings. On Tue, Jun 25, 2019, 4:55 AM Daniel Thompson wrote: > On Tue, Jun 25, 2019 at 12:05:28AM -0400, Brian Dodge wrote: > > The vendor-prefixes.txt file properly refers to ArcticSand > > as arctic but the driver bindings improperly abbreviated the > > prefix to arc. This was a mistake in the original patch > > > > Signed-off-by: Brian Dodge > > --- > > .../bindings/leds/backlight/arcxcnn_bl.txt | 24 > +++++++++++++--------- > > 1 file changed, 14 insertions(+), 10 deletions(-) > > > > diff --git > a/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt > b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt > > index 230abde..9cf4c44 100644 > > --- a/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt > > +++ b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt > > @@ -1,8 +1,12 @@ > > -Binding for ArcticSand arc2c0608 LED driver > > +Binding for ArcticSand arc family LED drivers > > > > Required properties: > > -- compatible: should be "arc,arc2c0608" > > -- reg: slave address > > +- compatible: one of > > + "arctic,arc1c0608" > > + "arctic,arc2c0608" > > + "arctic,arc3c0845" > > This is more a question for the DT folks than for Brian but... > > AFAICT this patch is fixing the binding for the ArcticSand devices to > use the correct value from vendor-prefixes.yaml and has been previously > discussed here: > https://lkml.org/lkml/2018/9/25/726 > > Currently this patch series just updates the DT bindings but the > implementation also honours the old values (since there is a Chromebook > in the wild that uses the current bindings). > > Hence I'm not clear whether the bindings should document the deprecated > options too (e.g. make it easier to find the bindings doc with git grep > and friends). > > > Daniel. > > > > + > > +- reg: slave address > > > > Optional properties: > > - default-brightness: brightness value on boot, value from: > 0-4095 > > @@ -11,19 +15,19 @@ Optional properties: > > - led-sources: List of enabled channels from 0 to 5. > > See > Documentation/devicetree/bindings/leds/common.txt > > > > -- arc,led-config-0: setting for register ILED_CONFIG_0 > > -- arc,led-config-1: setting for register ILED_CONFIG_1 > > -- arc,dim-freq: PWM mode frequence setting (bits [3:0] > used) > > -- arc,comp-config: setting for register CONFIG_COMP > > -- arc,filter-config: setting for register FILTER_CONFIG > > -- arc,trim-config: setting for register IMAXTUNE > > +- arctic,led-config-0: setting for register ILED_CONFIG_0 > > +- arctic,led-config-1: setting for register ILED_CONFIG_1 > > +- arctic,dim-freq: PWM mode frequence setting (bits [3:0] > used) > > +- arctic,comp-config: setting for register CONFIG_COMP > > +- arctic,filter-config: setting for register FILTER_CONFIG > > +- arctic,trim-config: setting for register IMAXTUNE > > > > Note: Optional properties not specified will default to values in IC > EPROM > > > > Example: > > > > arc2c0608@30 { > > - compatible = "arc,arc2c0608"; > > + compatible = "arctic,arc2c0608"; > > reg = <0x30>; > > default-brightness = <500>; > > label = "lcd-backlight"; > > -- > > 2.7.4 > > > --000000000000edd2ce058c2472a9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I would like to deprecate the old prefix in the future af= ter communicating with all chip customers, which is why the old prefix is n= ot documented in the new bindings.


On Tue, Jun 2= 5, 2019, 4:55 AM Daniel Thompson <daniel.thompson@linaro.org= > wrote:
On Tue, Jun 25, 2019 at= 12:05:28AM -0400, Brian Dodge wrote:
>=C2=A0 =C2=A0 =C2=A0The vendor-prefixes.txt file properly refers to Arc= ticSand
>=C2=A0 =C2=A0 =C2=A0as arctic but the driver bindings improperly abbrev= iated the
>=C2=A0 =C2=A0 =C2=A0prefix to arc. This was a mistake in the original p= atch
>
> Signed-off-by: Brian Dodge <bdodge09@gmail.com> > ---
>=C2=A0 .../bindings/leds/backlight/arcxcnn_bl.txt=C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0| 24 +++++++++++++---------
>=C2=A0 1 file changed, 14 insertions(+), 10 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/arcxcnn_= bl.txt b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt > index 230abde..9cf4c44 100644
> --- a/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt<= br> > +++ b/Documentation/devicetree/bindings/leds/backlight/arcxcnn_bl.txt<= br> > @@ -1,8 +1,12 @@
> -Binding for ArcticSand arc2c0608 LED driver
> +Binding for ArcticSand arc family LED drivers
>=C2=A0
>=C2=A0 Required properties:
> -- compatible:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = should be "arc,arc2c0608"
> -- reg:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0slave address
> +- compatible: one of
> +=C2=A0 =C2=A0 =C2=A0"arctic,arc1c0608"
> +=C2=A0 =C2=A0 =C2=A0"arctic,arc2c0608"
> +=C2=A0 =C2=A0 =C2=A0"arctic,arc3c0845"

This is more a question for the DT folks than for Brian but...

AFAICT this patch is fixing the binding for the ArcticSand devices to
use the correct value from vendor-prefixes.yaml and has been previously
discussed here:
https://lkml.org/lkml/2018/9/25/726

Currently this patch series just updates the DT bindings but the
implementation also honours the old values (since there is a Chromebook
in the wild that uses the current bindings).

Hence I'm not clear whether the bindings should document the deprecated=
options too (e.g. make it easier to find the bindings doc with git grep
and friends).


Daniel.


> +
> +- reg:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0slave ad= dress
>=C2=A0
>=C2=A0 Optional properties:
>=C2=A0 - default-brightness:=C2=A0 =C2=A0 =C2=A0 =C2=A0 brightness valu= e on boot, value from: 0-4095
> @@ -11,19 +15,19 @@ Optional properties:
>=C2=A0 - led-sources:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0List of enabled channels from 0 to 5.
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0See Documentation/devicetree/bindings/leds/common.txt
>=C2=A0
> -- arc,led-config-0:=C2=A0 setting for register ILED_CONFIG_0
> -- arc,led-config-1:=C2=A0 setting for register ILED_CONFIG_1
> -- arc,dim-freq:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 PWM m= ode frequence setting (bits [3:0] used)
> -- arc,comp-config:=C2=A0 =C2=A0setting for register CONFIG_COMP
> -- arc,filter-config: setting for register FILTER_CONFIG
> -- arc,trim-config:=C2=A0 =C2=A0setting for register IMAXTUNE
> +- arctic,led-config-0:=C2=A0 =C2=A0 =C2=A0 =C2=A0setting for register= ILED_CONFIG_0
> +- arctic,led-config-1:=C2=A0 =C2=A0 =C2=A0 =C2=A0setting for register= ILED_CONFIG_1
> +- arctic,dim-freq:=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0PWM mode f= requence setting (bits [3:0] used)
> +- arctic,comp-config:=C2=A0 =C2=A0 =C2=A0 =C2=A0 setting for register= CONFIG_COMP
> +- arctic,filter-config:=C2=A0 =C2=A0 =C2=A0 setting for register FILT= ER_CONFIG
> +- arctic,trim-config:=C2=A0 =C2=A0 =C2=A0 =C2=A0 setting for register= IMAXTUNE
>=C2=A0
>=C2=A0 Note: Optional properties not specified will default to values i= n IC EPROM
>=C2=A0
>=C2=A0 Example:
>=C2=A0
>=C2=A0 arc2c0608@30 {
> -=C2=A0 =C2=A0 =C2=A0compatible =3D "arc,arc2c0608";
> +=C2=A0 =C2=A0 =C2=A0compatible =3D "arctic,arc2c0608";
>=C2=A0 =C2=A0 =C2=A0 =C2=A0reg =3D <0x30>;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0default-brightness =3D <500>;
>=C2=A0 =C2=A0 =C2=A0 =C2=A0label =3D "lcd-backlight";
> --
> 2.7.4
>
--000000000000edd2ce058c2472a9-- --===============1829269519== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============1829269519==--