From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: MIME-Version: 1.0 Sender: harinikatakamlinux@gmail.com In-Reply-To: References: <1564566033-676-1-git-send-email-harini.katakam@xilinx.com> <1564566033-676-2-git-send-email-harini.katakam@xilinx.com> <20190804145633.GB6800@lunn.ch> <20190805132045.GC24275@lunn.ch> From: Harini Katakam Date: Mon, 5 Aug 2019 21:40:58 +0530 Message-ID: Subject: [RFC PATCH 1/2] dt-bindings: net: macb: Add new property for PS SGMII only Content-Type: multipart/alternative; boundary="00000000000028ca29058f60f42c" To: Andrew Lunn Cc: Harini Katakam , Nicolas Ferre , David Miller , Claudiu Beznea , Rob Herring , Mark Rutland , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Michal Simek , "devicetree@vger.kernel.org" List-ID: --00000000000028ca29058f60f42c Content-Type: text/plain; charset="UTF-8" Hi Andrew, On Mon, Aug 5, 2019 at 8:06 PM Harini Katakam wrote: > > Hi Andrew, > > On Mon, Aug 5, 2019 at 7:00 PM Andrew Lunn wrote: > > > > On Mon, Aug 05, 2019 at 11:45:05AM +0530, Harini Katakam wrote: > > > Hi Andrew, > > > > > > On Sun, Aug 4, 2019 at 8:26 PM Andrew Lunn wrote: > > > > > > > > On Wed, Jul 31, 2019 at 03:10:32PM +0530, Harini Katakam wrote: > > > > > Add a new property to indicate when PS SGMII is used with NO > > > > > external PHY on board. > > > > > > > > Hi Harini > > > > > > > > What exactly is you use case? Are you connecting to a Ethernet switch? > > > > To an SFP cage with a copper module? > > > > > > Yes, an SFP cage is the common HW target for this patch. > > > > Hi Harini > > > > So you have a copper PHY in the SFP cage. It will talk SGMII > > signalling to your PS SGMII. When that signalling is complete i would > > expect the MAC to raise an interrupt, just as if the SGMII PHY was > > soldered on the board. So i don't see why you need this polling? > > > > Thanks. Sorry, I overlooked this interrupt. Let me try that. Even with the use of this interrupt, the link status actions (link print and netif ops) will still be required. And also the need for macb_open to proceed without phydev. Could you please let me know if that is acceptable to patch or if there's a cleaner way to report this link status? Regards, Harini --00000000000028ca29058f60f42c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hi Andrew,

On Mon, Aug 5, 2019 at 8:06 PM Harini Katakam <harinik@xilinx.com> wrote:
>> Hi Andrew,
>
> On Mon, Aug 5, 2019 at 7:00 PM Andrew Lunn= <andrew@lunn.ch> wrote:
>= ; >
> > On Mon, Aug 05, 2019 at 11:45:05AM +0530, Harini Kataka= m wrote:
> > > Hi Andrew,
> > >
> > > O= n Sun, Aug 4, 2019 at 8:26 PM Andrew Lunn <andrew@lunn.ch> wrote:
> > > >
> > >= > On Wed, Jul 31, 2019 at 03:10:32PM +0530, Harini Katakam wrote:
&g= t; > > > > Add a new property to indicate when PS SGMII is used= with NO
> > > > > external PHY on board.
> > &g= t; >
> > > > Hi Harini
> > > >
> >= ; > > What exactly is you use case? Are you connecting to a Ethernet = switch?
> > > > To an SFP cage with a copper module?
>= > >
> > > Yes, an SFP cage is the common HW target for t= his patch.
> >
> > Hi Harini
> >
> > So= you have a copper PHY in the SFP cage. It will talk SGMII
> > sig= nalling to your PS SGMII. When that signalling is complete i would
> = > expect the MAC to raise an interrupt, just as if the SGMII PHY was
= > > soldered on the board. So i don't see why you need this polli= ng?
> >
>
> Thanks. Sorry, I overlooked this interrupt= . Let me try that.

Even with the use of this interrupt, the link sta= tus actions (link print and
netif ops) will still be required. And also = the need for macb_open to
proceed without phydev. Could you please let m= e know if that is acceptable
to patch or if there's a cleaner way to=
report this link status?

Regards,
Harini
--00000000000028ca29058f60f42c--