From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA72DC433E1 for ; Fri, 31 Jul 2020 08:56:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C94AE2084D for ; Fri, 31 Jul 2020 08:56:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="aE1OHoox" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731975AbgGaI4S (ORCPT ); Fri, 31 Jul 2020 04:56:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55904 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731929AbgGaI4R (ORCPT ); Fri, 31 Jul 2020 04:56:17 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 555BBC061575 for ; Fri, 31 Jul 2020 01:56:17 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id f18so27279790wrs.0 for ; Fri, 31 Jul 2020 01:56:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uKHultmexfuWBdCK9WRDRk/vbhZ+37y2O3wAMlcu988=; b=aE1OHooxwN4CtoTfKoukXZmAijnt7lUt7g2YEmORS3cT7AcMzMNPBMqe8jdLYclZBm eOHaWEarxXuFCjto12aNCFolbMakz+DiEVyPF5mrDDnb4gRfoCRQPp7jBy5l2R7n/un1 nBoT11Vhvh4xhvgqwcqKCnGpBSQmKQyJHI6yE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uKHultmexfuWBdCK9WRDRk/vbhZ+37y2O3wAMlcu988=; b=p58oAZf0+qQAGPkhlkH2D3EdRpjuJ7tHLJL6u0UJtVoc9v6YVrvEEtYd/vHHxHnZVW lBy904FpXRjfk4s4YVm6N06FTH6pBH7TPzQqFNoBGh8o9prt9ajpgEB8fc9NaskOC8iS wb3I/IpHP5eGgTo18eKnhn6z5Ac+okVupF2UpKugNK1fLuMi5ymqHJo0MhFZFD78SUta pWUjHtMeuwCiXc+XXQXF/K+Ucam3KzvlBS0Wv+32T2/Cm4WNuPvRiPqFgumgwhky1PrG lRG+i5CwYF0NilQe6Ymgr5aHNQjqIUUbJIkAt43FKjuiGCz06SKjCEXziM8zmBmV6JU3 H3lQ== X-Gm-Message-State: AOAM533ITlst7+3VsKLdEqGEHauXJSQ1RnI0KZqVbwnoDmNW1WJlDi0D Lsgv9Xx9DBJPPPSd7RpC5nJaXSpGEI04et6o7b4flw== X-Google-Smtp-Source: ABdhPJzWn3jZhPtcamUMQKgiq4Q2WoIJL296BZio2qPps8qapt7QAgo3rn4E433qso7peWw9XBVW+myXjp0sLi36trw= X-Received: by 2002:adf:e486:: with SMTP id i6mr2505317wrm.258.1596185775852; Fri, 31 Jul 2020 01:56:15 -0700 (PDT) MIME-Version: 1.0 References: <20200721104422.369368-1-cychiang@chromium.org> <20200721104422.369368-3-cychiang@chromium.org> <20200723184432.GA321518@gerhold.net> In-Reply-To: <20200723184432.GA321518@gerhold.net> From: Cheng-yi Chiang Date: Fri, 31 Jul 2020 16:55:49 +0800 Message-ID: Subject: Re: [PATCH v2 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration To: Stephan Gerhold Cc: Srinivas Kandagatla , linux-kernel , Mark Brown , Taniya Das , Rohit kumar , Banajit Goswami , Patrick Lai , Andy Gross , Bjorn Andersson , Liam Girdwood , Rob Herring , Jaroslav Kysela , Takashi Iwai , Doug Anderson , Dylan Reid , Tzung-Bi Shih , Linux ARM , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:SOUND - SOC LAYER / DYNAMIC AUDIO POWER MANAGEM..." , Ajit Pandey Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Jul 24, 2020 at 2:45 AM Stephan Gerhold wrote: > > On Wed, Jul 22, 2020 at 10:25:14AM +0100, Srinivas Kandagatla wrote: > > > +static int sc7180_parse_of(struct snd_soc_card *card) > > > +{ > > > > This code is getting duplicated in various places like apq8016_sbc_parse_of, > > it will be nice to common this up, if possible! > > > > FYI, I started work on making apq8016_sbc use qcom_snd_parse_of() > a while ago already, but didn't find the time to finish it up. > I have now sent it, this should make it possible to use the common > qcom_snd_parse_of() function in this driver as well. > > See: https://lore.kernel.org/alsa-devel/20200723183904.321040-1-stephan@gerhold.net/ > > Stephan > Hi Stephan, thanks a lot for jumping on this to help. It indeed makes this new driver much cleaner. I have tested with your patches and it works great.