From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB613C46466 for ; Fri, 2 Oct 2020 17:59:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE57220795 for ; Fri, 2 Oct 2020 17:59:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="hxne4JB9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387934AbgJBR7c (ORCPT ); Fri, 2 Oct 2020 13:59:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59106 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387692AbgJBR7c (ORCPT ); Fri, 2 Oct 2020 13:59:32 -0400 Received: from mail-yb1-xb41.google.com (mail-yb1-xb41.google.com [IPv6:2607:f8b0:4864:20::b41]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60090C0613E3 for ; Fri, 2 Oct 2020 10:59:32 -0700 (PDT) Received: by mail-yb1-xb41.google.com with SMTP id h9so1775062ybm.4 for ; Fri, 02 Oct 2020 10:59:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vZbuayUw4nR5ldchYC0QJ2SKyNmd/sp/ZArDf0aVmf4=; b=hxne4JB9HZja3FImgOTwwGft+D9UZ0uS9fK4OcJP2Eg1oroqmn/9modjXkPJGSlN8g Lh5UDYM7CynmC7F+t8Uq5psnpU8Z5iPg+RgiXlsA6p/lD2mphiU75QAqHBKi1YSqj7XW 7LoAJgH6xJq1blMl4m/G5sIIkMci/wvcZrPRhucqEIygDXBzfFT+Qf7VHFgFAyQk/z+1 F/V36+u2ogFL7XMkvpu/ekSzZkW2RoA3QWTLoD2astGElGbvCRuXZLvLQNp8zSMbfqsI izqQ+mlyGkYqerxmFose6Nqt7AAsAnO9detgWoYY7GHj8Az83ZD5RLrYOddI9P+0V/ml IIMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vZbuayUw4nR5ldchYC0QJ2SKyNmd/sp/ZArDf0aVmf4=; b=Fj6CYYpBTpxqfRAUIdcMyuY9/yvaUdT4xhF+UalfUGrpe+AsmHywMbllewmSV/hEfp p2bSSjUAVfG6hYwEcxte/+xm8/lF7daAdxVakb803oTQdgbM++zVc88dmCO7cuTBMmR4 nUdn6cCzgGqBceQBTQasLMKuB2rh9ezc4mae0gv6T49sTDmH+jCYwyI5P6BEg35oFfmq JzmpSeHZjcNQSlqazETFYkWy/8a8NH/LWFXjUr62PP+o6QiNuBGPIF0kXcQhe+TbXYmr OFkFf4F+3EcoX1E+h/+fkXct+TKfCU4FDaV+SQK1XH5IOVKIDdKOwiIsEMdI2QBgL/Pc CNUw== X-Gm-Message-State: AOAM532gY2yiOa2R04kn6psw46msyFTfZkIY6lsmBIZrurV8539wjyqo iDVceXqAArE1BK3s5eoFJalG+wn04FwbSqzdKuUf0g== X-Google-Smtp-Source: ABdhPJy+2uWxMGaMD27VX8hqKxgrKfNstiISBRAtvv2ZfenCYYbpD2QB2rzAxASzDDq7221cpxy+ivvqhR77p6L+E3Y= X-Received: by 2002:a05:6902:725:: with SMTP id l5mr4142164ybt.346.1601661571259; Fri, 02 Oct 2020 10:59:31 -0700 (PDT) MIME-Version: 1.0 References: <20201001225952.3676755-1-saravanak@google.com> <20201002175423.GE3933@pendragon.ideasonboard.com> In-Reply-To: <20201002175423.GE3933@pendragon.ideasonboard.com> From: Saravana Kannan Date: Fri, 2 Oct 2020 10:58:55 -0700 Message-ID: Subject: Re: [PATCH v1] of: platform: Batch fwnode parsing in the init_machine() path To: Laurent Pinchart Cc: Rob Herring , Frank Rowand , Geert Uytterhoeven , Greg Kroah-Hartman , Grygorii Strashko , linux-omap , "open list:THERMAL" , Peter Ujfalusi , "Rafael J. Wysocki" , Tomi Valkeinen , Tony Lindgren , Ulf Hansson , Android Kernel Team , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Oct 2, 2020 at 10:55 AM Laurent Pinchart wrote: > > Hi Saravana, > > On Fri, Oct 02, 2020 at 10:51:51AM -0700, Saravana Kannan wrote: > > On Fri, Oct 2, 2020 at 7:08 AM Rob Herring wrote: > > > On Thu, Oct 1, 2020 at 5:59 PM Saravana Kannan wrote: > > > > > > > > When commit 93d2e4322aa7 ("of: platform: Batch fwnode parsing when > > > > adding all top level devices") optimized the fwnode parsing when all top > > > > level devices are added, it missed out optimizing this for platform > > > > where the top level devices are added through the init_machine() path. > > > > > > > > This commit does the optimization for all paths by simply moving the > > > > fw_devlink_pause/resume() inside of_platform_default_populate(). > > > > > > > > Reported-by: Tomi Valkeinen > > > > Signed-off-by: Saravana Kannan > > > > --- > > > > drivers/of/platform.c | 19 +++++++++++++++---- > > > > 1 file changed, 15 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/drivers/of/platform.c b/drivers/of/platform.c > > > > index 071f04da32c8..79972e49b539 100644 > > > > --- a/drivers/of/platform.c > > > > +++ b/drivers/of/platform.c > > > > @@ -501,8 +501,21 @@ int of_platform_default_populate(struct device_node *root, > > > > const struct of_dev_auxdata *lookup, > > > > struct device *parent) > > > > { > > > > - return of_platform_populate(root, of_default_bus_match_table, lookup, > > > > - parent); > > > > + int ret; > > > > + > > > > + /* > > > > + * fw_devlink_pause/resume() are only safe to be called around top > > > > + * level device addition due to locking constraints. > > > > + */ > > > > + if (!root) > > > > + fw_devlink_pause(); > > > > + > > > > + ret = of_platform_populate(root, of_default_bus_match_table, lookup, > > > > + parent); > > > > > > of_platform_default_populate() vs. of_platform_populate() is just a > > > different match table. I don't think the behavior should otherwise be > > > different. > > > > > > There's also of_platform_probe() which has slightly different matching > > > behavior. It should not behave differently either with respect to > > > devlinks. > > > > So I'm trying to do this only when the top level devices are added for > > the first time. of_platform_default_populate() seems to be the most > > common path. For other cases, I think we just need to call > > fw_devlink_pause/resume() wherever the top level devices are added for > > the first time. As I said in the other email, we can't add > > fw_devlink_pause/resume() by default to of_platform_populate(). > > > > Do you have other ideas for achieving "call fw_devlink_pause/resume() > > only when top level devices are added for the first time"? > > I'm not an expert in this domain, but before investigating it, would you > be able to share a hack patch that implements this (in the most simple > way) to check if it actually fixes the delays I experience on my system > ? So I take it the patch I sent out didn't work for you? Can you tell me what machine/DT you are using? -Saravana