From mboxrd@z Thu Jan 1 00:00:00 1970 From: Saravana Kannan Subject: Re: [PATCH v3 1/6] dt-bindings: opp: Introduce opp-peak-KBps and opp-avg-KBps bindings Date: Wed, 17 Jul 2019 13:29:47 -0700 Message-ID: References: <20190703011020.151615-1-saravanak@google.com> <20190703011020.151615-2-saravanak@google.com> <20190717075448.xlyg2ddewlci3abg@vireshk-i7> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20190717075448.xlyg2ddewlci3abg@vireshk-i7> Sender: linux-kernel-owner@vger.kernel.org To: Viresh Kumar Cc: Georgi Djakov , Rob Herring , Mark Rutland , Viresh Kumar , Nishanth Menon , Stephen Boyd , "Rafael J. Wysocki" , Vincent Guittot , "Sweeney, Sean" , daidavid1@codeaurora.org, Rajendra Nayak , Sibi Sankar , Bjorn Andersson , Evan Green , Android Kernel Team , Linux PM , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML List-Id: devicetree@vger.kernel.org On Wed, Jul 17, 2019 at 12:54 AM Viresh Kumar wrote: > > On 02-07-19, 18:10, Saravana Kannan wrote: > > Interconnects often quantify their performance points in terms of > > bandwidth. So, add opp-peak-KBps (required) and opp-avg-KBps (optional) to > > allow specifying Bandwidth OPP tables in DT. > > > > opp-peak-KBps is a required property that replace opp-hz for Bandwidth OPP > > tables. > > > > opp-avg-KBps is an optional property that can be used in Bandwidth OPP > > tables. > > > > Signed-off-by: Saravana Kannan > > --- > > Documentation/devicetree/bindings/opp/opp.txt | 15 ++++++++++++--- > > 1 file changed, 12 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/opp/opp.txt b/Documentation/devicetree/bindings/opp/opp.txt > > index 76b6c79604a5..c869e87caa2a 100644 > > --- a/Documentation/devicetree/bindings/opp/opp.txt > > +++ b/Documentation/devicetree/bindings/opp/opp.txt > > @@ -83,9 +83,14 @@ properties. > > > > Required properties: > > - opp-hz: Frequency in Hz, expressed as a 64-bit big-endian integer. This is a > > - required property for all device nodes but devices like power domains. The > > - power domain nodes must have another (implementation dependent) property which > > - uniquely identifies the OPP nodes. > > + required property for all device nodes but for devices like power domains or > > + bandwidth opp tables. The power domain nodes must have another (implementation > > + dependent) property which uniquely identifies the OPP nodes. The interconnect > > + opps are required to have the opp-peak-bw property. > > ?? Sorry, what's the question? Was this an accidental email? -Saravana > > > + > > +- opp-peak-KBps: Peak bandwidth in kilobytes per second, expressed as a 32-bit > > + big-endian integer. This is a required property for all devices that don't > > + have opp-hz. For example, bandwidth OPP tables for interconnect paths. > > > > Optional properties: > > - opp-microvolt: voltage in micro Volts. > > @@ -132,6 +137,10 @@ Optional properties: > > - opp-level: A value representing the performance level of the device, > > expressed as a 32-bit integer. > > > > +- opp-avg-KBps: Average bandwidth in kilobytes per second, expressed as a > > + 32-bit big-endian integer. This property is only meaningful in OPP tables > > + where opp-peak-KBps is present. > > + > > - clock-latency-ns: Specifies the maximum possible transition latency (in > > nanoseconds) for switching to this OPP from any other OPP. > > > > -- > > 2.22.0.410.gd8fdbe21b5-goog > > -- > viresh > > -- > To unsubscribe from this group and stop receiving emails from it, send an email to kernel-team+unsubscribe@android.com. >