From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julian Calaby Subject: Re: [linux-sunxi] [RFC PATCH 1/9] ARM: add CONFIG_ARCH_SUNXI_V7 for differentiate ARMv5/v7 Allwinner SoCs Date: Sat, 20 Jan 2018 14:04:48 +1100 Message-ID: References: <20180119231735.61504-1-icenowy@aosc.io> <20180119231735.61504-2-icenowy@aosc.io> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20180119231735.61504-2-icenowy@aosc.io> Sender: linux-clk-owner@vger.kernel.org To: icenowy@aosc.io Cc: Maxime Ripard , Chen-Yu Tsai , Russell King , Daniel Lezcano , Marc Zyngier , Linus Walleij , devicetree , "Mailing List, Arm" , "linux-kernel@vger.kernel.org" , "open list:COMMON CLK FRAMEWORK" , linux-gpio@vger.kernel.org, linux-sunxi List-Id: devicetree@vger.kernel.org Hi Icenowy, On Sat, Jan 20, 2018 at 10:17 AM, Icenowy Zheng wrote: > Allwinner also has some ARMv5 SoCs. > > In order to add support for them, add a CONFIG_ARCH_SUNXI_V7 option that > is selectable when ARMv7 is selceted, and make CONFIG_ARCH_SUNXI a > common bool config which is selected by both V7 and V5 sunxi option. > > The ARMv7 defconfigs are modified to have the new CONFIG_ARCH_SUNXI_V7 > option. > > Signed-off-by: Icenowy Zheng > --- > arch/arm/configs/multi_v7_defconfig | 2 +- > arch/arm/configs/sunxi_defconfig | 2 +- > arch/arm/mach-sunxi/Kconfig | 14 ++++++++++++-- > arch/arm/mach-sunxi/Makefile | 2 +- > 4 files changed, 15 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/mach-sunxi/Kconfig b/arch/arm/mach-sunxi/Kconfig > index 58153cdf025b..65509a35935f 100644 > --- a/arch/arm/mach-sunxi/Kconfig > +++ b/arch/arm/mach-sunxi/Kconfig > @@ -1,6 +1,16 @@ > -menuconfig ARCH_SUNXI > +config ARCH_SUNXI > + bool > + select ARCH_HAS_RESET_CONTROLLER > + select CLKSRC_MMIO > + select GENERIC_IRQ_CHIP > + select GPIOLIB > + select PINCTRL > + select RESET_CONTROLLER > + > +menuconfig ARCH_SUNXI_V7 > bool "Allwinner SoCs" > depends on ARCH_MULTI_V7 > + select ARCH_SUNXI > select ARCH_HAS_RESET_CONTROLLER > select CLKSRC_MMIO > select GENERIC_IRQ_CHIP Shouldn't you remove all the common ARCH_SUNXI selects from ARCH_SUNXI_v7? Thanks, -- Julian Calaby Email: julian.calaby@gmail.com Profile: http://www.google.com/profiles/julian.calaby/