From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F82FC4338F for ; Mon, 26 Jul 2021 08:58:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 672C560D07 for ; Mon, 26 Jul 2021 08:58:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231844AbhGZIR5 (ORCPT ); Mon, 26 Jul 2021 04:17:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231779AbhGZIR5 (ORCPT ); Mon, 26 Jul 2021 04:17:57 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 245F4C061757 for ; Mon, 26 Jul 2021 01:58:26 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id g13so14094040lfj.12 for ; Mon, 26 Jul 2021 01:58:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tjJug7Q8q6d0CbJrYfSZgFOLb9rWU+eNbzf7D0T8EG8=; b=DK6BNTioO9pLA0zgUFyAhLl5WNTJx2sD/tsmB48ktbU0/j1s5OMESOBvX/fOlDH4LU B2RxRBYlutT2qBKsIOnfoX5REG1LDTQUAfMEXNd+IMldzlbB3GTZXBJWJDAW8OUxzAe5 NbbxSLfuOMgt4R2d0pL52nOtrKaX9LL1wngwM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tjJug7Q8q6d0CbJrYfSZgFOLb9rWU+eNbzf7D0T8EG8=; b=Uyq+Wan241S9WQb+NyXHGAjV+FMND1YP2hptQilB1SL5/Nrx2yUFdYUnlhWd5ftlK2 OlMfH9l7KxFHgdgAGGGifIki6lgjXTVN1QBveSiqnD1CnxJs9yN2N+I/39tvvC4hnb8T OyEDY2j31XJgjwuqdkCwQSqFON2eAKTqHp3Cp+qqh9MOccU6YRyrS/+8xZUaNpPv0iL1 vKEZ+4WdWrA5ocJpeA2JGBlrLgXrJldnoO1Ghuuw83auTjedf/BwxsMJ+b0lLlmScU5+ k4jrQcyhu7L9Xn+OjPFRRL9PFNmS3vV05eC6oECgZw6b5yEC19AU/erXA2kuFNF8MT7H 7MTQ== X-Gm-Message-State: AOAM533PNj00FsFigTC2ueb+eeDuApEBtwNpo/6Lab0lO7ydtpZpfmaH gs2o4R8Q+1vCLAege7VQXRNc5kRWPX6VJ/afDUQ/og== X-Google-Smtp-Source: ABdhPJwnhtzxRaGOMn4t4PeAcTHpr1ccxQJ2FBsDEcwC7sCwm1x/bCY+vqG8t3AdWboRCIjmWscEg06CfaCxndy6uks= X-Received: by 2002:ac2:57d2:: with SMTP id k18mr12583576lfo.656.1627289904559; Mon, 26 Jul 2021 01:58:24 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Chen-Yu Tsai Date: Mon, 26 Jul 2021 16:58:13 +0800 Message-ID: Subject: Re: arm64: dts: mt8183: Incorrect mediatek,pull-*-adv values To: Hsin-Yi Wang Cc: Enric Balletbo i Serra , Fabien Parent , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-gpio@vger.kernel.org, Devicetree List , Zhiyong Tao Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Jul 26, 2021 at 4:50 PM Hsin-Yi Wang wrote: > > On Mon, Jul 26, 2021 at 4:20 PM Chen-Yu Tsai wrote: > > > > Hi, > > > > I was looking at MTK pinctrl stuff upstream, and it seems there are a few > > `mediatek,pull-*-adv` entries that have invalid values: > > > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-up-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-up-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > mediatek,pull-up-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > mediatek,pull-down-adv = <10>; > > arch/arm64/boot/dts/mediatek/mt8183-pumpkin.dts: > > mediatek,pull-up-adv = <10>; > > > > According to the bindings, the values should 0~3. <10> is probably a > > incorrect attempt at using binary representation, which is wrong. This > > probably leads to the pull-up/down getting disabled or ignored. > > > > Cound people still working on these two devices take a look? > > > Thanks for pointing this out. It's an incorrect value but 10=0b1010 so > the result is same as 2, since the driver test the value by checking > the last 2 bit. We should still fix this in dts. That probably explains why no one noticed.