From: Chen-Yu Tsai <wenst@chromium.org>
To: Tzung-Bi Shih <tzungbi@google.com>
Cc: Tinghan Shen <tinghan.shen@mediatek.com>,
ohad@wizery.com, bjorn.andersson@linaro.org,
mathieu.poirier@linaro.org, Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>,
srv_heupstream <srv_heupstream@mediatek.com>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [v2 1/2] dt-bindings: remoteproc: mediatek: Add binding for mt8195 scp
Date: Mon, 12 Jul 2021 14:59:00 +0800 [thread overview]
Message-ID: <CAGXv+5EtUqe=HECJFkZXdDX9cV_wMp0OykHDOBJVWPF3MwA4ZQ@mail.gmail.com> (raw)
In-Reply-To: <CA+Px+wUVsY6CYwEdfSeK+KQGmvb224hvchgnTwX0rgBzMvXfqw@mail.gmail.com>
On Mon, Jul 12, 2021 at 2:06 PM Tzung-Bi Shih <tzungbi@google.com> wrote:
>
> On Sat, Jul 10, 2021 at 8:25 PM Tinghan Shen <tinghan.shen@mediatek.com> wrote:
> > @@ -5,13 +5,15 @@ This binding provides support for ARM Cortex M4 Co-processor found on some
> > Mediatek SoCs.
> >
> > Required properties:
> > -- compatible Should be "mediatek,mt8183-scp"
> > +- compatible Should be one of:
> > + "mediatek,mt8183-scp"
> > + "mediatek,mt8195-scp"
> Just realized we forgot to add DT bindings for mediatek,mt8192-scp[1].
> Could you send another patch for adding the missing property?
>
> [1]: https://elixir.bootlin.com/linux/v5.13.1/source/drivers/remoteproc/mtk_scp.c#L879
>
> > -- clocks Clock for co-processor (See: ../clock/clock-bindings.txt)
> > -- clock-names Contains the corresponding name for the clock. This
> > +- clocks Required by mt8183. Clock for co-processor (See: ../clock/clock-bindings.txt)
> > +- clock-names Required by mt8183. Contains the corresponding name for the clock. This
> > should be named "main".
> Let's move clocks and clock-names to "Optional properties". See [2]
> for your reference. I guess it doesn't need to mention which chip
> needs the properties. For those chips that need the clock properties,
> they won't work correctly without correct clock properties.
I would suggest still adding them. We will need to describe the requirements
anyway then the binding is converted to DT schema.
ChenYu
> [2]: https://elixir.bootlin.com/linux/v5.13.1/source/Documentation/devicetree/bindings/remoteproc/ti,keystone-rproc.txt#L87
>
>
> Suggested to provide a cover letter for the series next time.
>
> nit: other patches usually use "[PATCH v2 1/2]" in the email title
> instead of the one used in the mail.
>
> _______________________________________________
> Linux-mediatek mailing list
> Linux-mediatek@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-07-12 7:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-10 12:24 [v2 1/2] dt-bindings: remoteproc: mediatek: Add binding for mt8195 scp Tinghan Shen
2021-07-10 12:24 ` [v2 2/2] remoteproc: mediatek: Support " Tinghan Shen
2021-07-12 6:06 ` Tzung-Bi Shih
2021-07-12 6:05 ` [v2 1/2] dt-bindings: remoteproc: mediatek: Add binding for " Tzung-Bi Shih
2021-07-12 6:59 ` Chen-Yu Tsai [this message]
2021-07-12 7:01 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGXv+5EtUqe=HECJFkZXdDX9cV_wMp0OykHDOBJVWPF3MwA4ZQ@mail.gmail.com' \
--to=wenst@chromium.org \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=matthias.bgg@gmail.com \
--cc=ohad@wizery.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=tinghan.shen@mediatek.com \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).