From: Chen-Yu Tsai <wenst@chromium.org>
To: Hsin-Yi Wang <hsinyi@chromium.org>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
zhiyong.tao@mediatek.com, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: mt8183: kukui: use generic pin configs for i2c pins
Date: Wed, 30 Jun 2021 15:29:16 +0800 [thread overview]
Message-ID: <CAGXv+5GE_ksZseTWKLpwrZvQkLx64TvATYw_dGKzOCU1Jd0hKQ@mail.gmail.com> (raw)
In-Reply-To: <CAGXv+5ERomKaid2wQ5Sz9CB-q+DVLMzWq08b+rkkh5=3WnG5Vg@mail.gmail.com>
On Wed, Jun 30, 2021 at 3:27 PM Chen-Yu Tsai <wenst@chromium.org> wrote:
>
> On Wed, Jun 30, 2021 at 11:55 AM Hsin-Yi Wang <hsinyi@chromium.org> wrote:
> >
> > mt8183 i2c pins don't support PUPD register, so change to use generic
> > pin configs instead of let it fail and fallback.
> >
> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
>
> Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
You might also want:
Fixes: cd894e274b74 ("arm64: dts: mt8183: Add krane-sku176 board")
> On a side note, the `mediatek,pull-up-adv` property probably should be
> merged into `bias-pull-up` with an argument.
prev parent reply other threads:[~2021-06-30 7:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-30 3:54 [PATCH] arm64: dts: mt8183: kukui: use generic pin configs for i2c pins Hsin-Yi Wang
2021-06-30 7:27 ` Chen-Yu Tsai
2021-06-30 7:29 ` Chen-Yu Tsai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGXv+5GE_ksZseTWKLpwrZvQkLx64TvATYw_dGKzOCU1Jd0hKQ@mail.gmail.com \
--to=wenst@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=hsinyi@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=zhiyong.tao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).