From: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
linux-arm-kernel
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 1/3] ARM: dts: sun4i: The blue led on the Mele A1000 is a power led
Date: Mon, 6 Jun 2016 15:05:51 +0800 [thread overview]
Message-ID: <CAGb2v66nnStG-JUwgPpiSsde0kbfeL5m-OfpmDNornhiMrhm7A@mail.gmail.com> (raw)
In-Reply-To: <CAGb2v66iYcOCSbX6Q9OLFYaaCpzqRC94v+OXfd8gcD7GG1eZRg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Mon, Jun 6, 2016 at 3:01 PM, Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org> wrote:
> On Sun, Jun 5, 2016 at 8:23 PM, Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> wrote:
>> The blue led on the Mele A1000 is wired to light up as soon as the board
>> has powered (it will be on while the gpio is still in input / floating
>> mode), also its location on the top-set box clearly signals "power led".
>>
>> Until now we've been treating this as a generic usr function led, which
>> means that when you plug power into the top-set box, the power-led lights
>> and then turns off as soon as the kernel loads, which looks wrong.
>>
>> This renames the led from a1000:blue:usr to a1000:blue:pwr and marks
>> it as default on, fixing this.
>>
>> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>
> Acked-by: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>
BTW, the kernel now supports using an LED as a panic indicator.
Would it be useful to use the power LED for this?
ChenYu
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-06-06 7:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-05 12:23 [PATCH 1/3] ARM: dts: sun4i: The blue led on the Mele A1000 is a power led Hans de Goede
[not found] ` <1465129393-22379-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-06-05 12:23 ` [PATCH 2/3] ARM: dts: sun6i: The blue led on the Mele A1000G quad " Hans de Goede
[not found] ` <1465129393-22379-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-06-06 7:01 ` Chen-Yu Tsai
2016-06-05 12:23 ` [PATCH 3/3] ARM: dts: sun6i: The blue led on the Mele M9 " Hans de Goede
[not found] ` <1465129393-22379-3-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-06-06 7:02 ` Chen-Yu Tsai
2016-06-06 7:01 ` [PATCH 1/3] ARM: dts: sun4i: The blue led on the Mele A1000 " Chen-Yu Tsai
[not found] ` <CAGb2v66iYcOCSbX6Q9OLFYaaCpzqRC94v+OXfd8gcD7GG1eZRg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-06 7:05 ` Chen-Yu Tsai [this message]
[not found] ` <CAGb2v66nnStG-JUwgPpiSsde0kbfeL5m-OfpmDNornhiMrhm7A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-06 7:24 ` Hans de Goede
2016-06-07 21:24 ` Maxime Ripard
2016-06-08 13:23 ` Hans de Goede
[not found] ` <0acb666e-3fa7-fb10-4c0d-1d7990f9eaa6-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-06-11 15:45 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGb2v66nnStG-JUwgPpiSsde0kbfeL5m-OfpmDNornhiMrhm7A@mail.gmail.com \
--to=wens-jday2fn1rrm@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).