From: Adam Ford <aford173@gmail.com>
To: "H. Nikolaus Schaller" <hns@goldelico.com>
Cc: "Andreas Kemnade" <andreas@kemnade.info>,
Linux-OMAP <linux-omap@vger.kernel.org>,
"Adam Ford-BE" <aford@beaconembedded.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Tony Lindgren" <tony@atomide.com>,
"Rob Herring" <robh+dt@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] ARM: dts: omap36xx: Remove turbo mode for 1GHz variants
Date: Sat, 2 Oct 2021 07:12:05 -0500 [thread overview]
Message-ID: <CAHCN7x+TdPb0UthQ9CeQL_sWwJmRK++M1kUXZVvCcj8anAFqRQ@mail.gmail.com> (raw)
In-Reply-To: <C0A84970-0AAC-42E7-8E0F-4D165F0C9551@goldelico.com>
On Fri, Oct 1, 2021 at 4:59 AM H. Nikolaus Schaller <hns@goldelico.com> wrote:
>
>
>
> > Am 01.10.2021 um 09:54 schrieb Andreas Kemnade <andreas@kemnade.info>:
> >
> > On Sat, 9 Jan 2021 11:01:03 -0600
> > Adam Ford <aford173@gmail.com> wrote:
> >
> >> Previously, the 1GHz variants were marked as a turbo,
> >> because that variant has reduced thermal operating range.
> >>
> >> Now that the thermal throttling is in place, it should be
> >> safe to remove the turbo-mode from the 1GHz variants, because
> >> the CPU will automatically slow if the thermal limit is reached.
> >>
> >> Signed-off-by: Adam Ford <aford173@gmail.com>
> >> ---
> >> V2: The orignal patch had the wrong file added. Add the omap36xx.dtsi
> >>
> > hmm, I somehow expected that there is a revert of this thing going
> > through. But now, the turbo-mode is still missing
>
> tagging by turbo-mode means the OPP is *disabled* by default and
> needs to be enabled actively.
>
> > and I understood the
> > revert is only in Nikolaus' trees.
>
> It is just a revert for the gta04a5 because I think it is the only board
> which is affected (maybe it would need SmartReflex in operation to
> fine tune the OPPs compared to the generic table). Therefore I have
> a patch which adds turbo-mode to the gta04a5.dts
>
> > The 1Ghz mode was working for some
> > time but does not anymore. Is it just me or do others also have the
> > same problems?
>
> That would be interesting to know.
>
What version are you seeing the break? It's working for me on 5.15.y branch
# cat /sys/devices/system/cpu/cpufreq/policy0/scaling_available_frequencies
300000 600000 800000 1000000
# uname -a
Linux buildroot 5.14.9-00260-g70248e7b378b-dirty #1 SMP Sat Oct 2
06:56:02 CDT 2021 armv7l GNU/Linux
#
adam
> BR,
> NIkolaus
>
> >
> >
> >> diff --git a/arch/arm/boot/dts/omap36xx.dtsi b/arch/arm/boot/dts/omap36xx.dtsi
> >> index 05fe5ed127b0..20844dbc002e 100644
> >> --- a/arch/arm/boot/dts/omap36xx.dtsi
> >> +++ b/arch/arm/boot/dts/omap36xx.dtsi
> >> @@ -72,7 +72,6 @@ opp1g-1000000000 {
> >> <1375000 1375000 1375000>;
> >> /* only on am/dm37x with speed-binned bit set */
> >> opp-supported-hw = <0xffffffff 2>;
> >> - turbo-mode;
> >> };
> >> };
> >>
> >
>
next prev parent reply other threads:[~2021-10-02 12:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-09 17:01 [PATCH V2] ARM: dts: omap36xx: Remove turbo mode for 1GHz variants Adam Ford
2021-01-26 11:20 ` Tony Lindgren
2021-10-01 7:54 ` Andreas Kemnade
2021-10-01 9:59 ` H. Nikolaus Schaller
2021-10-02 12:12 ` Adam Ford [this message]
2021-10-07 18:00 ` Andreas Kemnade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHCN7x+TdPb0UthQ9CeQL_sWwJmRK++M1kUXZVvCcj8anAFqRQ@mail.gmail.com \
--to=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=andreas@kemnade.info \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=hns@goldelico.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).