From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adam Ford Subject: Re: [PATCH v5 01/44] dt-bindings: clock: Add new bindings for TI Davinci PLL clocks Date: Tue, 16 Jan 2018 06:21:22 -0600 Message-ID: References: <1515377863-20358-1-git-send-email-david@lechnology.com> <22409e49-5c14-4068-b137-7535afaf90d7@lechnology.com> <0f90b5f7-f21e-5f81-1154-9a815bbb786d@ti.com> <5aacc350-6236-2e4f-35bb-a681fc9d47e7@ti.com> <40501635-6f5b-20c9-f8bc-d17e26b58426@lechnology.com> <5832fd62-16aa-e167-7e52-2ce493e33cdc@lechnology.com> <8184c7b5-5f82-5590-9caf-fd038e1d07ac@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <8184c7b5-5f82-5590-9caf-fd038e1d07ac@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Sekhar Nori Cc: David Lechner , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Michael Turquette , Stephen Boyd , Rob Herring , Mark Rutland , Kevin Hilman , linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org On Tue, Jan 16, 2018 at 5:22 AM, Sekhar Nori wrote: > Hi Adam, David, > > On Friday 12 January 2018 03:04 AM, Adam Ford wrote: >> Thanks for clarifying. I was able to make it work with the following patch: >> >> diff --git a/drivers/clk/davinci/psc-da850.c b/drivers/clk/davinci/psc-da850.c >> index 3b4583d..a76b8682 100644 >> --- a/drivers/clk/davinci/psc-da850.c >> +++ b/drivers/clk/davinci/psc-da850.c >> @@ -25,7 +25,7 @@ static const struct davinci_psc_clk_info >> da850_psc0_info[] __initconst = { >> LPSC(9, 0, uart0, pll0_sysclk2, 0), >> LPSC(13, 0, pruss, pll0_sysclk2, 0), >> LPSC(14, 0, arm, pll0_sysclk6, LPSC_ALWAYS_ENABLED), >> - LPSC(15, 1, dsp, pll0_sysclk1, LPSC_FORCE | LPSC_LOCAL_RESET), >> + LPSC(15, 1, dsp, pll0_sysclk1, LPSC_FORCE | LPSC_LOCAL_RESET | >> LPSC_ALWAYS_ENABLED), > > Keeping the DSP clock always enabled was not needed earlier AFAICS, so > this needs to be investigated. I was testing the DA850-evm and found it was required or the DA850 wouldn't boot. I don't know enough of why to explain it. I went through all the clocks as suggested by David, and this one-line patch fixed the hanging problem I had. Without it the AM1808 board I have won't boot. adam > > Thanks, > Sekhar