From: Adam Ford <aford173@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Anson Huang <Anson.Huang@nxp.com>,
Peter Chen <peter.chen@nxp.com>,
devicetree <devicetree@vger.kernel.org>,
arm-soc <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/6] arm64: dts: imx8mm-beacon-som: fix missing PMIC's interrupt line pull-up
Date: Fri, 30 Oct 2020 07:25:52 -0500 [thread overview]
Message-ID: <CAHCN7xKd=ba9j2D-VSkQf=2YNEm0LR1C+nk8n4C-kCJ3e0NV4g@mail.gmail.com> (raw)
In-Reply-To: <CAHCN7xL2uda0OvkSvZ3tCBGT=WU9OxMqeXvmJaeBSpwb--4=zQ@mail.gmail.com>
On Wed, Oct 7, 2020 at 7:51 AM Adam Ford <aford173@gmail.com> wrote:
>
> On Sun, Sep 27, 2020 at 12:00 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > The PMIC's interrupt is level low and should be pulled up. The PMIC's
> > device node had pinctrl-0 property but it lacked pinctrl-names which
> > is required to apply the pin configuration.
> >
>
> Thanks for the fixes!
>
> > Fixes: 5f67317bd967 ("arm64: dts: imx8mm: correct interrupt flags")
> > Fixes: 593816fa2f35 ("arm64: dts: imx: Add Beacon i.MX8m-Mini development kit")
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Tested-by: Adam Ford <aford173@gmail.com>
>
Shawn,
Any chance you can apply this series? Without this patch, the pmic
driver throws some splat due to a previous fix.
thanks
adam
> > ---
> > arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> > index 6de86a4f0ec4..55b36bddd513 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
> > @@ -72,6 +72,7 @@
> > pmic@4b {
> > compatible = "rohm,bd71847";
> > reg = <0x4b>;
> > + pinctrl-names = "default";
> > pinctrl-0 = <&pinctrl_pmic>;
> > interrupt-parent = <&gpio1>;
> > interrupts = <3 IRQ_TYPE_LEVEL_LOW>;
> > --
> > 2.17.1
> >
next prev parent reply other threads:[~2020-10-30 12:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-27 16:59 [PATCH 1/6] arm64: dts: imx8mm-var-som: fix missing PMIC's interrupt line pull-up Krzysztof Kozlowski
2020-09-27 16:59 ` [PATCH 2/6] arm64: dts: imx8mm-beacon-som: " Krzysztof Kozlowski
2020-10-07 12:51 ` Adam Ford
2020-10-30 12:25 ` Adam Ford [this message]
2020-10-30 12:27 ` Krzysztof Kozlowski
2020-09-27 16:59 ` [PATCH 3/6] arm64: dts: imx8mm-evk: " Krzysztof Kozlowski
2020-09-28 0:07 ` Peter Chen
2020-09-28 8:06 ` Robin Gong
2020-09-27 16:59 ` [PATCH 4/6] arm64: dts: imx8mn-var-som: " Krzysztof Kozlowski
2020-09-27 16:59 ` [PATCH 5/6] arm64: dts: imx8mn-ddr4-evk: " Krzysztof Kozlowski
2020-09-28 0:08 ` Peter Chen
2020-09-27 16:59 ` [PATCH 6/6] arm64: dts: imx8mn-evk: " Krzysztof Kozlowski
2020-10-30 0:26 ` [PATCH 1/6] arm64: dts: imx8mm-var-som: " Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHCN7xKd=ba9j2D-VSkQf=2YNEm0LR1C+nk8n4C-kCJ3e0NV4g@mail.gmail.com' \
--to=aford173@gmail.com \
--cc=Anson.Huang@nxp.com \
--cc=daniel.baluta@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.chen@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).