From: Adam Ford <aford173@gmail.com>
To: Schrempf Frieder <frieder.schrempf@kontron.de>
Cc: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Aymen Sghaier" <aymen.sghaier@nxp.com>,
"Fabio Estevam" <festevam@gmail.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"Horia Geantă" <horia.geanta@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"NXP Linux Team" <linux-imx@nxp.com>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Shawn Guo" <shawnguo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/2] crypto: caam: Change the i.MX8MQ check support all i.MX8M variants
Date: Fri, 6 Dec 2019 13:55:43 -0600 [thread overview]
Message-ID: <CAHCN7xLkV1WC=9ACj1Mi8+uE8kRCEjCEe+Y36pXwkNeNrgrNVg@mail.gmail.com> (raw)
In-Reply-To: <e8e429dd-4508-9835-fd01-825d2de8871e@kontron.de>
On Wed, Dec 4, 2019 at 5:38 AM Schrempf Frieder
<frieder.schrempf@kontron.de> wrote:
>
> Hi Adam,
>
> On 30.11.19 23:51, Adam Ford wrote:
> > The i.MX8M Mini uses the same crypto engine as the i.MX8MQ, but
> > the driver is restricting the check to just the i.MX8MQ.
> >
> > This patch lets the driver support all i.MX8M Variants if enabled.
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
>
> What about the following lines in run_descriptor_deco0()? Does this
> condition also apply to i.MX8MM?
I think that's a question for NXP. I am not seeing that in the NXP
Linux Release, and I don't have an 8MQ to compare.
I was able to get the driver working on the i.MXMM with the patch.
NXP Team,
Do you have any opinions on this?
adam
>
> drivers/crypto/caam/ctrl.c:
>
> if (ctrlpriv->virt_en == 1 ||
> /*
> * Apparently on i.MX8MQ it doesn't matter if virt_en == 1
> * and the following steps should be performed regardless
> */
> of_machine_is_compatible("fsl,imx8mq")) {
> clrsetbits_32(&ctrl->deco_rsr, 0, DECORSR_JR0);
>
> while (!(rd_reg32(&ctrl->deco_rsr) & DECORSR_VALID) &&
> --timeout)
> cpu_relax();
>
> timeout = 100000;
> }
>
> Regards,
> Frieder
>
> >
> > diff --git a/drivers/crypto/caam/ctrl.c b/drivers/crypto/caam/ctrl.c
> > index db22777d59b4..1ce03f8961b6 100644
> > --- a/drivers/crypto/caam/ctrl.c
> > +++ b/drivers/crypto/caam/ctrl.c
> > @@ -527,7 +527,7 @@ static const struct soc_device_attribute caam_imx_soc_table[] = {
> > { .soc_id = "i.MX6UL", .data = &caam_imx6ul_data },
> > { .soc_id = "i.MX6*", .data = &caam_imx6_data },
> > { .soc_id = "i.MX7*", .data = &caam_imx7_data },
> > - { .soc_id = "i.MX8MQ", .data = &caam_imx7_data },
> > + { .soc_id = "i.MX8M*", .data = &caam_imx7_data },
> > { .family = "Freescale i.MX" },
> > { /* sentinel */ }
> > };
> >
next prev parent reply other threads:[~2019-12-06 19:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-30 22:51 [PATCH 1/2] crypto: caam: Change the i.MX8MQ check support all i.MX8M variants Adam Ford
2019-11-30 22:51 ` [PATCH 2/2] arm64: dts: imx8mm: Add Crypto CAAM support Adam Ford
2019-12-09 16:23 ` Horia Geanta
2019-12-09 16:47 ` Adam Ford
2019-12-11 14:36 ` Schrempf Frieder
2019-12-04 11:38 ` [PATCH 1/2] crypto: caam: Change the i.MX8MQ check support all i.MX8M variants Schrempf Frieder
2019-12-06 19:55 ` Adam Ford [this message]
2019-12-10 7:56 ` Horia Geanta
2019-12-11 14:23 ` Schrempf Frieder
2019-12-11 14:27 ` Adam Ford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHCN7xLkV1WC=9ACj1Mi8+uE8kRCEjCEe+Y36pXwkNeNrgrNVg@mail.gmail.com' \
--to=aford173@gmail.com \
--cc=aymen.sghaier@nxp.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frieder.schrempf@kontron.de \
--cc=herbert@gondor.apana.org.au \
--cc=horia.geanta@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).