From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Wolfram Sang <wsa@the-dreams.de>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-i2c <linux-i2c@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
Jassi Brar <jassisinghbrar@gmail.com>
Subject: Re: [PATCH v4 2/2] i2c: add support for Socionext SynQuacer I2C controller
Date: Thu, 1 Mar 2018 20:32:21 +0200 [thread overview]
Message-ID: <CAHp75VcJ4+4-yCm6sKf+Q80FwRMjkjSGMZd5X3hecHQZ9nV7Rw@mail.gmail.com> (raw)
In-Reply-To: <20180301163815.30595-3-ard.biesheuvel@linaro.org>
On Thu, Mar 1, 2018 at 6:38 PM, Ard Biesheuvel
<ard.biesheuvel@linaro.org> wrote:
> This is a cleaned up version of the I2C controller driver for
> the Fujitsu F_I2C IP, which was never supported upstream, and
> has now been incorporated into the Socionext SynQuacer SoC.
> +static int synquacer_i2c_remove(struct platform_device *pdev)
> +{
> + struct synquacer_i2c *i2c = platform_get_drvdata(pdev);
> +
> + platform_set_drvdata(pdev, NULL);
Just noticed, this is redundant for many years since driver core does
it for every device on removal.
It can be fixed by followup though.
> + i2c_del_adapter(&i2c->adapter);
> + if (!IS_ERR(i2c->pclk))
> + clk_disable_unprepare(i2c->pclk);
> +
> + return 0;
> +};
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2018-03-01 18:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 16:38 [PATCH v4 0/2] add support for Socionext SynQuacer I2C controller Ard Biesheuvel
2018-03-01 16:38 ` [PATCH v4 1/2] dt-bindings: i2c: add binding for Socionext SynQuacer I2C Ard Biesheuvel
2018-03-01 16:44 ` Rob Herring
2018-03-01 16:38 ` [PATCH v4 2/2] i2c: add support for Socionext SynQuacer I2C controller Ard Biesheuvel
2018-03-01 18:32 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75VcJ4+4-yCm6sKf+Q80FwRMjkjSGMZd5X3hecHQZ9nV7Rw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=ard.biesheuvel@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).