From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: ChiaEn Wu <peterwu.pub@gmail.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Jingoo Han <jingoohan1@gmail.com>, Pavel Machek <pavel@ucw.cz>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Sebastian Reichel <sre@kernel.org>,
Chunfeng Yun <chunfeng.yun@mediatek.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Guenter Roeck <linux@roeck-us.net>,
"Krogerus, Heikki" <heikki.krogerus@linux.intel.com>,
Helge Deller <deller@gmx.de>,
chiaen_wu@richtek.com, alice_chen@richtek.com,
cy_huang <cy_huang@richtek.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
USB <linux-usb@vger.kernel.org>,
linux-iio <linux-iio@vger.kernel.org>,
"open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>,
szuni chen <szunichen@gmail.com>
Subject: Re: [PATCH v3 08/14] usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver
Date: Thu, 23 Jun 2022 20:07:17 +0200 [thread overview]
Message-ID: <CAHp75Vchspgg_VaM+7JHD+2x+-JPkJXSdtLoqQGAx=kg5uAdSg@mail.gmail.com> (raw)
In-Reply-To: <20220623115631.22209-9-peterwu.pub@gmail.com>
On Thu, Jun 23, 2022 at 2:00 PM ChiaEn Wu <peterwu.pub@gmail.com> wrote:
>
> From: ChiYuan Huang <cy_huang@richtek.com>
>
> Add chip level mt6370 tcpci driver.
...
> +config TYPEC_TCPCI_MT6370
> + tristate "Mediatek MT6370 Type-C driver"
> + depends on MFD_MT6370
> + help
> + Mediatek MT6370 is a multi-functional IC that includes
> + USB Type-C. It works with Type-C Port Controller Manager
> + to provide USB PD and USB Type-C functionalities.
What will be the module name?
...
> +#include <linux/bits.h>
> +#include <linux/interrupt.h>
> +#include <linux/kernel.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
No user of this header is found in this file.
> +#include <linux/platform_device.h>
> +#include <linux/pm_wakeup.h>
> +#include <linux/pm_wakeirq.h>
> +#include <linux/regmap.h>
> +#include <linux/regulator/consumer.h>
> +#include <linux/usb/tcpm.h>
> +#include "tcpci.h"
...
> + if (did == MT6370_TCPC_DID_A) {
> + ret = regmap_write(data->regmap, TCPC_FAULT_CTRL, 0x80);
> + if (ret)
> + return ret;
return regmap_write(...);
> + }
> +
> + return 0;
...
> + if (ret && !source)
> + ret = regulator_disable(priv->vbus);
> + else if (!ret && source)
> + ret = regulator_enable(priv->vbus);
> + else
> + ret = 0;
> +
> + return ret;
Can it be
if (ret && ...)
return regulator_disable(...);
if (!ret && ...)
return regulator_enable(...);
return 0;
?
...
> + if (!priv->tcpci_data.regmap) {
> + dev_err(&pdev->dev, "Failed to init regmap\n");
> + return -ENODEV;
> + }
return dev_err_probe(...); ?
...
> + if (ret) {
> + dev_err(&pdev->dev, "Failed to check vendor info (%d)\n", ret);
> + return ret;
> + }
Ditto.
...
> + priv->irq = platform_get_irq(pdev, 0);
> + if (priv->irq < 0) {
> + dev_err(&pdev->dev, "Failed to get TCPC irq (%d)\n", priv->irq);
The message like this is printed in case of error inside
platform_get_irq(), no need to duplicate.
> + return priv->irq;
> + }
...
> + priv->tcpci = tcpci_register_port(&pdev->dev, &priv->tcpci_data);
> + if (IS_ERR(priv->tcpci)) {
> + dev_err(&pdev->dev, "Failed to register tcpci port\n");
> + return PTR_ERR(priv->tcpci);
return dev_err_probe(); ?
> + }
...
> + if (ret) {
> + dev_err(&pdev->dev, "Failed to allocate irq (%d)\n", ret);
> + tcpci_unregister_port(priv->tcpci);
> + return ret;
Ditto.
> + }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-06-23 19:02 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 11:56 [PATCH v3 00/14] Add Mediatek MT6370 PMIC support ChiaEn Wu
2022-06-23 11:56 ` [PATCH v3 01/14] dt-bindings: usb: Add Mediatek MT6370 TCPC ChiaEn Wu
2022-06-23 11:56 ` [PATCH v3 02/14] dt-bindings: power: supply: Add Mediatek MT6370 Charger ChiaEn Wu
2022-06-24 10:27 ` Krzysztof Kozlowski
2022-06-25 0:54 ` Miles Chen
2022-06-23 11:56 ` [PATCH v3 03/14] dt-bindings: leds: mt6370: Add Mediatek mt6370 current sink type LED indicator ChiaEn Wu
2022-06-24 10:35 ` Krzysztof Kozlowski
2022-06-24 10:45 ` Krzysztof Kozlowski
2022-06-23 11:56 ` [PATCH v3 04/14] dt-bindings: leds: Add Mediatek MT6370 flashlight ChiaEn Wu
2022-06-24 11:22 ` Krzysztof Kozlowski
2022-06-23 11:56 ` [PATCH v3 05/14] dt-bindings: backlight: Add Mediatek MT6370 backlight ChiaEn Wu
2022-06-23 13:16 ` Joe Simmons-Talbott
2022-06-24 9:34 ` ChiaEn Wu
2022-06-30 21:55 ` Rob Herring
2022-06-23 11:56 ` [PATCH v3 06/14] dt-bindings: mfd: Add Mediatek MT6370 ChiaEn Wu
2022-06-24 11:39 ` Krzysztof Kozlowski
2022-06-23 11:56 ` [PATCH v3 07/14] mfd: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-06-23 18:00 ` Andy Shevchenko
2022-06-24 10:19 ` ChiaEn Wu
2022-06-28 11:52 ` Andy Shevchenko
2022-07-12 15:29 ` Lee Jones
2022-07-13 2:29 ` ChiaEn Wu
2022-07-13 8:04 ` Lee Jones
2022-07-13 9:31 ` ChiaEn Wu
2022-06-23 11:56 ` [PATCH v3 08/14] usb: typec: tcpci_mt6370: Add Mediatek MT6370 tcpci driver ChiaEn Wu
2022-06-23 18:07 ` Andy Shevchenko [this message]
2022-06-24 11:33 ` Greg KH
2022-06-23 11:56 ` [PATCH v3 09/14] regulator: mt6370: Add mt6370 DisplayBias and VibLDO support ChiaEn Wu
2022-06-23 18:18 ` Andy Shevchenko
2022-06-24 10:32 ` ChiaEn Wu
2022-06-28 11:54 ` Andy Shevchenko
2022-06-23 11:56 ` [PATCH v3 10/14] iio: adc: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-06-23 18:25 ` Andy Shevchenko
2022-06-23 11:56 ` [PATCH v3 11/14] power: supply: mt6370: Add Mediatek MT6370 charger driver ChiaEn Wu
2022-06-23 18:56 ` Andy Shevchenko
2022-06-29 15:52 ` ChiaEn Wu
2022-06-23 11:56 ` [PATCH v3 12/14] leds: mt6370: Add Mediatek MT6370 current sink type LED Indicator support ChiaEn Wu
2022-06-23 19:29 ` Randy Dunlap
2022-06-24 6:23 ` Linus Walleij
2022-06-24 6:25 ` Linus Walleij
2022-06-24 7:20 ` szuni chen
2022-06-24 21:36 ` Linus Walleij
2022-06-23 11:56 ` [PATCH v3 13/14] leds: flashlight: mt6370: Add Mediatek MT6370 flashlight support ChiaEn Wu
2022-06-23 11:56 ` [PATCH v3 14/14] video: backlight: mt6370: Add Mediatek MT6370 support ChiaEn Wu
2022-06-23 13:43 ` Daniel Thompson
2022-06-24 9:56 ` ChiaEn Wu
2022-06-23 15:48 ` (subset) [PATCH v3 00/14] Add Mediatek MT6370 PMIC support Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHp75Vchspgg_VaM+7JHD+2x+-JPkJXSdtLoqQGAx=kg5uAdSg@mail.gmail.com' \
--to=andy.shevchenko@gmail.com \
--cc=alice_chen@richtek.com \
--cc=broonie@kernel.org \
--cc=chiaen_wu@richtek.com \
--cc=chunfeng.yun@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=daniel.thompson@linaro.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jic23@kernel.org \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=peterwu.pub@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=szunichen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).