From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DFBDC433EF for ; Tue, 4 Jan 2022 14:14:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232362AbiADOOk (ORCPT ); Tue, 4 Jan 2022 09:14:40 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230361AbiADOOk (ORCPT ); Tue, 4 Jan 2022 09:14:40 -0500 Received: from mail-ed1-x52e.google.com (mail-ed1-x52e.google.com [IPv6:2a00:1450:4864:20::52e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2430C061761; Tue, 4 Jan 2022 06:14:39 -0800 (PST) Received: by mail-ed1-x52e.google.com with SMTP id n30so36904178eda.13; Tue, 04 Jan 2022 06:14:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2JWj20KokVmbJ1KQKxKTcG8eJrd73Z/FrzXrGHNXIYQ=; b=imO7AvZwhSqnGrvwQeVkNBV4cnKH740zTDdLNAdNiGGp8f1uzMHM0ttEykYxr4BWkl EkpRaK27dAFloGoRxR/z3ktW/nI2W1fjbRqdG/vW2Rzbz8W5GsA8BmfeRrBxDuIF6YAc gsobO4KfR1xNVt8kv6nGcpxJJ9MlEx03qb2MIeox+TvS6rChq2QG/jh5F3+3fjer/OWF EXugqwqpk99xC2zv8OvQkthpwRisIS48WSh2YJBvH28BpBkjlc+TAK11GHvyd2Zgw62T cNZrAoybRhVa0DH0GWIto1H1D3kAStNkvi9lWPyoQ8gZFkO8lzTMRwINGVlA8fhIRLo5 s7bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2JWj20KokVmbJ1KQKxKTcG8eJrd73Z/FrzXrGHNXIYQ=; b=DsR2lMJofNzmgKf1icbosWwLFoDU5EA1iP/BLYwce7Gs8F8k+ODTbPYDJ4D5dUMNBv snPZ2mW0lnfJ9s6lMN0Pf++HGEl1AVUl2P4MZtMUDLqLB6GdCGTZeuG9V/vr/Ar5MgH0 4IaOQWJ7E1TLR5zmnTkIHXgo856wdbGfQ5xlDooU9YN7W7PLtoUngsuAmFiJcrvSjpD1 Oh/8HBSekFOlzBQdyYNJ28o0p4qA9mJr/ACl7tYfsx16R0uVe6tYMEF7P/owj+JrOF5L 6irrro/Ik99nlufHghTL2OV11SRQgGfd+QJYU+rA4pg0OUBo7f7VGhlG46sziA+YjgiR RPUw== X-Gm-Message-State: AOAM530IuWULbuDyBpNdWwR66K/MoKJyT0pMZFzegVfg/nX0wL6Ezk+C PKc54qvtZ9udkQRsI+bpTR9nwHlVBPHEkcopBN0= X-Google-Smtp-Source: ABdhPJxFlwpFpUZdQ6bUszycW6INa0R+GLudK5872rFm8RVazA48OfXiqtyIAKFwq0RNQGHYzU8rSvivGo46xnrW/5g= X-Received: by 2002:a17:906:3ed0:: with SMTP id d16mr38660386ejj.636.1641305678365; Tue, 04 Jan 2022 06:14:38 -0800 (PST) MIME-Version: 1.0 References: <20220104072658.69756-1-marcan@marcan.st> <20220104072658.69756-13-marcan@marcan.st> In-Reply-To: <20220104072658.69756-13-marcan@marcan.st> From: Andy Shevchenko Date: Tue, 4 Jan 2022 16:12:47 +0200 Message-ID: Subject: Re: [PATCH v2 12/35] brcmfmac: pcie: Fix crashes due to early IRQs To: Hector Martin Cc: Kalle Valo , "David S. Miller" , Jakub Kicinski , Rob Herring , "Rafael J. Wysocki" , Len Brown , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Dmitry Osipenko , Sven Peter , Alyssa Rosenzweig , Mark Kettenis , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Pieter-Paul Giesberts , Linus Walleij , Hans de Goede , "John W. Linville" , "brian m. carlson" , "open list:TI WILINK WIRELES..." , netdev , devicetree , Linux Kernel Mailing List , ACPI Devel Maling List , "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" , SHA-cyfmac-dev-list@infineon.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Jan 4, 2022 at 9:29 AM Hector Martin wrote: > > The driver was enabling IRQs before the message processing was > initialized. This could cause IRQs to come in too early and crash the > driver. Instead, move the IRQ enable and hostready to a bus preinit > function, at which point everything is properly initialized. > > Fixes: 9e37f045d5e7 ("brcmfmac: Adding PCIe bus layer support.") You should gather fixes at the beginning of the series, and even possible to send them as a separate series. In the current state it's unclear if there are dependencies on your new feature (must not be for fixes that meant to be backported). -- With Best Regards, Andy Shevchenko