From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Christian Lamparter <chunkeey@googlemail.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
devicetree <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>,
"Álvaro Fernández" <noltari@gmail.com>,
"Kumar Gala" <galak@codeaurora.org>,
"Alexander Shiyan" <shc_work@mail.ru>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Mark Rutland" <mark.rutland@arm.com>,
"Pawel Moll" <pawel.moll@arm.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Alexandre Courbot" <gnurou@gmail.com>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Julien Grossholtz" <julien.grossholtz@savoirfairelinux.com>,
"Martyn Welch" <martyn.welch@ge.com>,
"Jonas Jensen" <jonas.jensen@gmail.com>
Subject: Re: [PATCH v7 3/3] gpio: move clps711x, moxart, ts4800 and gpio-ge into gpio-mmio
Date: Fri, 6 May 2016 16:25:49 +0300 [thread overview]
Message-ID: <CAHp75Vf5AP88TMFqVHOD5197vj40QpKRaW0jkOQ9kwz2rzYdWw@mail.gmail.com> (raw)
In-Reply-To: <4995974.1A7SuhXPf2@debian64>
On Fri, May 6, 2016 at 4:06 PM, Christian Lamparter
<chunkeey@googlemail.com> wrote:
> On Friday, May 06, 2016 02:53:24 PM Andy Shevchenko wrote:
>> On Fri, May 6, 2016 at 2:10 PM, Christian Lamparter
>> <chunkeey@googlemail.com> wrote:
>> Just a nit: possible to use switch case?
> I think so. I've integrated the id < 0 || id > 4 check as well.
> I don't know, I liked the old version more, it was shorter
>
> diff --git a/drivers/gpio/gpio-mmio.c b/drivers/gpio/gpio-mmio.c
> index f116786..f71021c 100644
> --- a/drivers/gpio/gpio-mmio.c
> +++ b/drivers/gpio/gpio-mmio.c
> @@ -619,14 +619,25 @@ static int clps711x_parse_dt(struct platform_device *pdev,
> const char *dir_reg_name;
> int id = np ? of_alias_get_id(np, "gpio") : pdev->id;
>
> - if ((id < 0) || (id > 4))
> + switch (id) {
> + case 0:
> + case 1:
> + case 2:
> + pdata->ngpio = 0; /* determined by register width */
> + dir_reg_name = "dirout";
> + break;
> + case 3:
> + pdata->ngpio = 0; /* determined by register width */
> + /* PORTD is inverted logic for direction register */
> + dir_reg_name = "dirin";
> + break;
> + case 4:
> + pdata->ngpio = 3; /* PORTE is 3 lines only */
> + dir_reg_name = "dirout";
> + break;
> + default:
> return -ENODEV;
> -
> - /* PORTE is 3 lines only */
> - pdata->ngpio = (id == 4) ? 3 : /* determined by register width */ 0;
> -
> - /* PORTD is inverted logic for direction register */
> - dir_reg_name = (id == 3) ? "dirin" : "dirout",
> + }
For my personal taste the switch case more understandable / readable.
But i'm not totally objecting the old model, just a subject to discuss.
>> > +struct compat_gpio_device_data {
>> > + unsigned int expected_resource_size;
>> > + unsigned int ngpio;
>> > + resource_size_t register_width;
>> > + unsigned long flags;
>> > + int (*call_back)(struct platform_device *pdev,
>> > + struct bgpio_pdata *pdata,
>> > + unsigned long *flags);
>> > + struct resource_replacement {
>> > + resource_size_t start_offset;
>> > + const char *name;
>> > + } resources[5];
>>
>> I would define magic number with a description what are those 5.
>
> Difficult, these are 5 placeholders for the named resources.
> There's particular order so a enum like
> {
> DAT,
> SET,
> CLR,
> DIRIN,
> DIROUT,
> __NUM_RES
> }
>
> might look nice but it has no purpose other than maybe confusing people
> why the entries aren't used.
OK, might be just
#define …_SUPPORTED_RES_MAX 5
…
} resources[_SUPPORTED_RES_MAX];
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-gpio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2016-05-06 13:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 11:10 [PATCH v7 0/3] gpio: add DT support for memory-mapped GPIOs Christian Lamparter
2016-05-06 11:10 ` [PATCH v7 1/3] gpio: dt-bindings: add wd,mbl-gpio bindings Christian Lamparter
[not found] ` <cover.1462372360.git.chunkeey-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2016-05-06 11:10 ` [PATCH v7 2/3] gpio: mmio: add DT support for memory-mapped GPIOs Christian Lamparter
2016-05-06 11:44 ` Andy Shevchenko
[not found] ` <CAHp75VcDPY+LbV5+j9DUMJ8Ws=O9=+KmAa9Nog-JuKkPGAM6Cw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-05-06 12:22 ` Christian Lamparter
2016-05-06 11:50 ` Mark Rutland
2016-05-06 11:10 ` [PATCH v7 3/3] gpio: move clps711x, moxart, ts4800 and gpio-ge into gpio-mmio Christian Lamparter
2016-05-06 11:53 ` Andy Shevchenko
[not found] ` <CAHp75VeFjcPX+f3j+h+OL2jEpfGP+aqL78ymcsj4JwUfO0RvtA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-05-06 13:06 ` Christian Lamparter
2016-05-06 13:25 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHp75Vf5AP88TMFqVHOD5197vj40QpKRaW0jkOQ9kwz2rzYdWw@mail.gmail.com \
--to=andy.shevchenko@gmail.com \
--cc=chunkeey@googlemail.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gnurou@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jonas.jensen@gmail.com \
--cc=julien.grossholtz@savoirfairelinux.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martyn.welch@ge.com \
--cc=noltari@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).