From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v2 0/2] eeprom: at24: write-protect pin support Date: Wed, 20 Dec 2017 12:21:26 +0200 Message-ID: References: <20171220082633.32237-1-brgl@bgdev.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <20171220082633.32237-1-brgl-ARrdPY/1zhM@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Bartosz Golaszewski Cc: Rob Herring , Mark Rutland , Linus Walleij , Peter Rosin , linux-i2c , devicetree , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On Wed, Dec 20, 2017 at 10:26 AM, Bartosz Golaszewski wrote: > AT24 EEPROMs have a write-protect pin, which - when pulled high - > inhibits writes to the upper quadrant of memory (although it has been > observed that on some chips it disables writing to the entire memory > range). > > On some boards, this pin is connected to a GPIO and pulled high by > default, which forces the user to manually change its state before > writing. On linux this means that we either need to hog the line all > the time, or set the GPIO value before writing from outside of the > at24 driver. > > This series adds support for the write-protect pin split into two > parts. The first patch extends the relevant binding document, while > the second modifies the at24 code to pull the write-protect GPIO > low (if present) during write operations. > Reviewed-by: Andy Shevchenko A one totally minor nit: if it possible now to have one line where devm_gpiod_get_optional() is called? You may ignore this nit anyway. > v1 -> v2: > - renamed the DT property to wp-gpios > > Bartosz Golaszewski (2): > dt-bindings: at24: new optional property - wp-gpios > eeprom: at24: add support for the write-protect pin > > Documentation/devicetree/bindings/eeprom/at24.txt | 3 +++ > drivers/misc/eeprom/at24.c | 11 +++++++++++ > 2 files changed, 14 insertions(+) > > -- > 2.15.1 > -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html