From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01B98C433E1 for ; Fri, 5 Jun 2020 08:07:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D556E207D5 for ; Fri, 5 Jun 2020 08:07:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ooV6D/FP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726135AbgFEIHt (ORCPT ); Fri, 5 Jun 2020 04:07:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47202 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726024AbgFEIHt (ORCPT ); Fri, 5 Jun 2020 04:07:49 -0400 Received: from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com [IPv6:2607:f8b0:4864:20::1043]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 441F1C08C5C2; Fri, 5 Jun 2020 01:07:49 -0700 (PDT) Received: by mail-pj1-x1043.google.com with SMTP id m2so2404756pjv.2; Fri, 05 Jun 2020 01:07:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mh4Ou1kljVhmduS90PzlDrAXnymKkFPOJ7HMxIuD1Kw=; b=ooV6D/FPWvYy0szimNsEbMVLx4ELEjsAq6byLimowmFrpxqQOOnGvbGhMR9bBWXX+H rsS/Z/gP8h2jLc7FvWubJLY4ouB+hb7PbdRl3uqWatLg1z9wjEOhfekVDH3u0+GYkp4b mNUVgP3DzqQ5ipr3hMG4iWbNbaA0zmL08KVHfWfQiDMT/In9+o3QfSgQ8ScQPPCkNqlZ WuPaBoCowYeyAHNhrYJ4euXf0b8vKiOtJtwO6Wj+w2sdFw8VgkF+Qmzz0rT5TktKtUeB C6lCJCvuk3uPzweD1gpoHmpODgP2ppvphW7rJMppm2pyjDNMpZ+fLlrLc6g22StiXcA9 7dxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mh4Ou1kljVhmduS90PzlDrAXnymKkFPOJ7HMxIuD1Kw=; b=dMk8Qx0edR84yIg+wpzgyR0F3MgoTL3Dbnd2+jRHH7lJ7DNo3ZoZ1cIR4eTl0lhbHu 9rgDg0G7BTxkGmfhxz4tVnTlIzNJwPaPKlocoGN3l2iQOkGkRhCmbf7jrxEJCCG6yZco Lz935zdR9pnymshzgXc0aF3aX2xF7RGCRYYkhEX1jAti+VW4ak54cSOp33p9BAo7Qno3 P5bttYvukyyTdyiK0JoD9+aPG6y4PaCVfHTqrIXEJ/gnxawc/Of+eXjU8Pn0xU1cN8uT lGLOXG+hixI2LD5VOFyUjgYzWhQCA1X0nm5hE5GJ+mcfh1ZY9U38kEXZTRrO85I1DTar 5qiA== X-Gm-Message-State: AOAM531cWFhT4NspKMxJu9bTePYEsWyU6k4YYPZCdHMc+93gfR5Xo+fO 1OGZ+MFI3Tz156eyAdqjsg6rp3gwho/FHkNh8oQ= X-Google-Smtp-Source: ABdhPJyxNexTfAEaebDSZO4i7E1Zrn1WbnacURd4rREtFFQ7AxnFLe4wpe5cp8So8FlFIxnRiJLHBWwprn7jbMq6GlQ= X-Received: by 2002:a17:90a:1704:: with SMTP id z4mr1570669pjd.181.1591344468760; Fri, 05 Jun 2020 01:07:48 -0700 (PDT) MIME-Version: 1.0 References: <20200604211039.12689-1-michael@walle.cc> <20200604211039.12689-4-michael@walle.cc> In-Reply-To: <20200604211039.12689-4-michael@walle.cc> From: Andy Shevchenko Date: Fri, 5 Jun 2020 11:07:32 +0300 Message-ID: Subject: Re: [PATCH v4 03/11] irqchip: add sl28cpld interrupt controller support To: Michael Walle Cc: "open list:GPIO SUBSYSTEM" , devicetree , Linux Kernel Mailing List , linux-hwmon@vger.kernel.org, linux-pwm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm Mailing List , Linus Walleij , Bartosz Golaszewski , Rob Herring , Jean Delvare , Guenter Roeck , Lee Jones , Thierry Reding , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Wim Van Sebroeck , Shawn Guo , Li Yang , Thomas Gleixner , Jason Cooper , Marc Zyngier , Mark Brown , Greg Kroah-Hartman , Andy Shevchenko Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Jun 5, 2020 at 12:13 AM Michael Walle wrote: > > Add support for the interrupt controller inside the sl28 CPLD management > controller. > > The interrupt controller can handle at most 8 interrupts and is really > simplistic and consists only of an interrupt mask and an interrupt > pending register. ... > +config SL28CPLD_INTC > + bool Same Q: Why not module? ... > +static const struct of_device_id sl28cpld_intc_of_match[] = { > + { .compatible = "kontron,sl28cpld-intc" }, > + {}, There is no point to have comma in terminator line. > +}; -- With Best Regards, Andy Shevchenko