From: Krzysztof Kozlowski <krzk@kernel.org>
To: kholk11@gmail.com
Cc: mchehab@kernel.org, robh+dt@kernel.org, marijns95@gmail.com,
konradybcio@gmail.com, martin.botka1@gmail.com,
devicetree@vger.kernel.org, linux-media@vger.kernel.org,
phone-devel@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] media: dt-bindings: media: i2c: Add IMX300 CMOS sensor binding
Date: Mon, 19 Oct 2020 18:26:10 +0200 [thread overview]
Message-ID: <CAJKOXPcNth=+V7sWQV7-o9+mHseP0RJGXrPbU7smMFZgFcxGPQ@mail.gmail.com> (raw)
In-Reply-To: <20201018123106.14917-3-kholk11@gmail.com>
On Sun, 18 Oct 2020 at 14:36, <kholk11@gmail.com> wrote:
>
> From: AngeloGioacchino Del Regno <kholk11@gmail.com>
>
> Add YAML device tree binding for IMX300 CMOS image sensor, and
> the relevant MAINTAINERS entries.
>
> Signed-off-by: AngeloGioacchino Del Regno <kholk11@gmail.com>
> ---
> .../devicetree/bindings/media/i2c/imx300.yaml | 115 ++++++++++++++++++
> MAINTAINERS | 8 ++
> 2 files changed, 123 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/i2c/imx300.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/i2c/imx300.yaml b/Documentation/devicetree/bindings/media/i2c/imx300.yaml
> new file mode 100644
> index 000000000000..82fb19c5018c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/imx300.yaml
> @@ -0,0 +1,115 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/imx300.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sony 1/2.3-Inch 8Mpixel Stacked CMOS Digital Image Sensor
> +
> +maintainers:
> + - AngeloGioacchino Del Regno <kholk11@gmail.com>
> +
> +description: |-
> + The Sony IMX300 is a 1/2.3-inch Stacked CMOS (Exmor-RS) digital image
> + sensor with a pixel size of 1.08um and an active array size of
> + 5948H x 4140V. It is programmable through I2C interface at address 0x10.
> + Image data is sent through MIPI CSI-2, which is configured as either 2 or
> + 4 data lanes.
> +
> +properties:
> + compatible:
> + const: sony,imx300
> +
> + reg:
> + description: I2C device address
Skip the description, it is obvious.
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + VDIG-supply:
> + description:
> + Digital I/O voltage supply, 1.15-1.20 volts
> +
> + VANA-supply:
> + description:
> + Analog voltage supply, 2.2 volts
> +
> + VDDL-supply:
Lower-case for all three supplies.
> + description:
> + Digital core voltage supply, 1.8 volts
> +
> + reset-gpios:
> + description: |-
> + Reference to the GPIO connected to the xclr pin, if any.
> + Must be released (set high) after all supplies are applied.
> +
> + # See ../video-interfaces.txt for more details
> + port:
> + type: object
> + properties:
> + endpoint:
> + type: object
> + properties:
> + data-lanes:
> + description: |-
> + The sensor supports either two-lane, or four-lane operation.
> + If this property is omitted four-lane operation is assumed.
> + For four-lane operation the property must be set to <0 1 2 3>.
> + items:
> + - const: 0
> + - const: 1
> + - const: 2
> + - const: 3
You miss here two-lane option (oneOf). Seems there is a default, so
you could add here "default: <0 1 2 3>
> +
> + clock-noncontinuous:
> + type: boolean
> + description: |-
> + MIPI CSI-2 clock is non-continuous if this property is present,
> + otherwise it's continuous.
> +
> + link-frequencies:
> + $ref: /schemas/types.yaml#/definitions/uint64-array
> + description:
> + Allowed data bus frequencies.
> +
> + required:
> + - link-frequencies
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - VANA-supply
> + - VDIG-supply
> + - VDDL-supply
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c0 {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + imx300: sensor@10 {
> + compatible = "sony,imx300";
> + reg = <0x10>;
> + clocks = <&imx300_xclk>;
> + VANA-supply = <&imx300_vana>; /* 2.2v */
> + VDIG-supply = <&imx300_vdig>; /* 1.2v */
> + VDDL-supply = <&imx300_vddl>; /* 1.8v */
> +
> + port {
> + imx300_0: endpoint {
> + remote-endpoint = <&csi1_ep>;
> + data-lanes = <0 1 2 3>;
> + clock-noncontinuous;
> + link-frequencies = /bits/ 64 <780000000 480000000>;
> + };
> + };
> + };
> + };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index c66710dd7e0a..231937d9d16a 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16279,6 +16279,14 @@ T: git git://linuxtv.org/media_tree.git
> F: Documentation/devicetree/bindings/media/i2c/imx290.txt
> F: drivers/media/i2c/imx290.c
>
> +SONY IMX300 SENSOR DRIVER
> +M: AngeloGioacchino Del Regno <kholk11@gmail.com>
> +L: linux-media@vger.kernel.org
> +S: Maintained
> +T: git git://linuxtv.org/media_tree.git
Skip the Git tree, unless you manage it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-10-19 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-18 12:31 [PATCH 0/2] Add support for the Sony Exmor-RS IMX300 camera sensor kholk11
2020-10-18 12:31 ` [PATCH 1/2] media: i2c: Add driver " kholk11
2020-10-26 8:57 ` Dan Carpenter
2020-10-18 12:31 ` [PATCH 2/2] media: dt-bindings: media: i2c: Add IMX300 CMOS sensor binding kholk11
2020-10-19 16:26 ` Krzysztof Kozlowski [this message]
2020-10-26 13:33 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJKOXPcNth=+V7sWQV7-o9+mHseP0RJGXrPbU7smMFZgFcxGPQ@mail.gmail.com' \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kholk11@gmail.com \
--cc=konradybcio@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=marijns95@gmail.com \
--cc=martin.botka1@gmail.com \
--cc=mchehab@kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).