From: Krzysztof Kozlowski <krzk@kernel.org>
To: Bongsu Jeon <bs.jeon87@gmail.com>
Cc: bongsu.jeon@samsung.com, "kuba@kernel.org" <kuba@kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH net-next 1/2] nfc: s3fwrn82: Add driver for Samsung S3FWRN82 NFC Chip
Date: Sun, 15 Nov 2020 11:21:27 +0100 [thread overview]
Message-ID: <CAJKOXPdXYLPbYwJiroNPtzgE7v5-bHxpmt-g1zNPFrjPo4G_MA@mail.gmail.com> (raw)
In-Reply-To: <CAEx-X7eEbL8Eoxk0smUCzxb+XOeRQTGBNUZcmDyuZNYCNa1Ghw@mail.gmail.com>
On Sun, 15 Nov 2020 at 01:54, Bongsu Jeon <bs.jeon87@gmail.com> wrote:
>
> On Fri, Nov 13, 2020 at 4:26 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > On Fri, 13 Nov 2020 at 06:09, Bongsu Jeon <bongsu.jeon@samsung.com> wrote:
> > >
> > >
> > > Add driver for Samsung S3FWRN82 NFC controller.
> > > S3FWRN82 is using NCI protocol and I2C communication interface.
> > >
> > > Signed-off-by: Bongsu Jeon <bongsu.jeon@samsung.com>
> > > ---
> > > drivers/nfc/Kconfig | 1 +
> > > drivers/nfc/Makefile | 1 +
> > > drivers/nfc/s3fwrn82/Kconfig | 15 ++
> > > drivers/nfc/s3fwrn82/Makefile | 10 ++
> > > drivers/nfc/s3fwrn82/core.c | 133 +++++++++++++++
> > > drivers/nfc/s3fwrn82/i2c.c | 288 ++++++++++++++++++++++++++++++++
> > > drivers/nfc/s3fwrn82/s3fwrn82.h | 86 ++++++++++
> > > 7 files changed, 534 insertions(+)
> > > create mode 100644 drivers/nfc/s3fwrn82/Kconfig
> > > create mode 100644 drivers/nfc/s3fwrn82/Makefile
> > > create mode 100644 drivers/nfc/s3fwrn82/core.c
> > > create mode 100644 drivers/nfc/s3fwrn82/i2c.c
> > > create mode 100644 drivers/nfc/s3fwrn82/s3fwrn82.h
> >
> > No, this is a copy of existing s3fwrn5.
> >
> > Please do not add drivers which are duplicating existing ones but
> > instead work on extending them.
> >
> > Best regards,
> > Krzysztof
>
> I'm bongsu jeon and working for samsung nfc chip development.
> If I extend the code for another nfc chip model, Could I change the
> s3fwrn5 directory and Module name?
> I think the name would confuse some people if they use the other nfc
> chip like s3fwrn82.
Hi,
Renaming would only make git history trickier to follow. Multiple
drivers get extended and not renamed. Anyone configuring the kernel
should check through Kconfig description, compatibles or description
in bindings, so name of directory does not matter when looking for HW
support. Then someone would add different chip support, and you would
rename as well? So no, do not rename it.
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-11-15 10:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201113050719epcms2p7ba0a549e386259a01753714da1b79ea3@epcms2p7>
2020-11-13 5:07 ` [PATCH net-next 1/2] nfc: s3fwrn82: Add driver for Samsung S3FWRN82 NFC Chip Bongsu Jeon
2020-11-13 7:25 ` Krzysztof Kozlowski
2020-11-15 0:54 ` Bongsu Jeon
2020-11-15 10:21 ` Krzysztof Kozlowski [this message]
2020-11-16 1:59 ` Bongsu Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJKOXPdXYLPbYwJiroNPtzgE7v5-bHxpmt-g1zNPFrjPo4G_MA@mail.gmail.com \
--to=krzk@kernel.org \
--cc=bongsu.jeon@samsung.com \
--cc=bs.jeon87@gmail.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).