From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alexander Dahl <ada@thorsis.com>
Cc: linux-leds@vger.kernel.org, Alexander Dahl <post@lespocky.de>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
linux-omap@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-amlogic@lists.infradead.org, linux-mips@vger.kernel.org,
Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Jacek Anaszewski <jacek.anaszewski@gmail.com>
Subject: Re: [PATCH v6 3/7] dt-bindings: mfd: Fix schema warnings for pwm-leds
Date: Fri, 2 Oct 2020 12:12:01 +0200 [thread overview]
Message-ID: <CAJKOXPfK_fnyf0bJY_d_pKH0es3C9x07Fc425LPCr323qZkugw@mail.gmail.com> (raw)
In-Reply-To: <1708987.KbI9FDK2aH@ada>
On Fri, 2 Oct 2020 at 12:07, Alexander Dahl <ada@thorsis.com> wrote:
>
> Hello Krzysztof,
>
> Am Freitag, 2. Oktober 2020, 11:21:10 CEST schrieb Krzysztof Kozlowski:
> > On Thu, 1 Oct 2020 at 01:51, Alexander Dahl <post@lespocky.de> wrote:
> > > The node names for devices using the pwm-leds driver follow a certain
> > > naming scheme (now).
> >
> > What warning? Please post them here and in every DTS patch.
>
> ack
>
> > Your schema does not enforce pwmleds node naming (the main node, not
> > children), or at least I could not see it. You change multiple files
> > in your patchset so are you sure that all these are justified by
> > warnings pointed out by schema?
>
> The rename was suggested by Rob [1], and I think you're right, those names are
> not (yet) enforced by schema? So at least the commit message is misleading
> for now. I'll have to see if I rather reword or update the schema again.
If schema does not enforce it, then maybe just mention that you align
the children names with schema and pwmleds node to device tree
specification guidelines (node name should be generic, reflecting
function of the device). However in such case changing only pwmleds
node name in DTS (without changing children) would not be justified,
IMHO.
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-10-02 10:12 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 23:46 [PATCH v6 0/7] leds: pwm: Make automatic labels work Alexander Dahl
2020-09-30 23:46 ` [PATCH v6 1/7] leds: pwm: Remove platform_data support Alexander Dahl
2020-09-30 23:46 ` [PATCH v6 2/7] dt-bindings: leds: Convert pwm to yaml Alexander Dahl
2020-10-02 9:31 ` Krzysztof Kozlowski
2020-10-02 10:46 ` Alexander Dahl
2020-10-02 10:52 ` Krzysztof Kozlowski
2020-10-05 13:51 ` Rob Herring
2020-10-05 13:54 ` Rob Herring
2020-09-30 23:46 ` [PATCH v6 3/7] dt-bindings: mfd: Fix schema warnings for pwm-leds Alexander Dahl
2020-10-02 9:21 ` Krzysztof Kozlowski
2020-10-02 10:07 ` Alexander Dahl
2020-10-02 10:12 ` Krzysztof Kozlowski [this message]
2020-09-30 23:46 ` [PATCH v6 4/7] ARM: dts: at91: smartkiz: Reference led node directly Alexander Dahl
2020-09-30 23:46 ` [PATCH v6 5/7] ARM: dts: Fix schema warnings for pwm-leds Alexander Dahl
2020-10-02 9:12 ` Krzysztof Kozlowski
2020-10-02 9:27 ` Alexander Dahl
2020-10-02 10:06 ` Krzysztof Kozlowski
2020-09-30 23:46 ` [PATCH v6 6/7] arm64: dts: meson: " Alexander Dahl
2020-10-02 9:23 ` Neil Armstrong
2020-09-30 23:46 ` [PATCH v6 7/7] MIPS: DTS: img: " Alexander Dahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJKOXPfK_fnyf0bJY_d_pKH0es3C9x07Fc425LPCr323qZkugw@mail.gmail.com \
--to=krzk@kernel.org \
--cc=ada@thorsis.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=pavel@ucw.cz \
--cc=peter.ujfalusi@ti.com \
--cc=post@lespocky.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).