From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 301E1C11F64 for ; Thu, 1 Jul 2021 06:59:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 15E9161490 for ; Thu, 1 Jul 2021 06:59:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234489AbhGAHCZ (ORCPT ); Thu, 1 Jul 2021 03:02:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46330 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234679AbhGAHCY (ORCPT ); Thu, 1 Jul 2021 03:02:24 -0400 Received: from mail-io1-xd32.google.com (mail-io1-xd32.google.com [IPv6:2607:f8b0:4864:20::d32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDCBBC0617A8 for ; Wed, 30 Jun 2021 23:59:53 -0700 (PDT) Received: by mail-io1-xd32.google.com with SMTP id v3so6260574ioq.9 for ; Wed, 30 Jun 2021 23:59:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6WT0ggnc6y+zkQZpmAfY5vcqw6YGgCRdcKPkikOc0Nw=; b=JJDyWO50TjD2JKx8VvF5pj14yk3j1SIQkpONmRgMEcD0EJGWVUrmG2gmr8IKqEaK77 HctyKwx9tJK6K+lShpZfc0rFQfwWxrbKyEa0Ljd1itQdHqZFoTvp7/kg4mWRCs2Xy3+7 h7sYv7+E2AOnPRJPoEuk7AdQcp6OVlDVnTpf8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6WT0ggnc6y+zkQZpmAfY5vcqw6YGgCRdcKPkikOc0Nw=; b=ZlEYZL1Mn+JS5uuDY6ZpAewaQYz2tJopu4hZE0A7FAV8wk1R3ABmRSsnN5Xv6/ZLJx PtLHgbdSiBpX4BFpMHQEndhi+aUxXF92pKhe0hnKU9u3eBqvZZ1EUPUA/X+7aca5tGVQ i/66rMnUN+SbemubCn4+/ooKzio1fbE9f8NtwD978uIXielkIXdKMXZV2Q08NjZDThk+ JnFn1Lc2oWFOazaIwadma4RrqdAWY4gAEYoMqlvbo7nyNN0z1mwt7imsQnb84zbBLr2Z 2cMV7Y+8qfgbsQwE1y6zsX4eYoa7ygws1knbcjex/mLougK2TmCJmBoCSWOHYQvT/i40 cMhA== X-Gm-Message-State: AOAM531ZUqWWA3zF5cv8m5WtzgO9epwj4Uv88HA0cpQmdmEBeLayKYDm vUeZxCXJpE2HE1LBKQP+ClfEiMGyt+HW4ufhTbelcQ== X-Google-Smtp-Source: ABdhPJzHGyqZefwsLiquuhbKyd8kroyqF4uiqAGrTewcKDSPvfkci20FHon3xrv4G+J8c6C5Ms+h7k4fzdXVCt8vD/8= X-Received: by 2002:a05:6602:1c4:: with SMTP id w4mr10899930iot.44.1625122793122; Wed, 30 Jun 2021 23:59:53 -0700 (PDT) MIME-Version: 1.0 References: <20210630073311.2177374-1-hsinyi@chromium.org> In-Reply-To: <20210630073311.2177374-1-hsinyi@chromium.org> From: Hsin-Yi Wang Date: Thu, 1 Jul 2021 14:59:27 +0800 Message-ID: Subject: Re: [PATCH v2] arm64: dts: mt8183: kukui: use generic pin configs for i2c pins To: Matthias Brugger , zhiyong.tao@mediatek.com Cc: Rob Herring , Devicetree List , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "moderated list:ARM/Mediatek SoC support" , lkml Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Jun 30, 2021 at 3:33 PM Hsin-Yi Wang wrote: > > mt8183 i2c pins don't support PUPD register, so change to use generic > pin configs instead of let it fail and fallback. Though PUPD can be skipped, if we set bias-pull-up, we may miss the r0 r1 set in mtk_pinconf_adv_pull_set(). Sent another fix to replace this patch here: https://patchwork.kernel.org/project/linux-mediatek/patch/20210701065439.2527790-1-hsinyi@chromium.org/ > > Fixes: cd894e274b74 ("arm64: dts: mt8183: Add krane-sku176 board") > Signed-off-by: Hsin-Yi Wang > Reviewed-by: Chen-Yu Tsai > --- > arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > index ae549d55a94fc..69dc04c3f7fff 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui.dtsi > @@ -426,7 +426,7 @@ i2c0_pins: i2c0 { > pins_bus { > pinmux = , > ; > - mediatek,pull-up-adv = <3>; > + bias-pull-up; > mediatek,drive-strength-adv = <00>; > }; > }; > @@ -435,7 +435,7 @@ i2c1_pins: i2c1 { > pins_bus { > pinmux = , > ; > - mediatek,pull-up-adv = <3>; > + bias-pull-up; > mediatek,drive-strength-adv = <00>; > }; > }; > @@ -453,7 +453,7 @@ i2c3_pins: i2c3 { > pins_bus { > pinmux = , > ; > - mediatek,pull-up-adv = <3>; > + bias-pull-up; > mediatek,drive-strength-adv = <00>; > }; > }; > @@ -471,7 +471,7 @@ i2c5_pins: i2c5 { > pins_bus { > pinmux = , > ; > - mediatek,pull-up-adv = <3>; > + bias-pull-up; > mediatek,drive-strength-adv = <00>; > }; > }; > -- > 2.32.0.93.g670b81a890-goog >