From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hsin-Yi Wang Subject: Re: [PATCH v2 1/8] arm64: dts: mt8183: add thermal zone node Date: Thu, 30 May 2019 14:27:28 +0800 Message-ID: References: <1557494826-6044-1-git-send-email-michael.kao@mediatek.com> <1557494826-6044-2-git-send-email-michael.kao@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1557494826-6044-2-git-send-email-michael.kao@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org To: "michael.kao" Cc: Zhang Rui , Eduardo Valentin , Daniel Lezcano , Rob Herring , Mark Rutland , Matthias Brugger , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, lkml , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , linux-mediatek@lists.infradead.org List-Id: devicetree@vger.kernel.org On Fri, May 10, 2019 at 9:27 PM michael.kao wrote: > + > + tzts1: tzts1 { > + polling-delay-passive = <0>; > + polling-delay = <0>; > + thermal-sensors = <&thermal 1>; > + sustainable-power = <0>; > + trips {}; > + cooling-maps {}; > + }; > + Is 0 a valid initial sustainable-power setting? Since we'll still get warning[1] about this, though it might not be harmful. If 0 is a valid setting, maybe we should consider showing the warning of not setting this property in [2]? [1] https://elixir.bootlin.com/linux/latest/source/drivers/thermal/power_allocator.c#L570 [2] https://elixir.bootlin.com/linux/latest/source/drivers/thermal/of-thermal.c#L1049