[PATCH] arm64: dts: allwinner: h6: add eMMC voltage property for Beelink GS1

[PATCH] arm64: dts: allwinner: h6: add eMMC voltage property for Beelink GS1

[Clément Péron]

VQMMC supply is connected to BLDO2 which provides 1.8V.

Let's reflect this in the device-tree.

Fixes: 089bee8dd119 ("arm64: dts: allwinner: h6: Introduce Beelink GS1 board")
Signed-off-by: Clément Péron <peron.clem@gmail.com>
---
 arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
index 049c21718846..3f20d2c9bbbb 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
+++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
@@ -145,6 +145,7 @@ &mmc2 {
 	vqmmc-supply = <&reg_bldo2>;
 	non-removable;
 	cap-mmc-hw-reset;
+	mmc-hs200-1_8v;
 	bus-width = <8>;
 	status = "okay";
 };
-- 
2.25.1

Re: [PATCH] arm64: dts: allwinner: h6: add eMMC voltage property for Beelink GS1

[Maxime Ripard]

[-- Attachment #1: Type: text/plain, Size: 1157 bytes --]

Hi,

On Mon, Sep 28, 2020 at 05:00:37PM +0200, Clément Péron wrote:
> VQMMC supply is connected to BLDO2 which provides 1.8V.
> 
> Let's reflect this in the device-tree.

This commit log doesn't really explain what is going on though?

> Fixes: 089bee8dd119 ("arm64: dts: allwinner: h6: Introduce Beelink GS1 board")
> Signed-off-by: Clément Péron <peron.clem@gmail.com>
> ---
>  arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> index 049c21718846..3f20d2c9bbbb 100644
> --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> @@ -145,6 +145,7 @@ &mmc2 {
>  	vqmmc-supply = <&reg_bldo2>;

The Device Tree already expresses that the vqmmc supply is connected to
BLDO2 which provides 1.8V here (together with the reg_bldo2 node).

>  	non-removable;
>  	cap-mmc-hw-reset;
> +	mmc-hs200-1_8v;

Whereas this indicates that the eMMC supports the HS200 MMC mode at 1.8V

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH] arm64: dts: allwinner: h6: add eMMC voltage property for Beelink GS1

[Clément Péron]

Hi Maxime,

On Wed, 30 Sep 2020 at 12:27, Maxime Ripard <maxime@cerno.tech> wrote:
>
> Hi,
>
> On Mon, Sep 28, 2020 at 05:00:37PM +0200, Clément Péron wrote:
> > VQMMC supply is connected to BLDO2 which provides 1.8V.
> >
> > Let's reflect this in the device-tree.
>
> This commit log doesn't really explain what is going on though?
>
> > Fixes: 089bee8dd119 ("arm64: dts: allwinner: h6: Introduce Beelink GS1 board")
> > Signed-off-by: Clément Péron <peron.clem@gmail.com>
> > ---
> >  arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> > index 049c21718846..3f20d2c9bbbb 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h6-beelink-gs1.dts
> > @@ -145,6 +145,7 @@ &mmc2 {
> >       vqmmc-supply = <&reg_bldo2>;
>
> The Device Tree already expresses that the vqmmc supply is connected to
> BLDO2 which provides 1.8V here (together with the reg_bldo2 node).
>
> >       non-removable;
> >       cap-mmc-hw-reset;
> > +     mmc-hs200-1_8v;
>
> Whereas this indicates that the eMMC supports the HS200 MMC mode at 1.8V

What about a comment like this:

Sunxi mmc driver can't distinguish at runtime what's the I/O voltage
for HS200 mode.
Add a property in the device-tree to notify mmc core about this configuration.


Regards,
Clement

>
> Maxime