devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Abraham <thomas.abraham@linaro.org>
To: Seungwon Jeon <tgih.jun@samsung.com>
Cc: linux-mmc@vger.kernel.org, devicetree-discuss@lists.ozlabs.org,
	will.newton@imgtec.com, cjb@laptop.org,
	grant.likely@secretlab.ca, rob.herring@calxeda.com,
	linux-samsung-soc@vger.kernel.org, kgene.kim@samsung.com,
	girish.shivananjappa@linaro.org, jh80.chung@samsung.com,
	patches@linaro.org
Subject: Re: [PATCH v6 8/9] mmc: dw_mmc: add support for implementation specific callbacks
Date: Thu, 20 Sep 2012 10:08:46 +0530	[thread overview]
Message-ID: <CAJuYYwRUhK858ixLfZPz9UVmqJBe0=LdgjhLfazPNHE3zckDjQ@mail.gmail.com> (raw)
In-Reply-To: <001401cd966c$5fe94590$1fbbd0b0$%jun@samsung.com>

On 19 September 2012 19:10, Seungwon Jeon <tgih.jun@samsung.com> wrote:
> On Tuesday, September 18, 2012, Thomas Abraham <thomas.abraham@linaro.org> wrote:
>> -int dw_mci_pltfm_register(struct platform_device *pdev)
>> +int dw_mci_pltfm_register(struct platform_device *pdev,
>> +                             struct dw_mci_drv_data *drv_data)
>>  {
>>       struct dw_mci *host;
>>       struct resource *regs;
>> @@ -41,6 +42,7 @@ int dw_mci_pltfm_register(struct platform_device *pdev)
>>       if (host->irq < 0)
>>               return host->irq;
>>
>> +     host->drv_data = drv_data;
>>       host->dev = &pdev->dev;
>>       host->irq_flags = 0;
>>       host->pdata = pdev->dev.platform_data;
>> @@ -48,6 +50,12 @@ int dw_mci_pltfm_register(struct platform_device *pdev)
>>       if (!host->regs)
>>               return -ENOMEM;
>>
>> +     if (host->drv_data->init) {
> In non-Exynos platform, host->drv_data has NULL.

Yes, sorry, I missed that.

Chris, should I fix this and send the updated patch or shall I send a
separate fix patch.

Thanks,
Thomas.

[...]

  reply	other threads:[~2012-09-20  4:38 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-17 18:16 [PATCH v6 0/9] mmc: dw_mmc: add support for device tree based instantiation Thomas Abraham
2012-09-17 18:16 ` [PATCH v6 1/9] mmc: dw_mmc: convert copy of struct device in struct dw_mci to a reference Thomas Abraham
2012-09-17 18:16 ` [PATCH v6 2/9] mmc: dw_mmc: Use devm_* functions in dw_mmc platform driver Thomas Abraham
2012-09-17 18:16 ` [PATCH v6 3/9] mmc: dw_mmc: allow probe to succeed even if one slot is initialized Thomas Abraham
2012-09-17 18:16 ` [PATCH v6 4/9] mmc: dw_mmc: lookup for optional biu and ciu clocks Thomas Abraham
2012-09-17 18:16 ` [PATCH v6 5/9] mmc: dw_mmc: add quirk to indicate missing write protect line Thomas Abraham
2012-09-17 18:16 ` [PATCH v6 6/9] mmc: dw_mmc: add device tree support Thomas Abraham
2012-09-19 13:39   ` Seungwon Jeon
     [not found]     ` <001301cd966c$3f99f0a0$becdd1e0$%jun-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2012-09-20  4:36       ` Thomas Abraham
2012-09-21  2:27         ` Seungwon Jeon
2012-09-21  2:43           ` Jaehoon Chung
2012-09-17 18:16 ` [PATCH v6 7/9] mmc: dw_mmc: prepare functions in dw_mmc-pltfm for reuse Thomas Abraham
2012-09-17 18:16 ` [PATCH v6 8/9] mmc: dw_mmc: add support for implementation specific callbacks Thomas Abraham
2012-09-19 13:40   ` Seungwon Jeon
2012-09-20  4:38     ` Thomas Abraham [this message]
2012-09-24  3:03       ` Chris Ball
2012-10-04 12:41         ` Seungwon Jeon
2012-10-16 10:55           ` Thomas Abraham
2012-09-17 18:16 ` [PATCH v6 9/9] mmc: dw_mmc: add support for exynos specific implementation of dw-mshc Thomas Abraham
2012-09-19 13:42   ` Seungwon Jeon
2012-09-20  4:44     ` Thomas Abraham
2012-09-21  2:27       ` Seungwon Jeon
2012-09-18  1:52 ` [PATCH v6 0/9] mmc: dw_mmc: add support for device tree based instantiation Thomas Abraham
2012-09-19  6:27   ` Thomas Abraham
2012-09-19  7:05     ` Chris Ball
2012-09-19  7:31       ` Thomas Abraham
2012-09-19 13:39       ` Seungwon Jeon
2012-09-20  4:45         ` Thomas Abraham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJuYYwRUhK858ixLfZPz9UVmqJBe0=LdgjhLfazPNHE3zckDjQ@mail.gmail.com' \
    --to=thomas.abraham@linaro.org \
    --cc=cjb@laptop.org \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=girish.shivananjappa@linaro.org \
    --cc=grant.likely@secretlab.ca \
    --cc=jh80.chung@samsung.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=patches@linaro.org \
    --cc=rob.herring@calxeda.com \
    --cc=tgih.jun@samsung.com \
    --cc=will.newton@imgtec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).