From: Arnd Bergmann <arnd@arndb.de>
To: Daniel Palmer <daniel@0x0f.com>
Cc: Rob Herring <robh@kernel.org>, SoC Team <soc@kernel.org>,
DTML <devicetree@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/9] dt-bindings: arm: mstar: Add binding details for mstar,pmsleep
Date: Wed, 29 Jul 2020 16:17:43 +0200 [thread overview]
Message-ID: <CAK8P3a0iA_VQ42H6jKKTsO7Nw5NSHrvT_h2Gj9JrtJDYtYRHFQ@mail.gmail.com> (raw)
In-Reply-To: <CAFr9PXnuMCjhzYQWGBiw3ayDD36qrUc433DsSphyF5+tqetnNg@mail.gmail.com>
On Wed, Jul 29, 2020 at 2:34 PM Daniel Palmer <daniel@0x0f.com> wrote:
>
> On Wed, 29 Jul 2020 at 21:14, Arnd Bergmann <arnd@arndb.de> wrote:
> > > Does calling it "mstar,pmsleepv7" make more sense? I'm not sure what
> > > to call it really.
> >
> > Use the name of the oldest chip you know that supports it in there,
> > such as "mstar,msc313-pmsleep" if this one is specific to msc313.
>
> That makes sense. I think the original patch got merged to soc/arm/newsoc.
> Should I recreate the series or create a new patch to do the corrections?
Please send an incremental patch.
> Slightly off topic but I'm working on the series for the interrupt controller
> and I've just renamed it from mstar,msc313e-intc to mstar,v7intc.
> I originally called it msc313e because I only knew of that chip but the
> same controller is present at the same place in all of the chips so far.
> I guess I should probably rename it to mstar,msc313-intc to keep with
> the first chip it appeared in pattern?
Yes, correct. If you have multiple chips using this controller, use the
name of the oldest chip as the generic identifier and then add a more
specific one for each the later chips that also use it, so the driver is
able to tell the difference if it ever needs to, something like:
(on msc313)
compatible = "mstar,msc313-intc";
(on msc314)
compatible = "mstar,msc314-intc", "mstar,msc313-intc";
(on msc315)
compatible = "mstar,msc315-intc", "mstar,msc313-intc";
Arnd
next prev parent reply other threads:[~2020-07-29 14:18 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-28 10:03 [PATCH v2 0/9] ARM: mstar: DT filling out Daniel Palmer
2020-07-28 10:03 ` [PATCH v2 1/9] dt-bindings: arm: mstar: Add binding details for mstar,pmsleep Daniel Palmer
2020-07-28 19:16 ` [PATCH v2 1/9] dt-bindings: arm: mstar: Add binding details for mstar, pmsleep Rob Herring
2020-07-28 19:18 ` [PATCH v2 1/9] dt-bindings: arm: mstar: Add binding details for mstar,pmsleep Rob Herring
2020-07-29 9:13 ` Daniel Palmer
2020-07-29 12:13 ` Arnd Bergmann
2020-07-29 12:34 ` Daniel Palmer
2020-07-29 14:17 ` Arnd Bergmann [this message]
2020-07-28 10:03 ` [PATCH v2 2/9] dt-bindings: arm: mstar: Move existing MStar binding descriptions Daniel Palmer
2020-07-28 10:03 ` [PATCH v2 3/9] ARM: mstar: Add IMI SRAM region Daniel Palmer
2020-07-28 10:03 ` [PATCH v2 4/9] ARM: mstar: Adjust IMI size of infinity Daniel Palmer
2020-07-28 10:03 ` [PATCH v2 5/9] ARM: mstar: Adjust IMI size for mercury5 Daniel Palmer
2020-07-28 10:03 ` [PATCH v2 6/9] ARM: mstar: Adjust IMI size for infinity3 Daniel Palmer
2020-07-28 10:03 ` [PATCH v2 7/9] ARM: mstar: Add PMU Daniel Palmer
2020-07-28 10:03 ` [PATCH v2 8/9] ARM: mstar: Add "pmsleep" node to base dtsi Daniel Palmer
2020-07-28 10:03 ` [PATCH v2 9/9] ARM: mstar: Add reboot support Daniel Palmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a0iA_VQ42H6jKKTsO7Nw5NSHrvT_h2Gj9JrtJDYtYRHFQ@mail.gmail.com \
--to=arnd@arndb.de \
--cc=daniel@0x0f.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).