From: Arnd Bergmann <arnd@kernel.org>
To: Daniel Palmer <daniel@0x0f.com>
Cc: DTML <devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Rob Herring <robh@kernel.org>,
Willy Tarreau <w@1wt.eu>
Subject: Re: [PATCH 8/9] ARM: mstar: Add smp ctrl registers to infinity2m dtsi
Date: Mon, 30 Nov 2020 15:57:58 +0100 [thread overview]
Message-ID: <CAK8P3a2MC5m4PdmXnwjGw_oZinKU93LP+eYQ8qaCmH4EesH0Bw@mail.gmail.com> (raw)
In-Reply-To: <CAFr9PXnkxBeujWFqVWfonEKEJ81ExnYcjr3jRMTBobGf9q2jsA@mail.gmail.com>
On Mon, Nov 30, 2020 at 3:11 PM Daniel Palmer <daniel@0x0f.com> wrote:
>
> Hi Arnd,
>
> On Mon, 30 Nov 2020 at 22:44, Arnd Bergmann <arnd@kernel.org> wrote:
> >
> > On Mon, Nov 30, 2020 at 2:10 PM Daniel Palmer <daniel@0x0f.com> wrote:
> > >
> > > +&riu {
> > > + smpctrl@204000 {
> > > + compatible = "mstar,smpctrl";
> > > + reg = <0x204000 0x200>;
> > > + status = "okay";
> > > + };
> >
> > You probably want some more specific compatible value, in case there are
> > multiple SoCs from mstar that have an smpctrl block and they don't all use
> > an exactly identical register layout.
>
> From what I can tell these are in the same place for the infinity2m and
> the other SMP chip in this series that are in the infinity6 series.
>
> Would "mstar,i2m-smpctrl" make more sense?
Please use the exact name of the chip for the most specific name,
plus a generic identifier that makes sense for all of them. For the
generic identifier, you can normally just use whatever the oldest
chip is that you can find with that IP block.
Arnd
next prev parent reply other threads:[~2020-11-30 14:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 13:10 [PATCH 0/9] ARM: mstar: Add basic support for i2m and SMP Daniel Palmer
2020-11-30 13:10 ` [PATCH 1/9] dt-bindings: mstar: Add binding details for mstar,smpctrl Daniel Palmer
2020-11-30 13:10 ` [PATCH 2/9] dt-bindings: vendor-prefixes: Add honestar vendor prefix Daniel Palmer
2020-11-30 13:10 ` [PATCH 3/9] dt-bindings: mstar: Add Honestar SSD201_HT_V2 to mstar boards Daniel Palmer
2020-11-30 13:10 ` [PATCH 4/9] ARM: mstar: Add infinity2m support Daniel Palmer
2020-11-30 13:10 ` [PATCH 5/9] ARM: mstar: Add common dtsi for SSD201/SSD202D Daniel Palmer
2020-11-30 13:10 ` [PATCH 6/9] ARM: mstar: Add chip level dtsi for SSD202D Daniel Palmer
2020-11-30 13:10 ` [PATCH 7/9] ARM: mstar: Add dts for Honestar ssd201htv2 Daniel Palmer
2020-11-30 13:10 ` [PATCH 8/9] ARM: mstar: Add smp ctrl registers to infinity2m dtsi Daniel Palmer
2020-11-30 13:43 ` Arnd Bergmann
2020-11-30 14:11 ` Daniel Palmer
2020-11-30 14:57 ` Arnd Bergmann [this message]
2020-11-30 13:10 ` [PATCH 9/9] ARM: mstar: SMP support Daniel Palmer
2020-11-30 13:42 ` Arnd Bergmann
2020-11-30 14:25 ` Daniel Palmer
2020-11-30 16:03 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a2MC5m4PdmXnwjGw_oZinKU93LP+eYQ8qaCmH4EesH0Bw@mail.gmail.com \
--to=arnd@kernel.org \
--cc=arnd@arndb.de \
--cc=daniel@0x0f.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).