From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH 1/3] arm: spear600: Add missing interrupt-parent of rtc Date: Fri, 12 Jan 2018 09:56:40 +0100 Message-ID: References: <20180112020711.6gp2pnsxxjzelidq@localhost> <20180112032223.GK3626@vireshk-i7> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Olof Johansson Cc: Viresh Kumar , ARM-SoC Maintainers , Linux ARM Mailing List , Rob Herring , DTML , gregkh List-Id: devicetree@vger.kernel.org On Fri, Jan 12, 2018 at 4:23 AM, Olof Johansson wrote: > On Thu, Jan 11, 2018 at 7:22 PM, Viresh Kumar wrote: >> On 11-01-18, 18:07, Olof Johansson wrote: >>> On Thu, Jan 11, 2018 at 11:28:51AM +0530, Viresh Kumar wrote: >>> > The interrupt-parent of rtc was missing, add it. >>> > >>> > Fixes: 8113ba917dfa ("ARM: SPEAr: DT: Update device nodes") >>> > Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org # v3.8+ >>> > Reported-by: Arnd Bergmann >>> > Signed-off-by: Viresh Kumar >>> >>> Applied to next/dt. Is stable really needed on this? It's been broken since >>> pretty much forever, and nobody has complained... :) >> >> Not sure. Just thought it may be useful for someone somewhere :) > > Ok. Left the tags there, but didn't merge into fixes since we're late > in -rc and this didn't seem critical at this time. My plan was to have these in the fixes branch in the hope of making it to a clean build for 4.15 after all, they fix warnings that got introduced by the updated dtc checks in 4.15-rc1. We are getting fairly close, but it seems we still miss a few, so we might as well give up at this point. The remaining fixes should be easy to backport into v4.15.y if we decide to do it, of further back even. For v4.14 and before, the in-kernel copy of dtc won't warn, but mainline dtc will. Greg, let me know your thoughts on this for the upcoming 4.15.y release. We had hundreds of dtc warnings in 4.15-rc1, many of them about important bugs, now we're down to a couple of warnings for platforms we don't care about much, and I expect the last of these fixes to land in 4.16-rc1 or maybe -rc2. Shall we backport them all to get a clean 4.15.y release? Note: there was at least one dtc warning fix that caused a serious regression in code that relied on a device probe to fail because of an invalid node (a fix is still in the works for 4.15), though generally the fixes are really harmless and can only make things better. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html