Re: [PATCH v6 31/36] dt-bindings: nds32 CPU Bindings

[Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>]

On Fri, Jan 19, 2018 at 3:32 PM, Greentime Hu <green.hu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> 2018-01-18 19:02 GMT+08:00 Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>:
>> On Mon, Jan 15, 2018 at 6:53 AM, Greentime Hu <green.hu-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>>> From: Greentime Hu <greentime-MUIXKm3Oiri1Z/+hSey0Gg@public.gmane.org>
>>>
>>> This patch adds nds32 CPU binding documents.
>>>
>>> Signed-off-by: Vincent Chen <vincentc-MUIXKm3Oiri1Z/+hSey0Gg@public.gmane.org>
>>> Signed-off-by: Rick Chen <rick-MUIXKm3Oiri1Z/+hSey0Gg@public.gmane.org>
>>> Signed-off-by: Zong Li <zong-MUIXKm3Oiri1Z/+hSey0Gg@public.gmane.org>
>>> Signed-off-by: Greentime Hu <greentime-MUIXKm3Oiri1Z/+hSey0Gg@public.gmane.org>
>>> Reviewed-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>>> ---
>>>  Documentation/devicetree/bindings/nds32/cpus.txt |   37 ++++++++++++++++++++++
>>>  1 file changed, 37 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/nds32/cpus.txt
>>>
>>> diff --git a/Documentation/devicetree/bindings/nds32/cpus.txt b/Documentation/devicetree/bindings/nds32/cpus.txt
>>> new file mode 100644
>>> index 0000000..9a52937
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/nds32/cpus.txt
>>> @@ -0,0 +1,37 @@
>>> +* Andestech Processor Binding
>>> +
>>> +This binding specifies what properties must be available in the device tree
>>> +representation of a Andestech Processor Core, which is the root node in the
>>> +tree.
>>> +
>>> +Required properties:
>>> +
>>> +       - compatible:
>>> +               Usage: required
>>> +               Value type: <string>
>>> +               Definition: should be one of:
>>> +                       "andestech,n13"
>>> +                       "andestech,n15"
>>> +                       "andestech,d15"
>>> +                       "andestech,n10"
>>> +                       "andestech,d10"
>>> +                       "andestech,nds32v3"
>>
>> Based on https://lkml.org/lkml/2017/11/27/1290, this should say that
>> the device tree should always list 'andestech,nds32v3' as the most
>> generic 'compatible' value and list exactly one of the others in
>> addition.

> I will remove the others and just left "andestech,nds32v3" in here.

No, is not what we want here, the CPU node should list exactly which core
is used, what we need in the description is a clarification that
andestech,nds32v3 must be used in addition to the more specific
string.

       Arnd
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html