devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 1/2] dt-bindings: Add E Ink to vendor bindings
@ 2021-06-15 10:33 Alistair Francis
  2021-06-15 10:33 ` [PATCH v2 2/2] drm/panel: Add support for E Ink VB3300-KCA Alistair Francis
  0 siblings, 1 reply; 4+ messages in thread
From: Alistair Francis @ 2021-06-15 10:33 UTC (permalink / raw)
  To: robh+dt, thierry.reding, sam, krzk, shawnguo, daniel, linux,
	kuninori.morimoto.gx, max.Merchel, geert+renesas, airlied,
	daniel
  Cc: devicetree, linux-kernel, dri-devel, alistair23,
	Alistair Francis, Rob Herring

Add the E Ink Corporation to the vendor bindings.

Signed-off-by: Alistair Francis <alistair@alistair23.me>
Acked-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
index abd878ff23d5..a35cec512530 100644
--- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
+++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
@@ -335,6 +335,8 @@ patternProperties:
     description: eGalax_eMPIA Technology Inc
   "^einfochips,.*":
     description: Einfochips
+  "^eink,.*":
+    description: E Ink Corporation
   "^elan,.*":
     description: Elan Microelectronic Corp.
   "^element14,.*":
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH v2 2/2] drm/panel: Add support for E Ink VB3300-KCA
  2021-06-15 10:33 [PATCH v2 1/2] dt-bindings: Add E Ink to vendor bindings Alistair Francis
@ 2021-06-15 10:33 ` Alistair Francis
  2021-06-24 20:52   ` Rob Herring
  0 siblings, 1 reply; 4+ messages in thread
From: Alistair Francis @ 2021-06-15 10:33 UTC (permalink / raw)
  To: robh+dt, thierry.reding, sam, krzk, shawnguo, daniel, linux,
	kuninori.morimoto.gx, max.Merchel, geert+renesas, airlied,
	daniel
  Cc: devicetree, linux-kernel, dri-devel, alistair23, Alistair Francis

Add support for the 10.3" E Ink panel described at:
https://www.eink.com/product.html?type=productdetail&id=7

Signed-off-by: Alistair Francis <alistair@alistair23.me>
---
v2:
 - Fix build warning
 - Document new string

 .../bindings/display/panel/panel-simple.yaml  |  2 ++
 drivers/gpu/drm/panel/panel-simple.c          | 29 +++++++++++++++++++
 2 files changed, 31 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
index b3797ba2698b..799e20222551 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
@@ -128,6 +128,8 @@ properties:
         # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
       - edt,etm0700g0dh6
       - edt,etm0700g0edh6
+        # E Ink VB3300-KCA
+      - eink,vb3300-kca
         # Evervision Electronics Co. Ltd. VGG804821 5.0" WVGA TFT LCD Panel
       - evervision,vgg804821
         # Foxlink Group 5" WVGA TFT LCD panel
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
index be312b5c04dd..600e054ec521 100644
--- a/drivers/gpu/drm/panel/panel-simple.c
+++ b/drivers/gpu/drm/panel/panel-simple.c
@@ -2004,6 +2004,32 @@ static const struct panel_desc edt_etm0700g0bdh6 = {
 	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
 };
 
+static const struct display_timing eink_vb3300_kca_timing = {
+	.pixelclock = { 40000000, 40000000, 40000000 },
+	.hactive = { 334, 334, 334 },
+	.hfront_porch = { 1, 1, 1 },
+	.hback_porch = { 1, 1, 1 },
+	.hsync_len = { 1, 1, 1 },
+	.vactive = { 1405, 1405, 1405 },
+	.vfront_porch = { 1, 1, 1 },
+	.vback_porch = { 1, 1, 1 },
+	.vsync_len = { 1, 1, 1 },
+	.flags = DISPLAY_FLAGS_HSYNC_LOW | DISPLAY_FLAGS_VSYNC_LOW |
+		 DISPLAY_FLAGS_DE_HIGH | DISPLAY_FLAGS_PIXDATA_POSEDGE,
+};
+
+static const struct panel_desc eink_vb3300_kca = {
+	.timings = &eink_vb3300_kca_timing,
+	.num_timings = 1,
+	.bpc = 6,
+	.size = {
+		.width = 157,
+		.height = 209,
+	},
+	.bus_format = MEDIA_BUS_FMT_RGB888_1X24,
+	.bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE,
+};
+
 static const struct display_timing evervision_vgg804821_timing = {
 	.pixelclock = { 27600000, 33300000, 50000000 },
 	.hactive = { 800, 800, 800 },
@@ -4302,6 +4328,9 @@ static const struct of_device_id platform_of_match[] = {
 	}, {
 		.compatible = "edt,etm0700g0dh6",
 		.data = &edt_etm0700g0dh6,
+	}, {
+		.compatible = "eink,vb3300-kca",
+		.data = &eink_vb3300_kca,
 	}, {
 		.compatible = "edt,etm0700g0bdh6",
 		.data = &edt_etm0700g0bdh6,
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH v2 2/2] drm/panel: Add support for E Ink VB3300-KCA
  2021-06-15 10:33 ` [PATCH v2 2/2] drm/panel: Add support for E Ink VB3300-KCA Alistair Francis
@ 2021-06-24 20:52   ` Rob Herring
  2021-07-04 10:29     ` Alistair Francis
  0 siblings, 1 reply; 4+ messages in thread
From: Rob Herring @ 2021-06-24 20:52 UTC (permalink / raw)
  To: Alistair Francis
  Cc: thierry.reding, sam, krzk, shawnguo, daniel, linux,
	kuninori.morimoto.gx, max.Merchel, geert+renesas, airlied,
	daniel, devicetree, linux-kernel, dri-devel, alistair23

On Tue, Jun 15, 2021 at 08:33:12PM +1000, Alistair Francis wrote:
> Add support for the 10.3" E Ink panel described at:
> https://www.eink.com/product.html?type=productdetail&id=7
> 
> Signed-off-by: Alistair Francis <alistair@alistair23.me>
> ---
> v2:
>  - Fix build warning
>  - Document new string
> 
>  .../bindings/display/panel/panel-simple.yaml  |  2 ++
>  drivers/gpu/drm/panel/panel-simple.c          | 29 +++++++++++++++++++
>  2 files changed, 31 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> index b3797ba2698b..799e20222551 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> @@ -128,6 +128,8 @@ properties:
>          # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
>        - edt,etm0700g0dh6
>        - edt,etm0700g0edh6
> +        # E Ink VB3300-KCA
> +      - eink,vb3300-kca

Combining this with patch 1 would be preferrable. Either way,

Acked-by: Rob Herring <robh@kernel.org>

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2 2/2] drm/panel: Add support for E Ink VB3300-KCA
  2021-06-24 20:52   ` Rob Herring
@ 2021-07-04 10:29     ` Alistair Francis
  0 siblings, 0 replies; 4+ messages in thread
From: Alistair Francis @ 2021-07-04 10:29 UTC (permalink / raw)
  To: Rob Herring
  Cc: Alistair Francis, thierry.reding, sam, Krzysztof Kozlowski,
	Shawn Guo, daniel, linux, kuninori.morimoto.gx, max.Merchel,
	geert+renesas, airlied, Daniel Vetter, devicetree,
	Linux Kernel Mailing List, dri-devel

On Fri, Jun 25, 2021 at 6:52 AM Rob Herring <robh@kernel.org> wrote:
>
> On Tue, Jun 15, 2021 at 08:33:12PM +1000, Alistair Francis wrote:
> > Add support for the 10.3" E Ink panel described at:
> > https://www.eink.com/product.html?type=productdetail&id=7
> >
> > Signed-off-by: Alistair Francis <alistair@alistair23.me>
> > ---
> > v2:
> >  - Fix build warning
> >  - Document new string
> >
> >  .../bindings/display/panel/panel-simple.yaml  |  2 ++
> >  drivers/gpu/drm/panel/panel-simple.c          | 29 +++++++++++++++++++
> >  2 files changed, 31 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > index b3797ba2698b..799e20222551 100644
> > --- a/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple.yaml
> > @@ -128,6 +128,8 @@ properties:
> >          # Emerging Display Technology Corp. WVGA TFT Display with capacitive touch
> >        - edt,etm0700g0dh6
> >        - edt,etm0700g0edh6
> > +        # E Ink VB3300-KCA
> > +      - eink,vb3300-kca
>
> Combining this with patch 1 would be preferrable. Either way,
>
> Acked-by: Rob Herring <robh@kernel.org>

This should be ready to merge.

Let me know if you want me to squash the patches and send a v3.

Alistair

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-04 10:29 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-15 10:33 [PATCH v2 1/2] dt-bindings: Add E Ink to vendor bindings Alistair Francis
2021-06-15 10:33 ` [PATCH v2 2/2] drm/panel: Add support for E Ink VB3300-KCA Alistair Francis
2021-06-24 20:52   ` Rob Herring
2021-07-04 10:29     ` Alistair Francis

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).