From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10BBAC43603 for ; Wed, 18 Dec 2019 11:11:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CDA0A24650 for ; Wed, 18 Dec 2019 11:11:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="aaCfR0uO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726743AbfLRLLF (ORCPT ); Wed, 18 Dec 2019 06:11:05 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:42609 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726726AbfLRLLF (ORCPT ); Wed, 18 Dec 2019 06:11:05 -0500 Received: by mail-wr1-f66.google.com with SMTP id q6so1800444wro.9 for ; Wed, 18 Dec 2019 03:11:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=IiFtSfDjWGdjcVj/Cig3gW5ylZi2W/jVaaneb1ETE7o=; b=aaCfR0uOJKRxlZ0/X60eJqXxOjxofImtpit3PnZQuo2PmTiNAoDqoqUZ1rnr7eEMyL nyKXD3Wo0nCOQr8TT/Qk1yhUsS3YtZ/AKFs4peQWK+HLYscjC8dUwWuMGoSjCgHgu43c 2y1N1rYGSvDo4F9T7VwOtMlQ5DP0whuL3x1A2cO6fipPV/+TDZM6r0mfGyr/MbIE6ygB 0lNrgijd7PNF+JcJAfXu8EUUxgNu0zkCRx11SYoAIKVfkuApVrIEE3IzjZZFASZDSkxQ evSXUVQNVQePgtXbCmbeQKr6P0l7FmnxbWSOZTwQuXciYUwu9foOR7sc+39guYR0Jzan atrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=IiFtSfDjWGdjcVj/Cig3gW5ylZi2W/jVaaneb1ETE7o=; b=QSEOjqmmdjfvtUu6uqz94IejJLdgCBP1Uagidgg1XJbZByjSyBxodGJmoWLOs14a1R BnQawOFqS7nR9amMefRp0aJDAHr8zADOjNt903b0WnwF1LfFUz8A9NbtWz2C1X+LeraU 0MQiwKrKCNpJ+cCi0Vax9U8PRtxlGdfx/7SgtprCvlNbidKRhj/LKgwKSD+E86xNToYg QmnQ4oo4tP5btPkLj9UB4ba2+JKp1NcuIV2PogepTMqxFOyXh+jm3LyfLZvQrAztCIQN a7uX6WfckoCF6ZUiw5XvwhxEwZ5PpPDVubEXHnGYZMnxYRqI/OKWfY7s4aJnSbtrsWqY ojZg== X-Gm-Message-State: APjAAAU20Et++LbXB622uEhgHVkpo7Q+SIS0vsHZ91DVzM964fooQv3M /mtrnoW2cDS+F6DOFCG6ASFX7UkimxCR0/ohtpJuNA== X-Google-Smtp-Source: APXvYqwv8hPq5nxjZHQ3sCNBeqM/+re1zUes66iqhNu796cSmk/vhcWdcgcKguzrf+023UauKjSE5fCBEw8iKR5QFe8= X-Received: by 2002:a5d:6350:: with SMTP id b16mr2245437wrw.132.1576667463555; Wed, 18 Dec 2019 03:11:03 -0800 (PST) MIME-Version: 1.0 References: <20191210154157.21930-1-ktouil@baylibre.com> <20191210154157.21930-2-ktouil@baylibre.com> In-Reply-To: From: Khouloud Touil Date: Wed, 18 Dec 2019 12:10:52 +0100 Message-ID: Subject: Re: [PATCH v2 1/4] dt-bindings: nvmem: new optional property write-protect-gpios To: Linus Walleij Cc: Bartosz Golaszewski , Rob Herring , Mark Rutland , Srinivas Kandagatla , baylibre-upstreaming@groups.io, "linux-kernel@vger.kernel.org" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-i2c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Le lun. 16 d=C3=A9c. 2019 =C3=A0 09:08, Linus Walleij a =C3=A9crit : > > On Tue, Dec 10, 2019 at 4:42 PM Khouloud Touil wrot= e: > > > + wp-gpios: > > + description: > > + GPIO to which the write-protect pin of the chip is connected. > > + The write-protect GPIO is asserted, when it's driven high > > + (logical '1') to block the write operation. It's deasserted, > > + when it's driven low (logical '0') to allow writing. > > + maxItems: 1 > > OK I guess we can't get it less convoluted. This section is consistent. > > > patternProperties: > > "^.*@[0-9a-f]+$": > > type: object > > @@ -66,6 +74,7 @@ examples: > > qfprom: eeprom@700000 { > > #address-cells =3D <1>; > > #size-cells =3D <1>; > > + wp-gpios =3D <&gpio1 3 0>; > > In the example please use the include for GPIO: > > #include > > wp-gpios =3D <&gpio1 3 GPIO_ACTIVE_HIGH>; > > You can just put the #include directive right before the > example, it should work fine. Yes sure will fix that. Thanks for your reviews. Best regards, Khouloud > > Yours, > Linus Walleij