From: Rob Herring <robh+dt@kernel.org>
To: Andrew Jeffery <andrew@aj.id.au>
Cc: openipmi-developer@lists.sourceforge.net,
Corey Minyard <minyard@acm.org>,
Mark Rutland <mark.rutland@arm.com>,
Joel Stanley <joel@jms.id.au>, Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devicetree@vger.kernel.org,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
linux-aspeed@lists.ozlabs.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: ipmi: aspeed: Introduce a v2 binding for KCS
Date: Tue, 3 Dec 2019 08:31:10 -0600 [thread overview]
Message-ID: <CAL_Jsq+3qXJbTu9G42g11PLJH-A0XeSQmJKj0obO32QFna3dEA@mail.gmail.com> (raw)
In-Reply-To: <3da2492c244962c27b21aad87bfa6bf74f568f1d.1575376664.git-series.andrew@aj.id.au>
On Tue, Dec 3, 2019 at 6:36 AM Andrew Jeffery <andrew@aj.id.au> wrote:
>
> The v2 binding utilises reg and renames some of the v1 properties.
>
> Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
> ---
> Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt | 20 +++++---
> 1 file changed, 14 insertions(+), 6 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt b/Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt
> index d98a9bf45d6c..76b180ebbde4 100644
> --- a/Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt
> +++ b/Documentation/devicetree/bindings/ipmi/aspeed-kcs-bmc.txt
> @@ -1,9 +1,10 @@
> -* Aspeed KCS (Keyboard Controller Style) IPMI interface
> +# Aspeed KCS (Keyboard Controller Style) IPMI interface
>
> The Aspeed SOCs (AST2400 and AST2500) are commonly used as BMCs
> (Baseboard Management Controllers) and the KCS interface can be
> used to perform in-band IPMI communication with their host.
>
> +## v1
> Required properties:
> - compatible : should be one of
> "aspeed,ast2400-kcs-bmc"
> @@ -12,14 +13,21 @@ Required properties:
> - kcs_chan : The LPC channel number in the controller
> - kcs_addr : The host CPU IO map address
>
> +## v2
> +Required properties:
> +- compatible : should be one of
> + "aspeed,ast2400-kcs-bmc-v2"
> + "aspeed,ast2500-kcs-bmc-v2"
> +- reg : The address and size of the IDR, ODR and STR registers
> +- interrupts : interrupt generated by the controller
> +- slave-reg : The host CPU IO map address
aspeed,slave-reg
>
> Example:
>
> - kcs3: kcs3@0 {
> - compatible = "aspeed,ast2500-kcs-bmc";
> - reg = <0x0 0x80>;
> + kcs3: kcs@24 {
> + compatible = "aspeed,ast2500-kcs-bmc-v2";
> + reg = <0x24 0x1>, <0x30 0x1>, <0x3c 0x1>;
What are the other registers in this address space? I'm not so sure
this is an improvement if you end up with a bunch of nodes with single
registers.
> interrupts = <8>;
> - kcs_chan = <3>;
> - kcs_addr = <0xCA2>;
> + slave-reg = <0xca2>;
> status = "okay";
> };
> --
> git-series 0.9.1
next prev parent reply other threads:[~2019-12-03 14:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 12:38 [PATCH 0/3] ipmi: kcs-bmc: Rework bindings to clean up DT warnings Andrew Jeffery
2019-12-03 12:38 ` [PATCH 1/3] dt-bindings: ipmi: aspeed: Introduce a v2 binding for KCS Andrew Jeffery
2019-12-03 14:31 ` Rob Herring [this message]
2019-12-05 5:13 ` Andrew Jeffery
2019-12-05 17:50 ` Rob Herring
2019-12-05 23:19 ` Andrew Jeffery
2019-12-03 12:38 ` [PATCH 2/3] ipmi: kcs: Finish configuring ASPEED KCS device before enable Andrew Jeffery
2019-12-03 13:40 ` Corey Minyard
2019-12-05 5:15 ` Andrew Jeffery
2019-12-03 12:38 ` [PATCH 3/3] ipmi: kcs: aspeed: Implement v2 bindings Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_Jsq+3qXJbTu9G42g11PLJH-A0XeSQmJKj0obO32QFna3dEA@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=andrew@aj.id.au \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).