From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BD91C2D0C3 for ; Mon, 16 Dec 2019 14:17:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 12C162082E for ; Mon, 16 Dec 2019 14:17:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576505869; bh=IQNavyKi0vrFitwEWkaIaMNA22XrAI9Jh2hXEfJH/S0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=avrUWPqEJMZNQJCabz1WdXv0vUuAZ9X9aGrd3ob2UiUHifP2HmTbgCGMAsuKUZOMe n4dR7MOhIfZAcmmkRbGQGkcdo2Mz7t9Prio9yICeBtKIAp7iOnUPiNkv+F4ZfyqQj3 M95hL7IMhno8JXCb5AFNGqgyb1rAOwjWELZYLr3M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728092AbfLPORs (ORCPT ); Mon, 16 Dec 2019 09:17:48 -0500 Received: from mail.kernel.org ([198.145.29.99]:37470 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727974AbfLPORr (ORCPT ); Mon, 16 Dec 2019 09:17:47 -0500 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B54202072B; Mon, 16 Dec 2019 14:17:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576505866; bh=IQNavyKi0vrFitwEWkaIaMNA22XrAI9Jh2hXEfJH/S0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=0UAzFff7wvUvbN58awlwQRh/zutRHMnzsFZ/J+0f6XS+7/84/k6W5/crv1KG05rHj xSPmTeMqSd/hxVbpfe4BS2z4en5pg9XCm1GD9o6NexACE0quInxp2lBpSFeNeBLcLo EZdEcXem8f1KOemOfxNOFGjwuFoSL3Iacll6YJzA= Received: by mail-qt1-f182.google.com with SMTP id t17so5852562qtr.7; Mon, 16 Dec 2019 06:17:46 -0800 (PST) X-Gm-Message-State: APjAAAXii65COQOmdKJ20nfOCpic2fR6OysbGL9QwIDpLfHD70oq+Bn/ OsrFiGlRJq7XvN+SgjJQdmqbgh5tRXHPv9z7dQ== X-Google-Smtp-Source: APXvYqz2f5Gs15/ox6X7o2WZBhM9ygGDGyp6eAHEdmJvScGaM+GL2FIGu82kDvhjbzebssozOwhOMq161rtPybRoLuw= X-Received: by 2002:ac8:59:: with SMTP id i25mr24605834qtg.110.1576505865893; Mon, 16 Dec 2019 06:17:45 -0800 (PST) MIME-Version: 1.0 References: <20191202133332.178110-1-amirmizi6@gmail.com> <20191202133332.178110-5-amirmizi6@gmail.com> <20191213223623.GA14809@bogus> In-Reply-To: From: Rob Herring Date: Mon, 16 Dec 2019 08:17:34 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 4/5] dt-bindings: tpm: Add YAML schema for TPM TIS I2C options To: Amir Mizinski Cc: Eyal.Cohen@nuvoton.com, Jarkko Sakkinen , Oshri Alkobi , Alexander Steffen , Mark Rutland , Peter Huewe , Jason Gunthorpe , Arnd Bergmann , Greg KH , devicetree , Linux Kernel Mailing List , linux-integrity@vger.kernel.org, IS20 Oshri Alkoby , Tomer Maimon , gcwilson@us.ibm.com, kgoldman@us.ibm.com, ayna@linux.vnet.ibm.com, IS30 Dan Morav , oren.tanami@nuvoton.com, shmulik.hager@nuvoton.com, amir.mizinski@nuvoton.com Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, Dec 16, 2019 at 7:53 AM Amir Mizinski wrote: > > On Sat, Dec 14, 2019 at 12:36 AM Rob Herring wrote: > > > > On Mon, Dec 02, 2019 at 03:33:31PM +0200, amirmizi6@gmail.com wrote: > > > From: Amir Mizinski > > > > > > Added a YAML schema to support tpm tis i2c realted dt-bindings for the I2c PTP based physical layer. > > > > Wrap your commmit message. And TPM, TIS?, and I2C should be capitalized. > > Thanks, ill fix that. > > > > > > > > > Signed-off-by: Amir Mizinski > > > --- > > > .../bindings/security/tpm/tpm-tis-i2c.yaml | 38 ++++++++++++++++++++++ > > > 1 file changed, 38 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/security/tpm/tpm-tis-i2c.yaml > > > > Please read my comments on v1 (The first v1 from 11/10, not the 2nd v1 > > you sent). > > I sent a follow up comment regarding this: > https://patchwork.kernel.org/patch/11236253/ > (2nd v1 was sent by mistake. sorry about that) Sorry I missed your reply. However, you didn't address these comments: > There's a bigger issue that the h/w here is more than just an I2C > protocol. The chip may have multiple power supplies, clocks, reset > lines, etc. HID over I2C seems like a similar case. Does the spec define > *all* of that? If not, you need chip specific compatibles. You can keep > this as a fallback though. To rephrase this, a protocol does not fully describe the h/w and DT should describe the h/w. Also, you should include the interrupt whether you use it in the driver currently or not. Again, it's about describing the h/w, not what a driver happens to use ATM. Rob