devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	lkml <linux-kernel@vger.kernel.org>,
	linux-spi <linux-spi@vger.kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	DTML <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/2] spi: dt-bindings: spi-controller: add wakeup-source and interrupts
Date: Fri, 15 Nov 2019 13:43:23 -0600	[thread overview]
Message-ID: <CAL_Jsq+9eejCg41poj--GDtUqOgSUoNMpB=OEAuKhNu1Ggb7Ew@mail.gmail.com> (raw)
In-Reply-To: <20191115152221.GA4210@sirena.co.uk>

On Fri, Nov 15, 2019 at 9:22 AM Mark Brown <broonie@kernel.org> wrote:
>
> On Fri, Nov 15, 2019 at 07:52:22AM -0600, Rob Herring wrote:
>
> > if:
> >   properties:
> >     interrupt-names:
> >       contains:
> >         const: wakeup
> >   required:
> >     - interrupt-names
> > then:
> >   required:
> >     - wakeup-source
>
> That seems to say that if we have a device that has an interrupt called
> "wakeup" then it must be a wakeup source.  Is that desirable?  Being
> able to wake the system is partly a property of the system as a whole
> (the wakeup signal needs to be wired somewhere where it can wake things)
> and a device might have a signal that could be used to wake the system,
> may even be called "wakeup" by the device but for some reason isn't
> wired suitably in a given system.

Perhaps it is too strict. It would be useful as a "Did you forget
wakeup-source?" message, but we don't have a way to distinguish that.

Rob

      reply	other threads:[~2019-11-15 19:43 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-12  5:54 [PATCH 0/2] spi: add wakeup handling to SPI core Dmitry Torokhov
2019-11-12  5:54 ` [PATCH 1/2] spi: dt-bindings: spi-controller: add wakeup-source and interrupts Dmitry Torokhov
2019-11-12 12:03   ` Mark Brown
2019-11-12 19:03     ` Dmitry Torokhov
2019-11-12 19:15       ` Mark Brown
2019-11-12 19:36         ` Dmitry Torokhov
2019-11-12 19:42           ` Mark Brown
2019-11-14 22:26           ` Rob Herring
2019-11-14 23:08             ` Dmitry Torokhov
2019-11-15 13:52               ` Rob Herring
2019-11-15 15:22                 ` Mark Brown
2019-11-15 19:43                   ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAL_Jsq+9eejCg41poj--GDtUqOgSUoNMpB=OEAuKhNu1Ggb7Ew@mail.gmail.com' \
    --to=robh@kernel.org \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).