From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 1/3] of: add common OF-based component functionality Date: Fri, 3 Jun 2016 14:52:28 -0500 Message-ID: References: <20160603141548.GC1041@n2100.armlinux.org.uk> <20160603153630.GE1041@n2100.armlinux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160603153630.GE1041@n2100.armlinux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Russell King - ARM Linux Cc: "devicetree@vger.kernel.org" , linux-arm-msm , dri-devel , "open list:ARM/Rockchip SoC..." , linux-mediatek@lists.infradead.org, Grant Likely , Frank Rowand , "linux-arm-kernel@lists.infradead.org" List-Id: devicetree@vger.kernel.org On Fri, Jun 3, 2016 at 10:36 AM, Russell King - ARM Linux wrote: > On Fri, Jun 03, 2016 at 10:29:40AM -0500, Rob Herring wrote: >> On Fri, Jun 3, 2016 at 9:21 AM, Russell King wrote: >> > Add common OF-based component functionality for matching devices by >> > device node, and releasing the device node at the appropraite time. >> > >> > Signed-off-by: Russell King >> > --- >> > drivers/of/Makefile | 2 +- >> > drivers/of/of_component.c | 41 +++++++++++++++++++++++++++++++++++++++++ >> > include/linux/of_component.h | 14 ++++++++++++++ >> >> I'd prefer this to go into drivers/base/component.c. That's the >> general direction we've been moving. > > I'd prefer not to, I don't want to turn the component helpers into > something OF specific. They aren't OF specific. Fine, not enough code to argue about... >> I'd expect this would cause some build failures unless the cases you >> converted all depend on CONFIG_OF. > > Okay, I'll stick with v1 then, and the duplication that v1 involves. Why? You don't want to add empty functions? Seems like good clean-up. Rob