devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh+dt@kernel.org>
To: Phil Chang <phil.chang@mediatek.com>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Frank Rowand <frowand.list@gmail.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	devicetree@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"moderated list:ARM/Mediatek SoC support" 
	<linux-mediatek@lists.infradead.org>,
	YJ Chiang <yj.chiang@mediatek.com>,
	Alix Wu <alix.wu@mediatek.com>, Joe Liu <joe.liu@mediatek.com>
Subject: Re: [PATCH] [PATCH] of_reserved_mem: Increase the number of reserved regions
Date: Mon, 5 Oct 2020 08:44:11 -0500	[thread overview]
Message-ID: <CAL_JsqJ4rTChMpn7F--fh1A6bOTZxR4rEM9bbA1rdetXmPDeVA@mail.gmail.com> (raw)
In-Reply-To: <20201004055024.23542-1-phil.chang@mediatek.com>

On Sun, Oct 4, 2020 at 12:50 AM Phil Chang <phil.chang@mediatek.com> wrote:
>
> Certain SoCs need to support large amount of reserved memory
> regions, especially to follow the GKI rules from Google.
> In MTK new SoC requires more than 68 regions of reserved memory
> for each IP's usage, such as load firmware to specific sapce,

typo

> so that need to reserve more regisions

typo. Missing punctuation.

>
> Signed-off-by: Joe Liu <joe.liu@mediatek.com>
> Signed-off-by: YJ Chiang <yj.chiang@mediatek.com>
> Signed-off-by: Alix Wu <alix.wu@mediatek.com>
> Signed-off-by: Phil Chang <phil.chang@mediatek.com>
> ---
>  drivers/of/of_reserved_mem.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c
> index 46b9371c8a33..595f0741dcef 100644
> --- a/drivers/of/of_reserved_mem.c
> +++ b/drivers/of/of_reserved_mem.c
> @@ -22,7 +22,7 @@
>  #include <linux/slab.h>
>  #include <linux/memblock.h>
>
> -#define MAX_RESERVED_REGIONS   64
> +#define MAX_RESERVED_REGIONS   128

At some point, this starts to feel like abuse of reserved regions.
Please provide details on what the regions are.

Also, this probably just needs to be dynamic. I think we're at that point.

Rob

  parent reply	other threads:[~2020-10-05 13:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-04  5:50 Phil Chang
2020-10-04 13:05 ` Chun-Kuang Hu
2020-10-05 17:17   ` Phil Chang
2020-10-05 18:57     ` Rob Herring
2020-10-05 23:16       ` Chun-Kuang Hu
2020-10-05 13:44 ` Rob Herring [this message]
2020-10-05 15:12   ` Chun-Kuang Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAL_JsqJ4rTChMpn7F--fh1A6bOTZxR4rEM9bbA1rdetXmPDeVA@mail.gmail.com \
    --to=robh+dt@kernel.org \
    --cc=alix.wu@mediatek.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=joe.liu@mediatek.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=matthias.bgg@gmail.com \
    --cc=phil.chang@mediatek.com \
    --cc=yj.chiang@mediatek.com \
    --subject='Re: [PATCH] [PATCH] of_reserved_mem: Increase the number of reserved regions' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).