From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 1/3] input: touchscreen: edt-ft5x06: don't make device a wakeup source by default Date: Wed, 23 May 2018 09:45:05 -0500 Message-ID: References: <20180517090552.5704-1-daniel@zonque.org> <20180517090552.5704-2-daniel@zonque.org> <20180522175413.GA24850@rob-hp-laptop> <52c1cd13-3386-8f70-aaf2-e5f4b19fd1e6@zonque.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <52c1cd13-3386-8f70-aaf2-e5f4b19fd1e6@zonque.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Daniel Mack Cc: Mark Rutland , devicetree@vger.kernel.org, Dmitry Torokhov , Sascha Hauer , linux-input@vger.kernel.org, Fabio Estevam , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" List-Id: devicetree@vger.kernel.org On Wed, May 23, 2018 at 3:27 AM, Daniel Mack wrote: > On Tuesday, May 22, 2018 07:54 PM, Rob Herring wrote: >> >> On Thu, May 17, 2018 at 11:05:50AM +0200, Daniel Mack wrote: >>> >>> Allow configuring the device as wakeup source through device properties, >>> as >>> not all platforms want to wake up on touch screen activity. >>> >>> The I2C core automatically reads the "wakeup-source" DT property to >>> configure a device's wakeup capability, and board supports files can set >>> I2C_CLIENT_WAKE in the flags. >> >> >> This will break wake-up on working systems. Looks like mostly i.MX, but >> there's one AM437x board. If that board doesn't care, then it is up to >> Shawn. > > > I added the property to the dts files, but as Dmitry pointed out, I missed > some. Sorry for that. Just adding the property to dts files doesn't fix the compatibility problem. If a user uses an existing dtb (before this change) with a new kernel (after this change), then wakeup will stop working. Rob