From: Rob Herring <robh+dt@kernel.org>
To: Andre Przywara <andre.przywara@arm.com>
Cc: devicetree@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>,
Wim Van Sebroeck <wim@linux-watchdog.org>,
Viresh Kumar <vireshk@kernel.org>,
LINUX-WATCHDOG <linux-watchdog@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Chanho Min <chanho.min@lge.com>,
Linus Walleij <linus.walleij@linaro.org>,
Liviu Dudau <liviu.dudau@arm.com>, Li Yang <leoyang.li@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Florian Fainelli <f.fainelli@gmail.com>,
"maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Wei Xu <xuwei5@hisilicon.com>
Subject: Re: [PATCH 01/10] dt-bindings: watchdog: sp-805: Convert to Json-schema
Date: Tue, 8 Sep 2020 11:25:38 -0600 [thread overview]
Message-ID: <CAL_JsqJfY=DTKeuGmkwn-tcDG_SAbHJqASH2zKgwU-78qqwxOw@mail.gmail.com> (raw)
In-Reply-To: <CAL_Jsq+jjzFR0ZdFO5dEp2w2D2uzSAB9tdih9tnuN987LABbiA@mail.gmail.com>
On Tue, Sep 8, 2020 at 11:20 AM Rob Herring <robh+dt@kernel.org> wrote:
>
> On Fri, Aug 28, 2020 at 7:06 AM Andre Przywara <andre.przywara@arm.com> wrote:
> >
> > Convert the ARM SP-805 watchdog IP DT binding over to Json-schema.
> >
> > A straight-forward conversion, but the requirement for providing two
> > clocks got strengthened from "should" to "must".
> >
> > Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> > ---
> > .../bindings/watchdog/arm,sp805.txt | 32 --------
> > .../bindings/watchdog/arm,sp805.yaml | 75 +++++++++++++++++++
> > 2 files changed, 75 insertions(+), 32 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/watchdog/arm,sp805.txt
> > create mode 100644 Documentation/devicetree/bindings/watchdog/arm,sp805.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/arm,sp805.txt b/Documentation/devicetree/bindings/watchdog/arm,sp805.txt
> > deleted file mode 100644
> > index bee6f1f0e41b..000000000000
> > --- a/Documentation/devicetree/bindings/watchdog/arm,sp805.txt
> > +++ /dev/null
> > @@ -1,32 +0,0 @@
> > -ARM AMBA Primecell SP805 Watchdog
> > -
> > -SP805 WDT is a ARM Primecell Peripheral and has a standard-id register that
> > -can be used to identify the peripheral type, vendor, and revision.
> > -This value can be used for driver matching.
> > -
> > -As SP805 WDT is a primecell IP, it follows the base bindings specified in
> > -'arm/primecell.txt'
> > -
> > -Required properties:
> > -- compatible: Should be "arm,sp805" & "arm,primecell"
> > -- reg: Should contain location and length for watchdog timer register
> > -- clocks: Clocks driving the watchdog timer hardware. This list should be
> > - 2 clocks. With 2 clocks, the order is wdog_clk, apb_pclk
> > - wdog_clk can be equal to or be a sub-multiple of the apb_pclk
> > - frequency
> > -- clock-names: Shall be "wdog_clk" for first clock and "apb_pclk" for the
> > - second one
> > -
> > -Optional properties:
> > -- interrupts: Should specify WDT interrupt number
> > -- timeout-sec: Should specify default WDT timeout in seconds. If unset, the
> > - default timeout is determined by the driver
> > -
> > -Example:
> > - watchdog@66090000 {
> > - compatible = "arm,sp805", "arm,primecell";
> > - reg = <0x66090000 0x1000>;
> > - interrupts = <GIC_SPI 406 IRQ_TYPE_LEVEL_HIGH>;
> > - clocks = <&wdt_clk>, <&apb_pclk>;
> > - clock-names = "wdog_clk", "apb_pclk";
> > - };
> > diff --git a/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml b/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml
> > new file mode 100644
> > index 000000000000..980e155d3387
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/watchdog/arm,sp805.yaml
> > @@ -0,0 +1,75 @@
> > +# SPDX-License-Identifier: GPL-2.0
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/watchdog/arm,sp805.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: ARM AMBA Primecell SP805 Watchdog
> > +
> > +maintainers:
> > + - Viresh Kumar <vireshk@kernel.org>
> > +
> > +description: |+
> > + The Arm SP805 IP implements a watchdog device, which triggers an interrupt
> > + after a configurable time period. If that interrupt has not been serviced
> > + when the next interrupt would be triggered, the reset signal is asserted.
> > +
> > +allOf:
> > + - $ref: /schemas/arm/primecell.yaml#
>
> Should also ref watchdog.yaml here.
Actually, you should also drop primecell.yaml as that will get applied
already with the 'arm,primecell' compatible match.
Rob
next prev parent reply other threads:[~2020-09-08 17:26 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 13:05 [PATCH 00/10] dt-bindings: Convert SP805 to Json-schema (and fix users) Andre Przywara
2020-08-28 13:05 ` [PATCH 01/10] dt-bindings: watchdog: sp-805: Convert to Json-schema Andre Przywara
2020-08-31 5:28 ` Viresh Kumar
2020-09-08 17:20 ` Rob Herring
2020-09-08 17:25 ` Rob Herring [this message]
2020-08-28 13:05 ` [PATCH 02/10] arm64: dts: arm: Fix SP805 clock-names Andre Przywara
2020-08-28 13:05 ` [PATCH 03/10] arm64: dts: broadcom: " Andre Przywara
2020-08-28 17:08 ` Ray Jui
2020-08-28 19:32 ` Florian Fainelli
2020-08-31 3:57 ` Florian Fainelli
2020-08-28 13:05 ` [PATCH 04/10] arm64: dts: freescale: " Andre Przywara
2020-08-31 5:53 ` Shawn Guo
2020-08-28 13:05 ` [PATCH 05/10] arm64: dts: hisilicon: Fix SP805 clocks Andre Przywara
2020-08-28 13:05 ` [PATCH 06/10] arm64: dts: lg: " Andre Przywara
2020-08-28 13:05 ` [PATCH 07/10] ARM: dts: arm: " Andre Przywara
2020-08-28 14:45 ` Linus Walleij
2020-08-28 13:06 ` [PATCH 08/10] ARM: dts: Cygnus: " Andre Przywara
2020-08-28 17:09 ` Ray Jui
2020-08-28 19:31 ` Florian Fainelli
2020-08-31 3:55 ` Florian Fainelli
2020-08-31 3:59 ` Florian Fainelli
2020-08-28 13:06 ` [PATCH 09/10] ARM: dts: NSP: Fix SP805 clock-names Andre Przywara
2020-08-28 17:09 ` Ray Jui
2020-08-28 19:31 ` Florian Fainelli
2020-08-31 3:55 ` Florian Fainelli
2020-08-28 13:06 ` [PATCH 10/10] ARM: dts: hisilicon: Fix SP805 clocks Andre Przywara
2020-08-28 19:34 ` [PATCH 00/10] dt-bindings: Convert SP805 to Json-schema (and fix users) Florian Fainelli
2020-08-28 21:28 ` Rob Herring
2020-08-28 21:32 ` Florian Fainelli
2020-09-01 15:56 ` André Przywara
2020-09-04 8:58 ` Linus Walleij
2020-09-04 15:29 ` Florian Fainelli
2020-09-04 15:35 ` André Przywara
2020-09-04 15:40 ` Florian Fainelli
2020-09-08 12:48 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqJfY=DTKeuGmkwn-tcDG_SAbHJqASH2zKgwU-78qqwxOw@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=andre.przywara@arm.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=chanho.min@lge.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=leoyang.li@nxp.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=liviu.dudau@arm.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjui@broadcom.com \
--cc=sbranden@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=vireshk@kernel.org \
--cc=wim@linux-watchdog.org \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).