From: Rob Herring <robh+dt@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: "Marek Behún" <kabel@kernel.org>, "Pavel Machek" <pavel@ucw.cz>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Dan Murphy" <dmurphy@ti.com>,
"Sven Schwermer" <sven.schwermer@disruptive-technologies.com>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Linux LED Subsystem" <linux-leds@vger.kernel.org>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"ChiaEn Wu" <peterwu.pub@gmail.com>
Subject: Re: [PATCH] dt-bindings: leds: class-multicolor: reference class directly in multi-led node
Date: Mon, 18 Jul 2022 09:22:24 -0600 [thread overview]
Message-ID: <CAL_JsqK--sXnVCm1cQPP5-_URzYjANdA1UBvUVF6zdanrscrkQ@mail.gmail.com> (raw)
In-Reply-To: <20220624112106.111351-1-krzysztof.kozlowski@linaro.org>
On Fri, Jun 24, 2022 at 5:21 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> The leds/common.yaml is referenced directly in each LED node, which
> leads to people doing the same with leds/leds-class-multicolor.yaml.
> This is not correct because leds-class-multicolor.yaml defined multi-led
> property and its children. Some schemas implemented this incorrect.
>
> Rework this to match same behavior common.yaml, so expect the multi-led
> node to reference the leds-class-multicolor.yaml. Fixing allows to add
> unevaluatedProperties:false.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> ---
>
> This will conflict with any new users of leds-class-multicolor, e.g.:
> https://lore.kernel.org/all/20220623115631.22209-4-peterwu.pub@gmail.com/
>
> The new users should be updated to match the usage introduced here.
> ---
> .../leds/cznic,turris-omnia-leds.yaml | 2 ++
> .../bindings/leds/leds-class-multicolor.yaml | 32 +++++++++----------
> .../devicetree/bindings/leds/leds-lp50xx.yaml | 2 ++
> .../bindings/leds/leds-pwm-multicolor.yaml | 5 ++-
> .../bindings/leds/leds-qcom-lpg.yaml | 2 ++
> 5 files changed, 24 insertions(+), 19 deletions(-)
Looks like this introduced a new warning:
/builds/robherring/linux-dt/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.example.dtb:
led-controller: multi-led: Unevaluated properties are not allowed
('max-brightness' was unexpected)
From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/leds/leds-pwm-multicolor.yaml
Rob
next prev parent reply other threads:[~2022-07-18 15:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-24 11:21 [PATCH] dt-bindings: leds: class-multicolor: reference class directly in multi-led node Krzysztof Kozlowski
2022-06-30 22:27 ` Rob Herring
2022-07-05 11:52 ` Krzysztof Kozlowski
2022-07-17 12:44 ` Pavel Machek
2022-07-18 15:22 ` Rob Herring [this message]
2022-07-19 7:41 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqK--sXnVCm1cQPP5-_URzYjANdA1UBvUVF6zdanrscrkQ@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=kabel@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=peterwu.pub@gmail.com \
--cc=sven.schwermer@disruptive-technologies.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).