From: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
To: Felipe Balbi <balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
Cc: Thinh Nguyen
<Thinh.Nguyen-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>,
Linux USB List
<linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
John Youn <John.Youn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH 14/15] usb: dwc3: Add disabling of start_transfer failure quirk
Date: Thu, 11 Jan 2018 08:35:35 -0600 [thread overview]
Message-ID: <CAL_JsqK0_Ww_v=rgUb8QqNtMwgAcdR7ZKSMgqavqQqtOLr4q9Q@mail.gmail.com> (raw)
In-Reply-To: <87incbzaia.fsf-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
On Tue, Jan 9, 2018 at 2:45 AM, Felipe Balbi <balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
>
> Hi,
>
> Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> writes:
>> On Fri, Jan 05, 2018 at 12:16:02PM -0800, Thinh Nguyen wrote:
>>> In DWC_usb31 version 1.70a-ea06 and prior needs a SW workaround for isoc
>>> START TRANSFER command failure. However, some affected versions may have
>>> RTL patches to fix this without a SW workaround. Add this quirk to
>>> disable the SW workaround when it is not needed.
>>
>> I really think this one should be implied by compatible strings.
>
> won't work for dwc3. Core driver has a single compatible string, also
> this wouldn't work for PCI-based implementations.
Then you will have to look at the parent node (this is why the way
DWC3 was split is wrong) or make the compatible strings more specific.
That is the purpose of compatible strings.
For PCI, don't you have different VID/PIDs? If not how would quirks
work for non-DT systems.
Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2018-01-11 14:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-05 20:13 [PATCH 00/15] usb: dwc3: Add new updates for DWC_usb31 Thinh Nguyen
[not found] ` <cover.1515182391.git.thinhn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2018-01-05 20:14 ` [PATCH 08/15] usb: dwc3: Make RX/TX threshold configurable Thinh Nguyen
[not found] ` <8446dc260efb993507a219ae11815607b8e58027.1515182391.git.thinhn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2018-01-09 4:12 ` Rob Herring
2018-01-09 23:54 ` Thinh Nguyen
2018-01-05 20:16 ` [PATCH 14/15] usb: dwc3: Add disabling of start_transfer failure quirk Thinh Nguyen
[not found] ` <3c63b5f97343d276049e1d59ef2371160004b137.1515182391.git.thinhn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>
2018-01-09 4:16 ` Rob Herring
2018-01-09 8:45 ` Felipe Balbi
[not found] ` <87incbzaia.fsf-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2018-01-11 14:35 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqK0_Ww_v=rgUb8QqNtMwgAcdR7ZKSMgqavqQqtOLr4q9Q@mail.gmail.com' \
--to=robh-dgejt+ai2ygdnm+yrofe0a@public.gmane.org \
--cc=John.Youn-HKixBCOQz3hWk0Htik3J/w@public.gmane.org \
--cc=Thinh.Nguyen-HKixBCOQz3hWk0Htik3J/w@public.gmane.org \
--cc=balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).