From: Rob Herring <robh+dt@kernel.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: Sascha Hauer <kernel@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
devicetree@vger.kernel.org,
Collabora Kernel ML <kernel@collabora.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ian Ray <ian.ray@ge.com>, linux-spi <linux-spi@vger.kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Mark Brown <broonie@kernel.org>
Subject: Re: [PATCHv6 1/3] dt-bindings: misc: ge-achc: Convert to DT schema format
Date: Tue, 13 Jul 2021 09:07:57 -0600 [thread overview]
Message-ID: <CAL_JsqK2v9W=+GLEpAUFWeD4P3uiq2i7CWkwP9t76+e6dTtQ8A@mail.gmail.com> (raw)
In-Reply-To: <1626184993.653258.129709.nullmailer@robh.at.kernel.org>
On Tue, Jul 13, 2021 at 8:03 AM Rob Herring <robh@kernel.org> wrote:
>
> On Mon, 12 Jul 2021 17:02:40 +0200, Sebastian Reichel wrote:
> > Convert the binding to DT schema format. Also update the binding
> > to fix shortcomings
> >
> > * Add "nxp,kinetis-k20" fallback compatible
> > * add programming SPI interface and reset GPIO
> > * add main clock
> > * add voltage supplies
> > * drop spi-max-frequency from required properties,
> > driver will setup max. frequency
> >
> > Reviewed-by: Rob Herring <robh@kernel.org>
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> > ---
> > .../devicetree/bindings/misc/ge-achc.txt | 26 --------
> > .../devicetree/bindings/misc/ge-achc.yaml | 65 +++++++++++++++++++
> > 2 files changed, 65 insertions(+), 26 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/misc/ge-achc.txt
> > create mode 100644 Documentation/devicetree/bindings/misc/ge-achc.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/misc/ge-achc.example.dt.yaml: spi: spi@1:reg: [[1], [0]] is too long
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/spi-controller.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/misc/ge-achc.example.dt.yaml: spi: spi@1:reg: Additional items are not allowed ([0] was unexpected)
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/spi/spi-controller.yaml
Ignore this. The necessary change is in v5.14-rc1.
Rob
next prev parent reply other threads:[~2021-07-13 15:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-12 15:02 [PATCHv6 0/3] GE Healthcare PPD firmware upgrade driver for ACHC Sebastian Reichel
2021-07-12 15:02 ` [PATCHv6 1/3] dt-bindings: misc: ge-achc: Convert to DT schema format Sebastian Reichel
2021-07-13 14:03 ` Rob Herring
2021-07-13 15:07 ` Rob Herring [this message]
2021-07-12 15:02 ` [PATCHv6 2/3] ARM: dts: imx53-ppd: Fix ACHC entry Sebastian Reichel
2021-07-12 15:02 ` [PATCHv6 3/3] misc: gehc-achc: new driver Sebastian Reichel
2021-07-12 17:46 ` Greg Kroah-Hartman
2021-07-12 23:20 ` Sebastian Reichel
2021-07-13 5:41 ` Greg Kroah-Hartman
2021-07-13 10:46 ` Sebastian Reichel
2021-07-13 10:56 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_JsqK2v9W=+GLEpAUFWeD4P3uiq2i7CWkwP9t76+e6dTtQ8A@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=ian.ray@ge.com \
--cc=kernel@collabora.com \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=sebastian.reichel@collabora.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).